From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH 21/27] treewide: surround file paths in Kconfig files with double quotes Date: Tue, 11 Dec 2018 12:25:59 +0100 Message-ID: References: <1544526070-16690-1-git-send-email-yamada.masahiro@socionext.com> <1544526070-16690-22-git-send-email-yamada.masahiro@socionext.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <1544526070-16690-22-git-send-email-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org To: Masahiro Yamada Cc: linux-kbuild , Linux-Arch , Ulf Magnusson , Herbert Xu , Wolfram Sang , Will Deacon , Linux Kernel Mailing List , David Howells , Ingo Molnar , Thomas Gleixner , "David S. Miller" , Linux ARM List-Id: linux-arch.vger.kernel.org On Tue, Dec 11, 2018 at 12:03 PM Masahiro Yamada wrote: > The Kconfig lexer supports special characters such as '.' and '/' in > the parameter context. In my understanding, the reason is just to > support bare file paths in the source statement. > > I do not see a good reason to complicate Kconfig for the room of > ambiguity. > > The majority of code already surround file paths with double quotes, > and it makes sense since the included file paths are constant string > literals. > > Make it treewide consistent now. > > Signed-off-by: Masahiro Yamada > arch/m68k/Kconfig | 6 +++--- Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk1-f195.google.com ([209.85.221.195]:34668 "EHLO mail-vk1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726281AbeLKL0N (ORCPT ); Tue, 11 Dec 2018 06:26:13 -0500 MIME-Version: 1.0 References: <1544526070-16690-1-git-send-email-yamada.masahiro@socionext.com> <1544526070-16690-22-git-send-email-yamada.masahiro@socionext.com> In-Reply-To: <1544526070-16690-22-git-send-email-yamada.masahiro@socionext.com> From: Geert Uytterhoeven Date: Tue, 11 Dec 2018 12:25:59 +0100 Message-ID: Subject: Re: [PATCH 21/27] treewide: surround file paths in Kconfig files with double quotes Content-Type: text/plain; charset="UTF-8" Sender: linux-arch-owner@vger.kernel.org List-ID: To: Masahiro Yamada Cc: linux-kbuild , Linux-Arch , Ulf Magnusson , Herbert Xu , Wolfram Sang , Will Deacon , Linux Kernel Mailing List , David Howells , Ingo Molnar , Thomas Gleixner , "David S. Miller" , Linux ARM Message-ID: <20181211112559.vrYV7XqOEBkfx5L6VXRENSfAkOH1o4jb5MUgaibnfm0@z> On Tue, Dec 11, 2018 at 12:03 PM Masahiro Yamada wrote: > The Kconfig lexer supports special characters such as '.' and '/' in > the parameter context. In my understanding, the reason is just to > support bare file paths in the source statement. > > I do not see a good reason to complicate Kconfig for the room of > ambiguity. > > The majority of code already surround file paths with double quotes, > and it makes sense since the included file paths are constant string > literals. > > Make it treewide consistent now. > > Signed-off-by: Masahiro Yamada > arch/m68k/Kconfig | 6 +++--- Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds