From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH 6/6] driver core: initialize a default DMA mask for platform device Date: Fri, 16 Aug 2019 09:39:03 +0200 Message-ID: References: <20190816062435.881-1-hch@lst.de> <20190816062435.881-7-hch@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20190816062435.881-7-hch@lst.de> Sender: linux-kernel-owner@vger.kernel.org To: Christoph Hellwig Cc: Greg Kroah-Hartman , Maxime Chevallier , Gavin Li , Laurentiu Tudor , Minas Harutyunyan , Alan Stern , Geoff Levand , Michal Simek , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Mathias Nyman , Bin Liu , Linux ARM , USB list , linuxppc-dev , linux-m68k List-Id: linux-arch.vger.kernel.org Hi Christoph, On Fri, Aug 16, 2019 at 8:30 AM Christoph Hellwig wrote: > We still treat devices without a DMA mask as defaulting to 32-bits for > both mask, but a few releases ago we've started warning about such > cases, as they require special cases to work around this sloppyness. > Add a dma_mask field to struct platform_device so that we can initialize > the dma_mask pointer in struct device and initialize both masks to > 32-bits by default, replacing similar functionality in m68k and > powerpc. The arch_setup_pdev_archdata hooks is now unused and removed. > > Note that the code looks a little odd with the various conditionals > because we have to support platform_device structures that are > statically allocated. > > Signed-off-by: Christoph Hellwig > --- > arch/m68k/kernel/dma.c | 9 ------- Acked-by: Geert Uytterhoeven > arch/sh/boards/mach-ecovec24/setup.c | 2 -- > arch/sh/boards/mach-migor/setup.c | 1 - Acked-by: Geert Uytterhoeven given "[PATCH 0/2] Remove calls to empty arch_setup_pdev_archdata()" https://lore.kernel.org/linux-renesas-soc/1526641611-2769-1-git-send-email-geert+renesas@glider.be/ Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-f67.google.com ([209.85.210.67]:36561 "EHLO mail-ot1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726425AbfHPHjP (ORCPT ); Fri, 16 Aug 2019 03:39:15 -0400 MIME-Version: 1.0 References: <20190816062435.881-1-hch@lst.de> <20190816062435.881-7-hch@lst.de> In-Reply-To: <20190816062435.881-7-hch@lst.de> From: Geert Uytterhoeven Date: Fri, 16 Aug 2019 09:39:03 +0200 Message-ID: Subject: Re: [PATCH 6/6] driver core: initialize a default DMA mask for platform device Content-Type: text/plain; charset="UTF-8" Sender: linux-arch-owner@vger.kernel.org List-ID: To: Christoph Hellwig Cc: Greg Kroah-Hartman , Maxime Chevallier , Gavin Li , Laurentiu Tudor , Minas Harutyunyan , Alan Stern , Geoff Levand , Michal Simek , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Mathias Nyman , Bin Liu , Linux ARM , USB list , linuxppc-dev , linux-m68k , Linux IOMMU , Linux-Arch , Linux Kernel Mailing List Message-ID: <20190816073903.Fe7bpoASLE8Mv7GbQamFMCWfDS3J6L3kCvxp0IZaXCo@z> Hi Christoph, On Fri, Aug 16, 2019 at 8:30 AM Christoph Hellwig wrote: > We still treat devices without a DMA mask as defaulting to 32-bits for > both mask, but a few releases ago we've started warning about such > cases, as they require special cases to work around this sloppyness. > Add a dma_mask field to struct platform_device so that we can initialize > the dma_mask pointer in struct device and initialize both masks to > 32-bits by default, replacing similar functionality in m68k and > powerpc. The arch_setup_pdev_archdata hooks is now unused and removed. > > Note that the code looks a little odd with the various conditionals > because we have to support platform_device structures that are > statically allocated. > > Signed-off-by: Christoph Hellwig > --- > arch/m68k/kernel/dma.c | 9 ------- Acked-by: Geert Uytterhoeven > arch/sh/boards/mach-ecovec24/setup.c | 2 -- > arch/sh/boards/mach-migor/setup.c | 1 - Acked-by: Geert Uytterhoeven given "[PATCH 0/2] Remove calls to empty arch_setup_pdev_archdata()" https://lore.kernel.org/linux-renesas-soc/1526641611-2769-1-git-send-email-geert+renesas@glider.be/ Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds