From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Michal Marek <michal.lkml@markovi.net>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
linux-arch <linux-arch@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 07/20] kbuild: scripts/install.sh: allow for the version number
Date: Wed, 7 Apr 2021 15:03:58 +0200 [thread overview]
Message-ID: <YG2tvk010wRkIVSX@kroah.com> (raw)
In-Reply-To: <CAK7LNASbZ4hY8ypd8TegnRpxQUM-HB84n2VHUmu=k_RxwCnpXg@mail.gmail.com>
On Wed, Apr 07, 2021 at 08:05:23PM +0900, Masahiro Yamada wrote:
> On Wed, Apr 7, 2021 at 2:35 PM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > Some architectures put the version number by default at the end of the
> > files that are copied, so add support for this to be set by arch type.
> >
> > Odds are one day we should change this for x86, but let's not break
> > anyone's systems just yet.
> >
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > ---
> > scripts/install.sh | 15 +++++++++++++--
> > 1 file changed, 13 insertions(+), 2 deletions(-)
> >
> > diff --git a/scripts/install.sh b/scripts/install.sh
> > index 72dc4c81013e..934619f81119 100644
> > --- a/scripts/install.sh
> > +++ b/scripts/install.sh
> > @@ -60,8 +60,19 @@ else
> > base=vmlinux
> > fi
> >
> > -install "$2" "$4"/"$base"
> > -install "$3" "$4"/System.map
> > +# Some architectures name their files based on version number, and
> > +# others do not. Call out the ones that do not to make it obvious.
> > +case "${ARCH}" in
> > + x86)
> > + version=""
> > + ;;
> > + *)
> > + version="-${1}"
> > + ;;
> > +esac
> > +
> > +install "$2" "$4"/"$base""$version"
>
>
> Too many quotes are eye sore.
>
>
> install "$2" "$4/$base$version"
>
> looks cleaner in my opinion.
>
> Shell correctly understands the end of each
> variable because a slash or a dollar
> cannot be a part of a variable name.
Good idea, I usually just default to "quote everything!" when dealing
with bash variables. I'll fix this up.
Oh, any preference for "$2" vs. "${2}"? I don't care either way but I
couldn't tell what is the normal kernel style these days.
thanks for all of the review, much appreciated!
greg k-h
next prev parent reply other threads:[~2021-04-07 13:04 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 5:33 [PATCH 00/20] kbuild: unify the install.sh script usage Greg Kroah-Hartman
2021-04-07 5:34 ` [PATCH 01/20] kbuild: move x86 install script to scripts/install.sh Greg Kroah-Hartman
2021-04-09 3:08 ` Kees Cook
2021-04-07 5:34 ` [PATCH 02/20] kbuild: scripts/install.sh: properly quote all variables Greg Kroah-Hartman
2021-04-07 10:59 ` Masahiro Yamada
2021-04-07 5:34 ` [PATCH 03/20] kbuild: scripts/install.sh: provide a "install" function Greg Kroah-Hartman
2021-04-07 11:01 ` Masahiro Yamada
2021-04-07 5:34 ` [PATCH 04/20] kbuild: scripts/install.sh: call sync before calling the bootloader installer Greg Kroah-Hartman
2021-04-07 11:03 ` Masahiro Yamada
2021-04-07 5:34 ` [PATCH 05/20] kbuild: scripts/install.sh: prepare for arch-specific bootloaders Greg Kroah-Hartman
2021-04-09 3:08 ` Kees Cook
2021-04-07 5:34 ` [PATCH 06/20] kbuild: scripts/install.sh: handle compressed/uncompressed kernel images Greg Kroah-Hartman
2021-04-07 11:04 ` Masahiro Yamada
2021-04-07 5:34 ` [PATCH 07/20] kbuild: scripts/install.sh: allow for the version number Greg Kroah-Hartman
2021-04-07 11:05 ` Masahiro Yamada
2021-04-07 13:03 ` Greg Kroah-Hartman [this message]
2021-04-07 13:21 ` Masahiro Yamada
2021-04-07 5:34 ` [PATCH 08/20] kbuild: riscv: use common install script Greg Kroah-Hartman
2021-04-09 3:09 ` Kees Cook
2021-04-07 5:34 ` [PATCH 09/20] kbuild: arm64: " Greg Kroah-Hartman
2021-04-07 14:30 ` Catalin Marinas
2021-04-09 3:08 ` Kees Cook
2021-04-09 6:37 ` Greg Kroah-Hartman
2021-04-07 5:34 ` [PATCH 10/20] kbuild: arm: " Greg Kroah-Hartman
2021-04-09 3:09 ` Kees Cook
2021-04-07 5:34 ` [PATCH 11/20] kbuild: ia64: " Greg Kroah-Hartman
2021-04-07 18:02 ` Sergei Trofimovich
2021-04-09 3:10 ` Kees Cook
2021-04-07 5:34 ` [PATCH 12/20] kbuild: m68k: " Greg Kroah-Hartman
2021-04-07 7:19 ` Geert Uytterhoeven
2021-04-09 3:10 ` Kees Cook
2021-04-07 5:34 ` [PATCH 13/20] kbuild: nds32: convert to use the common install scripts Greg Kroah-Hartman
2021-04-07 11:20 ` Masahiro Yamada
2021-04-07 5:34 ` [PATCH 14/20] kbuild: nios2: use common install script Greg Kroah-Hartman
2021-04-09 3:09 ` Kees Cook
2021-04-07 5:34 ` [PATCH 15/20] kbuild: parisc: " Greg Kroah-Hartman
2021-04-07 11:23 ` Masahiro Yamada
2021-04-14 16:30 ` Helge Deller
2021-04-14 17:51 ` Greg Kroah-Hartman
2021-04-07 5:34 ` [PATCH 16/20] kbuild: powerpc: " Greg Kroah-Hartman
2021-04-07 11:32 ` Masahiro Yamada
2021-04-07 5:34 ` [PATCH 17/20] kbuild: s390: " Greg Kroah-Hartman
2021-04-07 12:15 ` Heiko Carstens
2021-04-09 3:10 ` Kees Cook
2021-04-07 5:34 ` [PATCH 18/20] kbuild: sh: remove unused " Greg Kroah-Hartman
2021-04-09 3:09 ` Kees Cook
2021-08-24 15:22 ` Masahiro Yamada
2021-08-27 14:02 ` Greg Kroah-Hartman
2021-04-07 5:34 ` [PATCH 19/20] kbuild: sparc: use common " Greg Kroah-Hartman
2021-04-09 3:09 ` Kees Cook
2021-04-07 5:34 ` [PATCH 20/20] kbuild: scripts/install.sh: update documentation Greg Kroah-Hartman
2021-04-07 11:45 ` Masahiro Yamada
2021-04-07 7:18 ` [PATCH 00/20] kbuild: unify the install.sh script usage Geert Uytterhoeven
2021-04-07 7:46 ` Greg Kroah-Hartman
2021-04-07 8:02 ` Russell King - ARM Linux admin
2021-04-07 8:07 ` Greg Kroah-Hartman
2021-04-07 8:14 ` Russell King - ARM Linux admin
2021-04-07 8:37 ` Greg Kroah-Hartman
2021-04-07 10:53 ` Masahiro Yamada
2021-04-09 3:12 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YG2tvk010wRkIVSX@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).