From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yu-cheng Yu Subject: Re: [RFC PATCH v4 09/27] x86/mm: Change _PAGE_DIRTY to _PAGE_DIRTY_HW Date: Wed, 03 Oct 2018 09:07:52 -0700 Message-ID: References: <20180921150351.20898-1-yu-cheng.yu@intel.com> <20180921150351.20898-10-yu-cheng.yu@intel.com> <20181003133856.GA24782@bombadil.infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20181003133856.GA24782@bombadil.infradead.org> Sender: linux-kernel-owner@vger.kernel.org To: Matthew Wilcox Cc: x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Cyrill Gorcunov , Dave Hansen , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek Peter List-Id: linux-arch.vger.kernel.org On Wed, 2018-10-03 at 06:38 -0700, Matthew Wilcox wrote: > On Fri, Sep 21, 2018 at 08:03:33AM -0700, Yu-cheng Yu wrote: > > We are going to create _PAGE_DIRTY_SW for non-hardware, memory > > management purposes. Rename _PAGE_DIRTY to _PAGE_DIRTY_HW and > > _PAGE_BIT_DIRTY to _PAGE_BIT_DIRTY_HW to make these PTE dirty > > bits more clear. There are no functional changes in this > > patch. > > I would like there to be some documentation in this patchset which > explains the difference between PAGE_SOFT_DIRTY and PAGE_DIRTY_SW. I will add some comments for the difference between PAGE_SOFT_DIRTY and PAGE_DIRTY_SW. Yu-cheng From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com ([134.134.136.100]:11379 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726818AbeJCXH3 (ORCPT ); Wed, 3 Oct 2018 19:07:29 -0400 Message-ID: Subject: Re: [RFC PATCH v4 09/27] x86/mm: Change _PAGE_DIRTY to _PAGE_DIRTY_HW From: Yu-cheng Yu Date: Wed, 03 Oct 2018 09:07:52 -0700 In-Reply-To: <20181003133856.GA24782@bombadil.infradead.org> References: <20180921150351.20898-1-yu-cheng.yu@intel.com> <20180921150351.20898-10-yu-cheng.yu@intel.com> <20181003133856.GA24782@bombadil.infradead.org> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Matthew Wilcox Cc: x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Cyrill Gorcunov , Dave Hansen , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , "Ravi V. Shankar" , Vedvyas Shanbhogue Message-ID: <20181003160752.JcBYatK9X-jXnE4qaXpFq6VC9xH1_Y7V7QtQ91TkDFo@z> On Wed, 2018-10-03 at 06:38 -0700, Matthew Wilcox wrote: > On Fri, Sep 21, 2018 at 08:03:33AM -0700, Yu-cheng Yu wrote: > > We are going to create _PAGE_DIRTY_SW for non-hardware, memory > > management purposes. Rename _PAGE_DIRTY to _PAGE_DIRTY_HW and > > _PAGE_BIT_DIRTY to _PAGE_BIT_DIRTY_HW to make these PTE dirty > > bits more clear. There are no functional changes in this > > patch. > > I would like there to be some documentation in this patchset which > explains the difference between PAGE_SOFT_DIRTY and PAGE_DIRTY_SW. I will add some comments for the difference between PAGE_SOFT_DIRTY and PAGE_DIRTY_SW. Yu-cheng