From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4620FC43214 for ; Fri, 27 Aug 2021 17:47:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3178961004 for ; Fri, 27 Aug 2021 17:47:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239511AbhH0Rrv (ORCPT ); Fri, 27 Aug 2021 13:47:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239233AbhH0Rru (ORCPT ); Fri, 27 Aug 2021 13:47:50 -0400 Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B913C061796; Fri, 27 Aug 2021 10:47:01 -0700 (PDT) Received: by mail-pj1-x102a.google.com with SMTP id mq3so5025218pjb.5; Fri, 27 Aug 2021 10:47:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=i9TmDZ+esw/3ZLUDMU0ftSn23gEkgnQwCRuas4CrT3U=; b=IHtobvTQGY1nPT3/rK9A1D4px0mz9BbFo22Zema5+9nth1Iz8xRjEgbud3ecsrTACs Vi0LRfmP6pC0DYOfU30m5IkT0RTdx1CV7IJxATteIxw8CIRTVVgLMm1G9RvSeC8txy3w 3vkVe4JLgdQHuErnQrEWdxOE6rP0ErL9md4E0hh+apLDdJ7WZ48WHolfWdjVexGKS4Fg 64VkrIaGeWHwfHBR7pDlwiNy9s7exrN3vRd0AJl72z/zDyU7wj7/6rHEM1CVLs3fMsSi 383OW19VKOeS1sl5t8aORjPeFCc0nn+WtBx09yLwfzvn3x+xousu5jOLlDzZAsqMezkN xg2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=i9TmDZ+esw/3ZLUDMU0ftSn23gEkgnQwCRuas4CrT3U=; b=oE2ZQenaDRWQUJQMIVWV7feGz1IMBvbertvTqa56S+gMq31dI8/KPLINGuyjBIXXF1 vtU5cj1tpmgb9q9jKpQFPYoqWa71ejAFwIUcM06resiVPfXIBCkwMsKeSsM19nxPGQs5 1PoiSKSc1e7yrYTyq0Qjd6dlDCuvvV+3dj9QuPUwz3ZWmDiwJi5Qn0wHL+Ap6uRaNsy+ PcDaF2kdxh/RweQIRpdwiaisfIXm9gEjqD3jVwwXltN+cOf+/BYCDZZewR3zba/+s/FG PEdQ0oK4Qjr3Ffu+Yl03SXuw+5CtpQ+0t0qIR/3U0Qgqy4zoy3O0ST+SNZ7bHiZpGVEj qsQw== X-Gm-Message-State: AOAM531ncWA0IGdPr0nB2VNUxTTykBEohR6+c/ajLEY/OuGYfNEaJb+n vP6ipoko8iD9IyW7SBG164Y= X-Google-Smtp-Source: ABdhPJwCpp1CTTpUQk7qWKnIh/yFBudGLOgzTmHXJL1o6YBu8x2FX5yDDzUTnumdUgFfk3BNuYTWSw== X-Received: by 2002:a17:902:8d8a:b029:12d:3774:3630 with SMTP id v10-20020a1709028d8ab029012d37743630mr9735558plo.65.1630086421011; Fri, 27 Aug 2021 10:47:01 -0700 (PDT) Received: from ?IPv6:2404:f801:0:5:8000::50b? ([2404:f801:9000:1a:efea::50b]) by smtp.gmail.com with ESMTPSA id h13sm6970553pgh.93.2021.08.27.10.46.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Aug 2021 10:47:00 -0700 (PDT) Subject: Re: [PATCH V4 05/13] hyperv: Add Write/Read MSR registers via ghcb page To: Greg KH Cc: kys@microsoft.com, haiyangz@microsoft.com, sthemmin@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, catalin.marinas@arm.com, will@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, konrad.wilk@oracle.com, boris.ostrovsky@oracle.com, jgross@suse.com, sstabellini@kernel.org, joro@8bytes.org, davem@davemloft.net, kuba@kernel.org, jejb@linux.ibm.com, martin.petersen@oracle.com, arnd@arndb.de, hch@lst.de, m.szyprowski@samsung.com, robin.murphy@arm.com, brijesh.singh@amd.com, thomas.lendacky@amd.com, Tianyu.Lan@microsoft.com, pgonda@google.com, martin.b.radev@gmail.com, akpm@linux-foundation.org, kirill.shutemov@linux.intel.com, rppt@kernel.org, hannes@cmpxchg.org, aneesh.kumar@linux.ibm.com, krish.sadhukhan@oracle.com, saravanand@fb.com, linux-arm-kernel@lists.infradead.org, xen-devel@lists.xenproject.org, rientjes@google.com, ardb@kernel.org, michael.h.kelley@microsoft.com, iommu@lists.linux-foundation.org, linux-arch@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, netdev@vger.kernel.org, vkuznets@redhat.com, parri.andrea@gmail.com, dave.hansen@intel.com References: <20210827172114.414281-1-ltykernel@gmail.com> <20210827172114.414281-6-ltykernel@gmail.com> From: Tianyu Lan Message-ID: Date: Sat, 28 Aug 2021 01:46:44 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arch@vger.kernel.org On 8/28/2021 1:41 AM, Greg KH wrote: > On Fri, Aug 27, 2021 at 01:21:03PM -0400, Tianyu Lan wrote: >> From: Tianyu Lan >> >> Hyperv provides GHCB protocol to write Synthetic Interrupt >> Controller MSR registers in Isolation VM with AMD SEV SNP >> and these registers are emulated by hypervisor directly. >> Hyperv requires to write SINTx MSR registers twice. First >> writes MSR via GHCB page to communicate with hypervisor >> and then writes wrmsr instruction to talk with paravisor >> which runs in VMPL0. Guest OS ID MSR also needs to be set >> via GHCB page. >> >> Signed-off-by: Tianyu Lan >> --- >> Change since v1: >> * Introduce sev_es_ghcb_hv_call_simple() and share code >> between SEV and Hyper-V code. >> Change since v3: >> * Pass old_msg_type to hv_signal_eom() as parameter. >> * Use HV_REGISTER_* marcro instead of HV_X64_MSR_* >> * Add hv_isolation_type_snp() weak function. >> * Add maros to set syinc register in ARM code. >> --- >> arch/arm64/include/asm/mshyperv.h | 23 ++++++ >> arch/x86/hyperv/hv_init.c | 36 ++-------- >> arch/x86/hyperv/ivm.c | 112 ++++++++++++++++++++++++++++++ >> arch/x86/include/asm/mshyperv.h | 80 ++++++++++++++++++++- >> arch/x86/include/asm/sev.h | 3 + >> arch/x86/kernel/sev-shared.c | 63 ++++++++++------- >> drivers/hv/hv.c | 112 ++++++++++++++++++++---------- >> drivers/hv/hv_common.c | 6 ++ >> include/asm-generic/mshyperv.h | 4 +- >> 9 files changed, 345 insertions(+), 94 deletions(-) >> >> diff --git a/arch/arm64/include/asm/mshyperv.h b/arch/arm64/include/asm/mshyperv.h >> index 20070a847304..ced83297e009 100644 >> --- a/arch/arm64/include/asm/mshyperv.h >> +++ b/arch/arm64/include/asm/mshyperv.h >> @@ -41,6 +41,29 @@ static inline u64 hv_get_register(unsigned int reg) >> return hv_get_vpreg(reg); >> } >> >> +#define hv_get_simp(val) { val = hv_get_register(HV_REGISTER_SIMP); } >> +#define hv_set_simp(val) hv_set_register(HV_REGISTER_SIMP, val) >> + >> +#define hv_get_siefp(val) { val = hv_get_register(HV_REGISTER_SIEFP); } >> +#define hv_set_siefp(val) hv_set_register(HV_REGISTER_SIEFP, val) >> + >> +#define hv_get_synint_state(int_num, val) { \ >> + val = hv_get_register(HV_REGISTER_SINT0 + int_num); \ >> + } >> + >> +#define hv_set_synint_state(int_num, val) \ >> + hv_set_register(HV_REGISTER_SINT0 + int_num, val) >> + >> +#define hv_get_synic_state(val) { \ >> + val = hv_get_register(HV_REGISTER_SCONTROL); \ >> + } >> + >> +#define hv_set_synic_state(val) \ >> + hv_set_register(HV_REGISTER_SCONTROL, val) >> + >> +#define hv_signal_eom(old_msg_type) \ >> + hv_set_register(HV_REGISTER_EOM, 0) > > Please just use real inline functions and not #defines if you really > need it. > OK. Will update. Thanks.