From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: Huang Pei <huangpei@loongson.cn>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
ambrosehua@gmail.com, Bibo Mao <maobibo@loongson.cn>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mips@vger.kernel.org, linux-arch@vger.kernel.org,
linux-mm@kvack.org, Jiaxun Yang <jiaxun.yang@flygoat.com>,
Paul Burton <paulburton@kernel.org>,
Li Xuefeng <lixuefeng@loongson.cn>,
Yang Tiezhu <yangtiezhu@loongson.cn>,
Gao Juxin <gaojuxin@loongson.cn>,
Fuxin Zhang <zhangfx@lemote.com>, Huacai Chen <chenhc@lemote.com>
Subject: Re: [PATCH] MIPS: clean up CONFIG_MIPS_PGD_C0_CONTEXT handling
Date: Thu, 4 Mar 2021 02:40:54 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.21.2103040227500.19637@angie.orcam.me.uk> (raw)
In-Reply-To: <20210304010623.4tyzpzgllsdy3ssg@ambrosehua-HP-xw6600-Workstation>
On Thu, 4 Mar 2021, Huang Pei wrote:
> > > @@ -1164,8 +1165,8 @@ build_fast_tlb_refill_handler (u32 **p, struct uasm_label **l,
> > >
> > > if (pgd_reg == -1) {
> > > vmalloc_branch_delay_filled = 1;
> > > - /* 1 0 1 0 1 << 6 xkphys cached */
> > > - uasm_i_ori(p, ptr, ptr, 0x540);
> > > + /* insert bit[63:59] of CAC_BASE into bit[11:6] of ptr */
> > > + uasm_i_ori(p, ptr, ptr, (CAC_BASE >> 53));
> >
> > Instead I'd paper the issue over by casting the constant to `s64'.
> >
> > Or better yet fixed it properly by defining CAC_BASE, etc. as `unsigned
> > long long' long rather than `unsigned long' to stop all this nonsense
> > (e.g. PHYS_TO_XKPHYS already casts the result to `s64'). Thomas, WDYT?
> Sorry, I do not get it , on MIPS32, how can CAC_BASE be unsigned long
> long ?
By using the `ULL' suffix with constants. It won't change code produced,
because they are unsigned anyway and the compiler will truncate them with
no change to the actual value to fit in narrower data types as needed, but
it will silence the warnings.
Maciej
next prev parent reply other threads:[~2021-03-04 1:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-27 6:19 [PATCH V2] MIPS: clean up CONFIG_MIPS_PGD_C0_CONTEXT Huang Pei
2021-02-27 6:19 ` [PATCH] MIPS: clean up CONFIG_MIPS_PGD_C0_CONTEXT handling Huang Pei
2021-02-28 23:00 ` Maciej W. Rozycki
2021-03-04 1:06 ` Huang Pei
2021-03-04 1:40 ` Maciej W. Rozycki [this message]
2021-03-05 7:13 ` Huang Pei
2021-03-07 20:54 ` Maciej W. Rozycki
2021-03-13 1:39 [PATCH V5] MIPS: clean up MIPS_PGD_C0_CONTEXT Huang Pei
2021-03-13 1:39 ` [PATCH] MIPS: clean up CONFIG_MIPS_PGD_C0_CONTEXT handling Huang Pei
2021-03-14 13:09 ` Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2103040227500.19637@angie.orcam.me.uk \
--to=macro@orcam.me.uk \
--cc=akpm@linux-foundation.org \
--cc=ambrosehua@gmail.com \
--cc=chenhc@lemote.com \
--cc=gaojuxin@loongson.cn \
--cc=huangpei@loongson.cn \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lixuefeng@loongson.cn \
--cc=maobibo@loongson.cn \
--cc=paulburton@kernel.org \
--cc=tsbogend@alpha.franken.de \
--cc=yangtiezhu@loongson.cn \
--cc=zhangfx@lemote.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).