From: Greg Ungerer <gerg@linux-m68k.org>
To: Firoz Khan <firoz.khan@linaro.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-m68k@lists.linux-m68k.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Philippe Ombredanne <pombredanne@nexb.com>,
Thomas Gleixner <tglx@linutronix.de>,
Kate Stewart <kstewart@linuxfoundation.org>
Cc: y2038@lists.linaro.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org, arnd@arndb.de,
deepa.kernel@gmail.com, marcin.juszkiewicz@linaro.org
Subject: Re: [PATCH v2 0/5] System call table generation support
Date: Mon, 24 Sep 2018 11:08:11 +1000 [thread overview]
Message-ID: <b42ac34f-ab67-5d5c-1d6f-354af40773d8@linux-m68k.org> (raw)
In-Reply-To: <1537455973-12468-1-git-send-email-firoz.khan@linaro.org>
Hi Firoz,
On 21/09/18 01:06, Firoz Khan wrote:
> The purpose of this patch series is:
> 1. We can easily add/modify/delete system call by changing entry
> in syscall.tbl file. No need to manually edit many files.
>
> 2. It is easy to unify the system call implementation across all
> the architectures.
>
> The system call tables are in different format in all architecture
> and it will be difficult to manually add or modify the system calls
> in the respective files manually. To make it easy by keeping a script
> and which'll generate the header file and syscall table file so this
> change will unify them across all architectures.
>
> syscall.tbl contains the list of available system calls along with
> system call number and corresponding entry point. Add a new system
> call in this architecture will be possible by adding new entry in
> the syscall.tbl file.
>
> Adding a new table entry consisting of:
> - System call number.
> - ABI.
> - System call name.
> - Entry point name.
> - Compat entry name, if required.
>
> ARM, s390 and x86 architecuture does exist the similar support. I
> leverage their implementation to come up with a generic solution.
>
> I have done the same support for work for alpha, microblaze, sparc,
> mips, parisc, powerpc, sh, sparc, and xtensa. But I started sending
> the patch for one architecuture for review. Below mentioned git
> repository contains more details.
> Git repo:- https://github.com/frzkhn/system_call_table_generator/
>
> Added an extra patch to keep __IGNORE* entries in asm/unistd.h.
>
> Finally, this is the ground work for solving the Y2038 issue. We
> need to add/change two dozen of system calls to solve Y2038 issue.
> So this patch series will help to easily modify from existing
> system call to Y2038 compatible system calls.
>
> Firoz Khan (5):
> m68k: Rename system call table file name
> m68k: Replace NR_syscalls macro from asm/unistd.h
> m68k: Added system call table generation support
> m68k: uapi header and system call table file generation
> m68k: added __IGNORE* entries in asm/unistd.h
Built and tested on a couple of m68k/ColdFire targets,
m520x (no MMU) and m5475 (with MMU). Load and run on real hardware,
no problems found. So for m68knommu/ColdFire:
Tested-by: Greg Ungerer <gerg@linux-m68k.org>
Regards
Greg
> arch/m68k/Makefile | 3 +
> arch/m68k/include/asm/Kbuild | 1 +
> arch/m68k/include/asm/unistd.h | 10 +-
> arch/m68k/include/uapi/asm/Kbuild | 1 +
> arch/m68k/include/uapi/asm/unistd.h | 385 +-----------------------------
> arch/m68k/kernel/Makefile | 2 +-
> arch/m68k/kernel/syscall_table.S | 14 ++
> arch/m68k/kernel/syscalls/Makefile | 37 +++
> arch/m68k/kernel/syscalls/syscall.tbl | 369 +++++++++++++++++++++++++++++
> arch/m68k/kernel/syscalls/syscallhdr.sh | 39 ++++
> arch/m68k/kernel/syscalls/syscalltbl.sh | 28 +++
> arch/m68k/kernel/syscalltable.S | 403 --------------------------------
> 12 files changed, 502 insertions(+), 790 deletions(-)
> create mode 100644 arch/m68k/kernel/syscall_table.S
> create mode 100644 arch/m68k/kernel/syscalls/Makefile
> create mode 100644 arch/m68k/kernel/syscalls/syscall.tbl
> create mode 100644 arch/m68k/kernel/syscalls/syscallhdr.sh
> create mode 100644 arch/m68k/kernel/syscalls/syscalltbl.sh
> delete mode 100644 arch/m68k/kernel/syscalltable.S
>
next prev parent reply other threads:[~2018-09-24 1:08 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-20 15:06 [PATCH v2 0/5] System call table generation support Firoz Khan
2018-09-20 15:06 ` Firoz Khan
2018-09-20 15:06 ` [PATCH v2 1/5] m68k: Rename system call table file name Firoz Khan
2018-09-20 15:06 ` Firoz Khan
2018-09-21 5:48 ` Philippe De Muyter
2018-09-21 5:48 ` Philippe De Muyter
2018-09-22 11:36 ` Firoz Khan
2018-09-22 11:36 ` Firoz Khan
2018-09-24 7:00 ` Geert Uytterhoeven
2018-09-24 7:00 ` Geert Uytterhoeven
2018-09-20 15:06 ` [PATCH v2 2/5] m68k: Replace NR_syscalls macro from asm/unistd.h Firoz Khan
2018-09-20 15:06 ` Firoz Khan
2018-09-24 7:01 ` Geert Uytterhoeven
2018-09-24 7:01 ` Geert Uytterhoeven
2018-09-24 7:02 ` Geert Uytterhoeven
2018-09-24 7:02 ` Geert Uytterhoeven
2018-09-20 15:06 ` [PATCH v2 3/5] m68k: Added system call table generation support Firoz Khan
2018-09-20 15:06 ` Firoz Khan
2018-09-24 7:03 ` Geert Uytterhoeven
2018-09-24 7:03 ` Geert Uytterhoeven
2018-09-24 7:53 ` Firoz Khan
2018-09-24 7:53 ` Firoz Khan
2018-09-20 15:06 ` [PATCH v2 4/5] m68k: uapi header and system call table file generation Firoz Khan
2018-09-20 15:06 ` Firoz Khan
2018-09-24 7:05 ` Geert Uytterhoeven
2018-09-24 7:05 ` Geert Uytterhoeven
2018-09-24 7:55 ` Firoz Khan
2018-09-24 7:55 ` Firoz Khan
2018-09-20 15:06 ` [PATCH v2 5/5] m68k: added __IGNORE* entries in asm/unistd.h Firoz Khan
2018-09-20 15:06 ` Firoz Khan
2018-09-24 7:05 ` Geert Uytterhoeven
2018-09-24 7:05 ` Geert Uytterhoeven
2018-09-24 1:08 ` Greg Ungerer [this message]
2018-09-24 1:08 ` [PATCH v2 0/5] System call table generation support Greg Ungerer
2018-09-24 4:08 ` Firoz Khan
2018-09-24 4:08 ` Firoz Khan
2018-09-24 7:06 ` Geert Uytterhoeven
2018-09-24 7:06 ` Geert Uytterhoeven
2018-09-27 14:24 Firoz Khan
2018-09-27 14:24 ` Firoz Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b42ac34f-ab67-5d5c-1d6f-354af40773d8@linux-m68k.org \
--to=gerg@linux-m68k.org \
--cc=arnd@arndb.de \
--cc=deepa.kernel@gmail.com \
--cc=firoz.khan@linaro.org \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=marcin.juszkiewicz@linaro.org \
--cc=pombredanne@nexb.com \
--cc=tglx@linutronix.de \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).