From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anshuman Khandual Subject: Re: [PATCH V3 0/4] mm/debug_vm_pgtable: Add some more tests Date: Mon, 29 Jun 2020 14:02:31 +0530 Message-ID: References: <1592192277-8421-1-git-send-email-anshuman.khandual@arm.com> <70ddc7dd-b688-b73e-642a-6363178c8cdd@arm.com> <20200624110539.GC24934@oc3871087118.ibm.com> <20200624134808.0c460862@thinkpad> <20200624144015.GD24934@oc3871087118.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20200624144015.GD24934@oc3871087118.ibm.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane-mx.org@lists.ozlabs.org Sender: "Linuxppc-dev" To: Alexander Gordeev , Gerald Schaefer Cc: linux-doc@vger.kernel.org, Heiko Carstens , linux-mm@kvack.org, Paul Mackerras , "H. Peter Anvin" , linux-riscv@lists.infradead.org, Will Deacon , linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, Jonathan Corbet , x86@kernel.org, Mike Rapoport , Christian Borntraeger , Ingo Molnar , ziy@nvidia.com, Catalin Marinas , linux-snps-arc@lists.infradead.org, Vasily Gorbik , Borislav Petkov , Paul Walmsley , "Kirill A . Shutemov" , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, christophe.leroy@c-s.fr, Vineet Gupta , linux-kernel@vger.kernel.org, Palmer Dabbelt List-Id: linux-arch.vger.kernel.org On 06/24/2020 08:10 PM, Alexander Gordeev wrote: > On Wed, Jun 24, 2020 at 01:48:08PM +0200, Gerald Schaefer wrote: >> On Wed, 24 Jun 2020 13:05:39 +0200 >> Alexander Gordeev wrote: >> >>> On Wed, Jun 24, 2020 at 08:43:10AM +0530, Anshuman Khandual wrote: >>> >>> [...] >>> >>>> Hello Gerald/Christophe/Vineet, >>>> >>>> It would be really great if you could give this series a quick test >>>> on s390/ppc/arc platforms respectively. Thank you. >>> >>> That worked for me with the default and debug s390 configurations. >>> Would you like to try with some particular options or combinations >>> of the options? >> >> It will be enabled automatically on all archs that set >> ARCH_HAS_DEBUG_VM_PGTABLE, which we do for s390 unconditionally. >> Also, DEBUG_VM has to be set, which we have only in the debug config. >> So only the s390 debug config will have it enabled, you can check >> dmesg for "debug_vm_pgtable" to see when / where it was run, and if it >> triggered any warnings. > > Yes, that is what I did ;) > > I should have been more clear. I wonder whether Anshuman has in > mind other options which possibly makes sense to set or unset > and check how it goes with non-standard configurations. After enabling CONFIG_DEBUG_VM either explicitly or via DEBUG_VM, ideally any memory config combination on s390 which can change platform page table helpers (validated with CONFIG_DEBUG_VM) should also get tested. Recently, there was a kernel crash on ppc64 [1] and a build failure on ppc32 [2] for some particular configs. Hence it will be great if you could run this test on multiple s390 configurations. [1] 787d563b8642f35c5 ("mm/debug_vm_pgtable: fix kernel crash by checking for THP support") [2] 9449c9cb420b249eb ("mm/debug_vm_pgtable: fix build failure with powerpc 8xx") - Anshuman From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH V3 0/4] mm/debug_vm_pgtable: Add some more tests References: <1592192277-8421-1-git-send-email-anshuman.khandual@arm.com> <70ddc7dd-b688-b73e-642a-6363178c8cdd@arm.com> <20200624110539.GC24934@oc3871087118.ibm.com> <20200624134808.0c460862@thinkpad> <20200624144015.GD24934@oc3871087118.ibm.com> From: Anshuman Khandual Message-ID: Date: Mon, 29 Jun 2020 14:02:31 +0530 MIME-Version: 1.0 In-Reply-To: <20200624144015.GD24934@oc3871087118.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Alexander Gordeev , Gerald Schaefer Cc: linux-mm@kvack.org, christophe.leroy@c-s.fr, ziy@nvidia.com, Jonathan Corbet , Andrew Morton , Mike Rapoport , Vineet Gupta , Catalin Marinas , Will Deacon , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , "Kirill A . Shutemov" , Paul Walmsley , Palmer Dabbelt , linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-riscv@lists.infradead.org, x86@kernel.org, linux-doc@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Christophe Leroy List-ID: Message-ID: <20200629083231.G-_O-DZhpyY-YqxiPcGAAIP9JQ6mYk7greuyqqIpLCc@z> On 06/24/2020 08:10 PM, Alexander Gordeev wrote: > On Wed, Jun 24, 2020 at 01:48:08PM +0200, Gerald Schaefer wrote: >> On Wed, 24 Jun 2020 13:05:39 +0200 >> Alexander Gordeev wrote: >> >>> On Wed, Jun 24, 2020 at 08:43:10AM +0530, Anshuman Khandual wrote: >>> >>> [...] >>> >>>> Hello Gerald/Christophe/Vineet, >>>> >>>> It would be really great if you could give this series a quick test >>>> on s390/ppc/arc platforms respectively. Thank you. >>> >>> That worked for me with the default and debug s390 configurations. >>> Would you like to try with some particular options or combinations >>> of the options? >> >> It will be enabled automatically on all archs that set >> ARCH_HAS_DEBUG_VM_PGTABLE, which we do for s390 unconditionally. >> Also, DEBUG_VM has to be set, which we have only in the debug config. >> So only the s390 debug config will have it enabled, you can check >> dmesg for "debug_vm_pgtable" to see when / where it was run, and if it >> triggered any warnings. > > Yes, that is what I did ;) > > I should have been more clear. I wonder whether Anshuman has in > mind other options which possibly makes sense to set or unset > and check how it goes with non-standard configurations. After enabling CONFIG_DEBUG_VM either explicitly or via DEBUG_VM, ideally any memory config combination on s390 which can change platform page table helpers (validated with CONFIG_DEBUG_VM) should also get tested. Recently, there was a kernel crash on ppc64 [1] and a build failure on ppc32 [2] for some particular configs. Hence it will be great if you could run this test on multiple s390 configurations. [1] 787d563b8642f35c5 ("mm/debug_vm_pgtable: fix kernel crash by checking for THP support") [2] 9449c9cb420b249eb ("mm/debug_vm_pgtable: fix build failure with powerpc 8xx") - Anshuman