From mboxrd@z Thu Jan 1 00:00:00 1970 From: "H. Peter Anvin" Subject: Re: [PATCH 5/5] arch/xtensa, termios: use Date: Thu, 4 Oct 2018 16:08:19 -0700 Message-ID: References: <20181004222953.2229-1-hpa@zytor.com> <20181004222953.2229-6-hpa@zytor.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Max Filippov Cc: LKML , Linux-Arch , linux-serial@vger.kernel.org, Chris Zankel , Thomas Gleixner , Greg Kroah-Hartman , pombredanne@nexb.com, kstewart@linuxfoundation.org, linux-xtensa@linux-xtensa.org, Jiri Slaby List-Id: linux-arch.vger.kernel.org On 10/04/18 15:35, Max Filippov wrote: > > Looks good. But why not removing the header entirely and adding > generic-y += termbits.h > to arch/xtensa/include/uapi/asm/Kbuild? > Good idea. Should do that for others that also have the same #include. -hpa From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from terminus.zytor.com ([198.137.202.136]:52987 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725998AbeJEGER (ORCPT ); Fri, 5 Oct 2018 02:04:17 -0400 Subject: Re: [PATCH 5/5] arch/xtensa, termios: use References: <20181004222953.2229-1-hpa@zytor.com> <20181004222953.2229-6-hpa@zytor.com> From: "H. Peter Anvin" Message-ID: Date: Thu, 4 Oct 2018 16:08:19 -0700 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Max Filippov Cc: LKML , Linux-Arch , linux-serial@vger.kernel.org, Chris Zankel , Thomas Gleixner , Greg Kroah-Hartman , pombredanne@nexb.com, kstewart@linuxfoundation.org, linux-xtensa@linux-xtensa.org, Jiri Slaby Message-ID: <20181004230819.KjsBZxJKmW8mlybrKsfl84jxmOSOLD4MMkbmZWa5siE@z> On 10/04/18 15:35, Max Filippov wrote: > > Looks good. But why not removing the header entirely and adding > generic-y += termbits.h > to arch/xtensa/include/uapi/asm/Kbuild? > Good idea. Should do that for others that also have the same #include. -hpa