From: Michal Simek <michal.simek@xilinx.com>
To: Firoz Khan <firoz.khan@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Philippe Ombredanne <pombredanne@nexb.com>,
Thomas Gleixner <tglx@linutronix.de>,
Kate Stewart <kstewart@linuxfoundation.org>
Cc: y2038@lists.linaro.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org, arnd@arndb.de,
deepa.kernel@gmail.com, marcin.juszkiewicz@linaro.org
Subject: Re: [PATCH 1/3] microblaze: Replace NR_syscalls macro from asm/unistd.h
Date: Thu, 9 Aug 2018 08:48:30 +0200 [thread overview]
Message-ID: <f1e95c4d-4f02-263d-7f35-cc87bc657fbb@xilinx.com> (raw)
In-Reply-To: <1533792466-4227-2-git-send-email-firoz.khan@linaro.org>
On 9.8.2018 07:27, Firoz Khan wrote:
> __NR_syscalls macro holds the number of system call exist in this
> architecture. This macro is currently the part of asm/unistd.h file.
> We have change the value of __NR_syscalls, if we add or delete a
> system call.
>
> One of the patch in this patch series has a script which will
> generate a uapi header based on syscall.tbl file. The syscall.tbl
> file contains the number of system call information. So we have
> two option to update __NR_syscalls value.
>
> 1. Update __NR_syscalls in asm/unistd.h manually by counting the
> no.of system calls. No need to update __NR_syscalls untill
> we either add a new system call or delete an existing system
> call.
>
> 2. We can keep this feature it above mentioned script, that'll
> count the number of syscalls and keep it in a generated file.
> In this case we don't need to explicitly update __NR_syscalls
> in asm/unistd.h file.
>
> The 2nd option will be the recommended one. For that, I moved the
> NR_syscalls macro from asm/unistd.h to uapi/asm/unistd.h. The macro
> name also changed form NR_syscalls to __NR_syscalls for making the
> name convention same across all architecture. While __NR_syscalls
> isn't strictly part of the uapi, having it as part of the generated
> header to simplifies the implementation.
This macro was in unistd.h in past but it was moved out because it was
causing problem with strace.
commit 40c2702a02b755e0183b702778331b351f3be20c
Author: Michal Simek <michal.simek@xilinx.com>
AuthorDate: Mon Jul 8 09:50:24 2013 +0200
Commit: Michal Simek <michal.simek@xilinx.com>
CommitDate: Wed Jul 10 07:32:09 2013 +0200
microblaze: Move __NR_syscalls from uapi
That's why I don't think this is the right thing to do.
I have grepped strace and glibc and none is using this macro that's why
I think it shouldn't be exported via uapi.
Thanks,
Michal
next prev parent reply other threads:[~2018-08-09 6:48 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-09 5:27 [PATCH 0/3] System call table generation support Firoz Khan
2018-08-09 5:27 ` Firoz Khan
2018-08-09 5:27 ` [PATCH 1/3] microblaze: Replace NR_syscalls macro from asm/unistd.h Firoz Khan
2018-08-09 5:27 ` Firoz Khan
2018-08-09 6:48 ` Michal Simek [this message]
2018-08-09 6:48 ` Michal Simek
2018-09-18 6:37 ` Firoz Khan
2018-09-18 6:37 ` Firoz Khan
2018-10-02 7:07 ` Michal Simek
2018-10-02 7:07 ` Michal Simek
2018-10-03 5:09 ` Firoz Khan
2018-10-03 5:09 ` Firoz Khan
2018-08-09 5:27 ` [PATCH 2/3] microblaze: Added system call table generation support Firoz Khan
2018-08-09 5:27 ` Firoz Khan
2018-08-09 7:05 ` Michal Simek
2018-08-09 7:05 ` Michal Simek
2018-09-18 6:50 ` Firoz Khan
2018-09-18 6:50 ` Firoz Khan
2018-08-09 5:27 ` [PATCH 3/3] microblaze: uapi header and system call table file generation Firoz Khan
2018-08-09 5:27 ` Firoz Khan
2018-08-09 7:12 ` Michal Simek
2018-08-09 7:12 ` Michal Simek
2018-09-18 7:12 ` Firoz Khan
2018-09-18 7:12 ` Firoz Khan
2018-09-24 23:20 ` Arnd Bergmann
2018-09-24 23:20 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1e95c4d-4f02-263d-7f35-cc87bc657fbb@xilinx.com \
--to=michal.simek@xilinx.com \
--cc=arnd@arndb.de \
--cc=deepa.kernel@gmail.com \
--cc=firoz.khan@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcin.juszkiewicz@linaro.org \
--cc=pombredanne@nexb.com \
--cc=tglx@linutronix.de \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).