From mboxrd@z Thu Jan 1 00:00:00 1970 From: Igor Stoppa Subject: Re: [PATCH] asm-generic: bug: add unlikely() to BUG_ON() Date: Sat, 8 Sep 2018 07:32:15 +0300 Message-ID: References: <20180907192119.4931-1-igor.stoppa@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Arnd Bergmann Cc: igor.stoppa@huawei.com, linux-arch , Linux Kernel Mailing List List-Id: linux-arch.vger.kernel.org On 07/09/18 23:41, Arnd Bergmann wrote: > Could you add a comment about -Wmaybe-uninitialized next to the definition? > Otherwise that is easily lost. > > Also, I see that the file has two separate definitions of BUG_ON(), and the > other one does have an unlikely() in it already. Can you change both > to do the same thing with unlikely() or not unlikely()? ack -- igor From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-f68.google.com ([209.85.167.68]:44829 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726351AbeIHJQh (ORCPT ); Sat, 8 Sep 2018 05:16:37 -0400 Subject: Re: [PATCH] asm-generic: bug: add unlikely() to BUG_ON() References: <20180907192119.4931-1-igor.stoppa@huawei.com> From: Igor Stoppa Message-ID: Date: Sat, 8 Sep 2018 07:32:15 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Arnd Bergmann Cc: igor.stoppa@huawei.com, linux-arch , Linux Kernel Mailing List Message-ID: <20180908043215.uMNqCHXxEloMfg4abJR9xCuHM35eihpj79Ce7a2YpNs@z> On 07/09/18 23:41, Arnd Bergmann wrote: > Could you add a comment about -Wmaybe-uninitialized next to the definition? > Otherwise that is easily lost. > > Also, I see that the file has two separate definitions of BUG_ON(), and the > other one does have an unlikely() in it already. Can you change both > to do the same thing with unlikely() or not unlikely()? ack -- igor