From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rik van Riel Subject: Re: [RFC PATCH 1/2] mm: move tlb_table_flush to tlb_flush_mmu_free Date: Thu, 06 Sep 2018 16:29:59 -0400 Message-ID: References: <20180823084709.19717-1-npiggin@gmail.com> <20180823084709.19717-2-npiggin@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-QttmgVvdlWOXMEILqZsq" Return-path: In-Reply-To: <20180823084709.19717-2-npiggin@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Nicholas Piggin , Peter Zijlstra Cc: torvalds@linux-foundation.org, luto@kernel.org, x86@kernel.org, bp@alien8.de, will.deacon@arm.com, jannh@google.com, ascannell@google.com, dave.hansen@intel.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, David Miller , Martin Schwidefsky , Michael Ellerman , linux-arch@vger.kernel.org List-Id: linux-arch.vger.kernel.org --=-QttmgVvdlWOXMEILqZsq Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2018-08-23 at 18:47 +1000, Nicholas Piggin wrote: > There is no need to call this from tlb_flush_mmu_tlbonly, it > logically belongs with tlb_flush_mmu_free. This allows some > code consolidation with a subsequent fix. >=20 > Signed-off-by: Nicholas Piggin Reviewed-by: Rik van Riel This patch also fixes an infinite recursion bug with CONFIG_HAVE_RCU_TABLE_FREE enabled, which has this call trace: tlb_table_flush -> tlb_table_invalidate -> tlb_flush_mmu_tlbonly -> tlb_table_flush -> ... (infinite recursion) This should probably be applied sooner rather than later. --=20 All Rights Reversed. --=-QttmgVvdlWOXMEILqZsq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEKR73pCCtJ5Xj3yADznnekoTE3oMFAluRjkcACgkQznnekoTE 3oOfdAgAgn63e88Lj0I9lDDOx5WKhEfgPfWM7o5JhGZg8FxNA8lfLlgA3tFPYd4+ mYWwbBpKSf+yLLRvy4V7V4pv7b0gk7jYTvxir3iOfFcFZ0OQVKYrbr2+txZJb6Xj tosM9v5SsYMwJHGw+1cD0DQsvR/6uio0TthxchcpV4bNVvW1X8HlzFarPY32kpf8 HRU7NF/7gS2sxPQLPC/i+m4YgnuIq5xfseMOVVFp7H+uNI5BLCyrDm74zbFbtj1A HtFG9Yp4pj0KX/Bq7oiLOQ9suEtcJUI46sERyergDvFFRhTwoBGRxJ/wbKRQkxIF elqWT6jifgV0u6aRFHPPkEIuIUdTbg== =/CHW -----END PGP SIGNATURE----- --=-QttmgVvdlWOXMEILqZsq-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shelob.surriel.com ([96.67.55.147]:43984 "EHLO shelob.surriel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729826AbeIGBHS (ORCPT ); Thu, 6 Sep 2018 21:07:18 -0400 Message-ID: Subject: Re: [RFC PATCH 1/2] mm: move tlb_table_flush to tlb_flush_mmu_free From: Rik van Riel Date: Thu, 06 Sep 2018 16:29:59 -0400 In-Reply-To: <20180823084709.19717-2-npiggin@gmail.com> References: <20180823084709.19717-1-npiggin@gmail.com> <20180823084709.19717-2-npiggin@gmail.com> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-QttmgVvdlWOXMEILqZsq" Mime-Version: 1.0 Sender: linux-arch-owner@vger.kernel.org List-ID: To: Nicholas Piggin , Peter Zijlstra Cc: torvalds@linux-foundation.org, luto@kernel.org, x86@kernel.org, bp@alien8.de, will.deacon@arm.com, jannh@google.com, ascannell@google.com, dave.hansen@intel.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, David Miller , Martin Schwidefsky , Michael Ellerman , linux-arch@vger.kernel.org Message-ID: <20180906202959.fGTp6BPOokCOBqekvV1HuVpbFOjksK5MMKX2KxNDrFw@z> --=-QttmgVvdlWOXMEILqZsq Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2018-08-23 at 18:47 +1000, Nicholas Piggin wrote: > There is no need to call this from tlb_flush_mmu_tlbonly, it > logically belongs with tlb_flush_mmu_free. This allows some > code consolidation with a subsequent fix. >=20 > Signed-off-by: Nicholas Piggin Reviewed-by: Rik van Riel This patch also fixes an infinite recursion bug with CONFIG_HAVE_RCU_TABLE_FREE enabled, which has this call trace: tlb_table_flush -> tlb_table_invalidate -> tlb_flush_mmu_tlbonly -> tlb_table_flush -> ... (infinite recursion) This should probably be applied sooner rather than later. --=20 All Rights Reversed. --=-QttmgVvdlWOXMEILqZsq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEKR73pCCtJ5Xj3yADznnekoTE3oMFAluRjkcACgkQznnekoTE 3oOfdAgAgn63e88Lj0I9lDDOx5WKhEfgPfWM7o5JhGZg8FxNA8lfLlgA3tFPYd4+ mYWwbBpKSf+yLLRvy4V7V4pv7b0gk7jYTvxir3iOfFcFZ0OQVKYrbr2+txZJb6Xj tosM9v5SsYMwJHGw+1cD0DQsvR/6uio0TthxchcpV4bNVvW1X8HlzFarPY32kpf8 HRU7NF/7gS2sxPQLPC/i+m4YgnuIq5xfseMOVVFp7H+uNI5BLCyrDm74zbFbtj1A HtFG9Yp4pj0KX/Bq7oiLOQ9suEtcJUI46sERyergDvFFRhTwoBGRxJ/wbKRQkxIF elqWT6jifgV0u6aRFHPPkEIuIUdTbg== =/CHW -----END PGP SIGNATURE----- --=-QttmgVvdlWOXMEILqZsq--