From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31573C433E0 for ; Thu, 18 Mar 2021 00:12:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C7C2864F0F for ; Thu, 18 Mar 2021 00:12:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229613AbhCRAMK (ORCPT ); Wed, 17 Mar 2021 20:12:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39736 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229472AbhCRAMC (ORCPT ); Wed, 17 Mar 2021 20:12:02 -0400 Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51246C06174A for ; Wed, 17 Mar 2021 17:12:02 -0700 (PDT) Received: by mail-pl1-x629.google.com with SMTP id f17so378170plr.0 for ; Wed, 17 Mar 2021 17:12:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:message-id:from:to:cc:subject:in-reply-to:references :user-agent:mime-version; bh=ARvDJg+f6KP0knSLM+0QM9LQhlux7lyg3t/bKTXqOAA=; b=bW0Fc8FdT9RlYB4WgCYm6n59pqG92Dz/CzkJRZfaFnb2ODLWkexV/usC5R8g3eXi47 rUeEbpfluU86PeuYbuiCj55575caFTXfH7+HiitKUPNw8KdUAYFfezuoBYckCSlCJfLt 7OLlTc670gqAeifyUiYtqHH7ppf0BUecx9MaenOkjgJ632iC5EeNTnD5Y0Ryc1icWgFi I4aSv6qlq3X6ehlOGRrxoBrw3oFSOQvRSmk34jMQQv2yQbdm2bMnPGduEk8l8qRWswbx SjF1Dk81/XhyGlHRLS4uDWz6x7+IjJKAZWchrN7hlrEbw1p86ct6GM4FK844dhp4fMIX RCBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:from:to:cc:subject:in-reply-to :references:user-agent:mime-version; bh=ARvDJg+f6KP0knSLM+0QM9LQhlux7lyg3t/bKTXqOAA=; b=sQvJYEL8O1RmBERT5SBMvGhAW+fFtP3v71u9GfYFO/sb/EcqEmtEpVQVWw4nFCcDvE GSO1hF4lpzaG69s5cMx7nm++XtROPq21CKT5peHWAAa9WqGXF8k/bgC461ZobMZAAtcd B+BBI+MVY7UfGz5CI43eC18dmv+JomtkfBV7uk7q5zBMe+n4H7bwBo3E/N9lOFJ2ILlI 95FCsXOKPN4SweK8lUcwciw5b4A7nmNp5v3BC3COdU8R8+LuvmBVxADoBv3CSWtM9Xeh U8VnMQEdHuSPbLFLb21LXCcDZZ5yLDyM650TzT4uu2YYvzzvkeYB2Vha4SIHevtsJ6xz rObg== X-Gm-Message-State: AOAM531J4hrhh4GH2/RbXjCS0pYl0lkwK0j1/v8+9LuZRnyYabSrRuCN l32sYrjUMROiAZYGv2fM7TM= X-Google-Smtp-Source: ABdhPJwcJupsleIwJWVFDTZ5UXXlXU71Xo+g/kNuAF65NZsdstzUmv+iyuU4iq2dbH2ejUbbVr6Oiw== X-Received: by 2002:a17:90a:d58a:: with SMTP id v10mr1415687pju.36.1616026321515; Wed, 17 Mar 2021 17:12:01 -0700 (PDT) Received: from sun.local.gmail.com (219x123x138x129.ap219.ftth.ucom.ne.jp. [219.123.138.129]) by smtp.gmail.com with ESMTPSA id d5sm210228pjo.12.2021.03.17.17.11.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Mar 2021 17:12:00 -0700 (PDT) Date: Thu, 18 Mar 2021 09:12:05 +0900 Message-ID: From: Hajime Tazaki To: johannes@sipsolutions.net Cc: linux-um@lists.infradead.org, jdike@addtoit.com, richard@nod.at, anton.ivanov@cambridgegreys.com, tavi.purdila@gmail.com, linux-kernel-library@freelists.org, linux-arch@vger.kernel.org, retrage01@gmail.com Subject: Re: [RFC v8 08/20] um: lkl: memory handling In-Reply-To: <87933c0d6c07745b20f6724721e3bf2da8f67f72.camel@sipsolutions.net> References: <19d4990f2ef77ad595248183071da5e43149931c.1611103406.git.thehajime@gmail.com> <03c74a353c87994b61450ba8086f1ccda40b2ea8.camel@sipsolutions.net> <87933c0d6c07745b20f6724721e3bf2da8f67f72.camel@sipsolutions.net> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.1 Mule/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-arch@vger.kernel.org Hello, On Wed, 17 Mar 2021 06:31:03 +0900, Johannes Berg wrote: > > On Tue, 2021-03-16 at 10:18 +0900, Hajime Tazaki wrote: > > > > > > +void *uml_kmalloc(int size, int flags) > > > > +{ > > > > + return kmalloc(size, flags); > > > > +} > > > > > > That could probably still be shared? > > > > This function is a stub of arch/um/kernel/mem.c, which LKL doesn't > > use for the build. Thus we defined here. > > > > Or are you suggesting to not stubbing this function, but extracting > > the function from mem.c ? > > Yes, that's kind of what I was thinking. Okay, I'll look for a fix with this approach. > OTOH, I guess it's in os-Linux today? sorry, I didn't get this line. uml_kmalloc() is in kernel/mem.c but what is in os-Linux ? Thanks, -- Hajime