From: "Alim Akhtar" <alim.akhtar@samsung.com>
To: "'Christoph Hellwig'" <hch@infradead.org>
Cc: robh@kernel.org, linux-samsung-soc@vger.kernel.org,
linux-scsi@vger.kernel.org, martin.petersen@oracle.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
krzk@kernel.org, kwmad.kim@samsung.com, avri.altman@wdc.com,
cang@codeaurora.org, stanley.chu@mediatek.com,
linux-arm-kernel@lists.infradead.org
Subject: RE: [PATCH v6 04/10] scsi: ufs: introduce UFSHCD_QUIRK_PRDT_BYTE_GRAN quirk
Date: Sun, 26 Apr 2020 21:26:08 +0530 [thread overview]
Message-ID: <000101d61be3$362e79f0$a28b6dd0$@samsung.com> (raw)
In-Reply-To: <20200422065414.GK20318@infradead.org>
Hi Christoph,
> -----Original Message-----
> From: Christoph Hellwig <hch@infradead.org>
> Sent: 22 April 2020 12:24
> To: Alim Akhtar <alim.akhtar@samsung.com>
> Cc: robh@kernel.org; devicetree@vger.kernel.org;
linux-scsi@vger.kernel.org;
> krzk@kernel.org; avri.altman@wdc.com; martin.petersen@oracle.com;
> kwmad.kim@samsung.com; stanley.chu@mediatek.com;
> cang@codeaurora.org; linux-samsung-soc@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v6 04/10] scsi: ufs: introduce
> UFSHCD_QUIRK_PRDT_BYTE_GRAN quirk
>
> On Fri, Apr 17, 2020 at 11:29:38PM +0530, Alim Akhtar wrote:
> > Some UFS host controllers may think granularities of PRDT length and
> > offset as bytes, not double words.
> >
> > Signed-off-by: Kiwoong Kim <kwmad.kim@samsung.com>
> > Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
> > ---
> > drivers/scsi/ufs/ufshcd.c | 30 +++++++++++++++++++++++-------
> > drivers/scsi/ufs/ufshcd.h | 6 ++++++
> > 2 files changed, 29 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> > index ee30ed6cc805..b32fcedcdcb9 100644
> > --- a/drivers/scsi/ufs/ufshcd.c
> > +++ b/drivers/scsi/ufs/ufshcd.c
> > @@ -2151,8 +2151,14 @@ static int ufshcd_map_sg(struct ufs_hba *hba,
> struct ufshcd_lrb *lrbp)
> > return sg_segments;
> >
> > if (sg_segments) {
> > - lrbp->utr_descriptor_ptr->prd_table_length =
> > - cpu_to_le16((u16)sg_segments);
> > +
> > + if (hba->quirks & UFSHCD_QUIRK_PRDT_BYTE_GRAN)
> > + lrbp->utr_descriptor_ptr->prd_table_length =
> > + cpu_to_le16((u16)(sg_segments *
> > + sizeof(struct ufshcd_sg_entry)));
> > + else
> > + lrbp->utr_descriptor_ptr->prd_table_length =
> > + cpu_to_le16((u16) (sg_segments));
>
> No double words here. "Normal" UFS uses the actual segment count, while
> Samsumg uses bytes. Also no need fo the u16 count in either the old or
new
> version.
Ok, will update the commit message and take your suggestion in the next
version.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-04-26 15:56 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200417181006epcas5p269f8c4b94e60962a0b0318ef64a65364@epcas5p2.samsung.com>
2020-04-17 17:59 ` [PATCH v6 0/10] exynos-ufs: Add support for UFS HCI Alim Akhtar
[not found] ` <CGME20200417181008epcas5p460840c01c2c09ce1a69e83005b4bddbe@epcas5p4.samsung.com>
2020-04-17 17:59 ` [PATCH v6 01/10] scsi: ufs: add quirk to fix mishandling utrlclr/utmrlclr Alim Akhtar
2020-04-20 6:55 ` Avri Altman
2020-04-21 5:52 ` Can Guo
[not found] ` <CGME20200417181010epcas5p23cb018eee5b7ae0eba87d81dbaaec3ce@epcas5p2.samsung.com>
2020-04-17 17:59 ` [PATCH v6 02/10] scsi: ufs: add quirk to disallow reset of interrupt aggregation Alim Akhtar
2020-04-20 7:05 ` Avri Altman
[not found] ` <CGME20200417181012epcas5p2004ac8f0d793abd4d58c096ff490da68@epcas5p2.samsung.com>
2020-04-17 17:59 ` [PATCH v6 03/10] scsi: ufs: add quirk to enable host controller without hce Alim Akhtar
2020-04-20 7:14 ` Avri Altman
2020-04-21 5:59 ` Can Guo
2020-04-21 6:00 ` Can Guo
[not found] ` <CGME20200417181014epcas5p1343bc81fb246133cc332d3fc7a394c15@epcas5p1.samsung.com>
2020-04-17 17:59 ` [PATCH v6 04/10] scsi: ufs: introduce UFSHCD_QUIRK_PRDT_BYTE_GRAN quirk Alim Akhtar
2020-04-20 8:13 ` Avri Altman
2020-04-22 6:54 ` Christoph Hellwig
2020-04-26 15:56 ` Alim Akhtar [this message]
[not found] ` <CGME20200417181016epcas5p2ee7ac86d743ceee9076690dc5b1e2f08@epcas5p2.samsung.com>
2020-04-17 17:59 ` [PATCH v6 05/10] scsi: ufs: add quirk to fix abnormal ocs fatal error Alim Akhtar
2020-04-20 8:55 ` Avri Altman
2020-04-21 7:46 ` Kiwoong Kim
2020-04-21 7:51 ` Kiwoong Kim
2020-04-21 12:07 ` Avri Altman
2020-04-26 15:54 ` Alim Akhtar
2020-04-22 6:55 ` Christoph Hellwig
2020-04-26 15:57 ` Alim Akhtar
[not found] ` <CGME20200417181018epcas5p1e51c7ca0fe81df16554548df5b82e3e4@epcas5p1.samsung.com>
2020-04-17 17:59 ` [PATCH v6 06/10] dt-bindings: phy: Document Samsung UFS PHY bindings Alim Akhtar
2020-04-21 16:55 ` Alim Akhtar
[not found] ` <CGME20200417181020epcas5p2121f17c89634d6ad8f30258339a6b249@epcas5p2.samsung.com>
2020-04-17 17:59 ` [PATCH v6 07/10] phy: samsung-ufs: add UFS PHY driver for samsung SoC Alim Akhtar
[not found] ` <CGME20200417181022epcas5p1f83138da6e76ff0917de88e913ef8e32@epcas5p1.samsung.com>
2020-04-17 17:59 ` [PATCH v6 08/10] dt-bindings: ufs: Add DT binding documentation for ufs Alim Akhtar
2020-04-21 16:56 ` Alim Akhtar
[not found] ` <CGME20200417181024epcas5p4231ae3dd2598155854e9b7ee52438bcb@epcas5p4.samsung.com>
2020-04-17 17:59 ` [PATCH v6 09/10] scsi: ufs-exynos: add UFS host support for Exynos SoCs Alim Akhtar
2020-04-17 18:20 ` Randy Dunlap
2020-04-20 10:26 ` Avri Altman
2020-04-21 0:59 ` Alim Akhtar
[not found] ` <CGME20200417181026epcas5p434bcc980e1fe334969ef6f1641525ee0@epcas5p4.samsung.com>
2020-04-17 17:59 ` [PATCH v6 10/10] arm64: dts: Add node for ufs exynos7 Alim Akhtar
2020-04-18 12:38 ` [PATCH v6 0/10] exynos-ufs: Add support for UFS HCI Avri Altman
2020-04-18 13:08 ` Alim Akhtar
2020-04-18 16:00 ` Avri Altman
2020-04-18 16:04 ` Avri Altman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000101d61be3$362e79f0$a28b6dd0$@samsung.com' \
--to=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=cang@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=hch@infradead.org \
--cc=krzk@kernel.org \
--cc=kwmad.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=robh@kernel.org \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).