From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29663C2D0E7 for ; Sun, 29 Mar 2020 11:08:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CCDA620675 for ; Sun, 29 Mar 2020 11:08:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qGFOrsCh"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="bqRTSIBd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CCDA620675 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject: In-Reply-To:References:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=L75fM/HWG+ZZOJ9L/pT3jRhzVvOvVfHUXUhvrTm7ypk=; b=qGFOrsChitb2Ah HgIwt+Bh2G2KOa6Ir/WLcazk+yP5JnkJC4+xoojeTkO4FjO445yVtjRVL1WknUDmXENHtQiIHJhOJ wCSrJHdBQBW7ELcbB+baJeJUCEHAqSnnNctrZOMAo4JhoXoJ0W7TTOzSAl23V5abiHu+g4Tydzl8x spPRjPRA+IC8ry6l4C0R5800II4sTAv5kgGDO6dWoOSs/UlYJ61qtXoT9shMTUi1kyX0IYP8jcttU 8+ia05AMun3YfNRpXZUDLwLYFc8zxsDgzrigEUPxP4LmHFNDFQqdWyInVwsx5eSN0qheLX3rmBzrt 0aauWCiCT0Y2H3ZUB5cw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jIVnY-0002xv-Lz; Sun, 29 Mar 2020 11:08:12 +0000 Received: from mail26.static.mailgun.info ([104.130.122.26]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jIVnS-0002xN-FK for linux-arm-kernel@lists.infradead.org; Sun, 29 Mar 2020 11:08:10 +0000 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1585480089; h=Content-Transfer-Encoding: Content-Type: MIME-Version: Message-ID: Date: Subject: In-Reply-To: References: Cc: To: From: Sender; bh=hbFsvwoybyQrzSjd5fOsfde02T95Q4Rlx3aKtpKf5b8=; b=bqRTSIBdzjshImcPwTCsWWDsB90GAfdX4qlDbWicmGUw1TFjO60Jtl0T3WN+G56txR4VokUh iS5CB55jF0Bn+jL0aPD00CsejvnBpOtVqMRmyjyQOLcjuoEEhygx8ClyGpqpuMI/yAOIOlcK pXryOjqP24F6C7Q1fzo1pSbnh6c= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyJiYzAxZiIsICJsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e808174.7fa6f761a6f8-smtp-out-n04; Sun, 29 Mar 2020 11:07:32 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 284E6C43636; Sun, 29 Mar 2020 11:07:31 +0000 (UTC) Received: from Pillair (unknown [183.83.66.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: pillair) by smtp.codeaurora.org (Postfix) with ESMTPSA id 7AE87C433D2; Sun, 29 Mar 2020 11:07:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 7AE87C433D2 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=pillair@codeaurora.org From: To: "'Bjorn Andersson'" References: <1585219723-28323-1-git-send-email-pillair@codeaurora.org> <20200327230025.GJ5063@builder> <000101d604f8$afc48220$0f4d8660$@codeaurora.org> <20200328183055.GA663905@yoga> In-Reply-To: <20200328183055.GA663905@yoga> Subject: RE: [PATCH v7] arm64: dts: qcom: sc7180: Add WCN3990 WLAN module device node Date: Sun, 29 Mar 2020 16:37:25 +0530 Message-ID: <000301d605ba$3d034a10$b709de30$@codeaurora.org> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQFGsu5WNDBp+FP/TOeyoiVSrY11cwGGydAyAh9ckM8BjsJxYqlUZtlw Content-Language: en-us X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200329_040809_144273_DD74AAF0 X-CRM114-Status: GOOD ( 26.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Bjorn, > -----Original Message----- > From: Bjorn Andersson > Sent: Sunday, March 29, 2020 12:01 AM > To: pillair@codeaurora.org > Cc: devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > kernel@vger.kernel.org; linux-arm-msm@vger.kernel.org > Subject: Re: [PATCH v7] arm64: dts: qcom: sc7180: Add WCN3990 WLAN > module device node > > On Sat 28 Mar 05:01 PDT 2020, pillair@codeaurora.org wrote: > > > Hi Bjorn, > > Comments inline. > > > > > > > -----Original Message----- > > > From: Bjorn Andersson > > > Sent: Saturday, March 28, 2020 4:30 AM > > > To: Rakesh Pillai > > > Cc: devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > > linux- > > > kernel@vger.kernel.org; linux-arm-msm@vger.kernel.org > > > Subject: Re: [PATCH v7] arm64: dts: qcom: sc7180: Add WCN3990 WLAN > > > module device node > > > > > > On Thu 26 Mar 03:48 PDT 2020, Rakesh Pillai wrote: > > > > > > > Add device node for the ath10k SNOC platform driver probe > > > > and add resources required for WCN3990 on sc7180 soc. > > > > > > > > Signed-off-by: Rakesh Pillai > > > > --- > > > > > > > > Depends on https://patchwork.kernel.org/patch/11455345/ > > > > The above patch adds the dt-bindings for wifi-firmware > > > > subnode > > > > --- > > > > arch/arm64/boot/dts/qcom/sc7180-idp.dts | 8 ++++++++ > > > > arch/arm64/boot/dts/qcom/sc7180.dtsi | 27 > > > +++++++++++++++++++++++++++ > > > > 2 files changed, 35 insertions(+) > > > > > > > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts > > > b/arch/arm64/boot/dts/qcom/sc7180-idp.dts > > > > index 043c9b9..a6168a4 100644 > > > > --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts > > > > +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts > > > > @@ -327,6 +327,14 @@ > > > > }; > > > > }; > > > > > > > > +&wifi { > > > > + status = "okay"; > > > > + qcom,msa-fixed-perm; > > > > + wifi-firmware { > > > > + iommus = <&apps_smmu 0xc2 0x1>; > > > > > > How is sc7180 different from sdm845, where the iommus property goes > > > directly in the &wifi node? > > > > Sc7180 IDP is a target without TrustZone support and also with S2 IOMMU > > enabled. > > Since in Trustzone based targets, the iommu SID configuration was done by > > TZ, there was nothing required to be done by driver. > > But in non-TZ based targets, the IOMMU mappings need to be done by the > > driver. > > Since this is the mapping of the firmware memory and to keep it different > > from the driver memory access, a different device has been created for > > firmware and these SIDs are configured. > > > > I see, I missed the fact that 0xc0:1 is used in the &wifi node itself. > > So to confirm, we have streams 0xc0 and 0xc1 for data pipes and 0xc2 and > 0xc3 for some form of firmware access? And in the normal Qualcomm design > implementation the 0c2/0xc3 stream mapping is setup by TZ, and hidden > from Linux using the SMMU virtualisation? > > > Would have been nice to have some better mechanism for describing > multi-connected hardware block, than to sprinkle dummy nodes all over > the DT... Yes, this is the firmware memory. This method is followed in the venus video driver https://patchwork.kernel.org/patch/11315765/ Do you suggest following some other mechanism ? Thanks, Rakesh Pillai. > > Regards, > Bjorn > > > The below ath10k series brings-in this support. > > https://patchwork.kernel.org/project/linux- > wireless/list/?series=261367&stat > > e=* > > > > Thanks, > > Rakesh Pillai. > > > > > > > > Regards, > > > Bjorn > > > > > > > + }; > > > > +}; > > > > + > > > > /* PINCTRL - additions to nodes defined in sc7180.dtsi */ > > > > > > > > &qspi_clk { > > > > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi > > > b/arch/arm64/boot/dts/qcom/sc7180.dtsi > > > > index 998f101..2745128 100644 > > > > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > > > > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > > > > @@ -83,6 +83,11 @@ > > > > reg = <0 0x8f600000 0 0x500000>; > > > > no-map; > > > > }; > > > > + > > > > + wlan_fw_mem: memory@94104000 { > > > > + reg = <0 0x94104000 0 0x200000>; > > > > + no-map; > > > > + }; > > > > }; > > > > > > > > cpus { > > > > @@ -835,6 +840,28 @@ > > > > }; > > > > }; > > > > > > > > + wifi: wifi@18800000 { > > > > + compatible = "qcom,wcn3990-wifi"; > > > > + reg = <0 0x18800000 0 0x800000>; > > > > + reg-names = "membase"; > > > > + iommus = <&apps_smmu 0xc0 0x1>; > > > > + interrupts = > > > > + > > */ >, > > > > + > > */ >, > > > > + > > */ >, > > > > + > > */ >, > > > > + > > */ >, > > > > + > > */ >, > > > > + > > */ >, > > > > + > > */ >, > > > > + > > */ >, > > > > + > > */ >, > > > > + > > */>, > > > > + > > */>; > > > > + memory-region = <&wlan_fw_mem>; > > > > + status = "disabled"; > > > > + }; > > > > + > > > > config_noc: interconnect@1500000 { > > > > compatible = "qcom,sc7180-config-noc"; > > > > reg = <0 0x01500000 0 0x28000>; > > > > -- > > > > 2.7.4 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel