AW: [Patch] support for new board

[<claudio@databyte.ch>]

Hi Andrew

Thank you very much for your suggestions and your answer. 
I'm very sorry for the missing signed-off line. 
I will add they as soon as I have made corrections to the patch as proposed
by you. 

One questions about defconfig. 
You wrote, that defconfigs have not been added since years. 
So what would be the right way today?

Thanks
Regards
Claudio

-----Ursprüngliche Nachricht-----
Von: Andrew Lunn <andrew@lunn.ch> 
Gesendet: Montag, 24. Juni 2019 19:12
An: claudio@databyte.ch
Cc: linux-arm-kernel@lists.infradead.org; shawnguo@kernel.org;
s.hauer@pengutronix.de; festevam@gmail.com; linux-imx@nxp.com;
kernel@pengutronix.de
Betreff: Re: [Patch] support for new board

On Mon, Jun 24, 2019 at 01:11:20PM +0200, claudio@databyte.ch wrote:
> Hi there
> 
> I would like to add support for a new board. 
> Below is the Patch. 

Hi Claudio

Please take a read of

https://www.kernel.org/doc/html/latest/process/submitting-patches.html

Your email has the wrong format. You a missing a Signed-off-by, etc.

> ---------------------------------------
> 
> >From 84ee8bc7b927ca9f88870a6a2f73906bb9492698 Mon Sep 17 00:00:00 
> >2001
> From: Claudio Hediger <claudio@databyte.ch>
> Date: Mon, 24 Jun 2019 12:39:51 +0200
> Subject: [PATCH] added eval1a board
> 
> ---
>  arch/arm/boot/dts/Makefile               |   4 +-
>  arch/arm/boot/dts/imx6ull-dtb-eval1a.dts | 168 +++++++++++++++
>  arch/arm/configs/eval1a_defconfig        | 259 +++++++++++++++++++++++
>  3 files changed, 430 insertions(+), 1 deletion(-)  create mode 100644 
> arch/arm/boot/dts/imx6ull-dtb-eval1a.dts
>  create mode 100644 arch/arm/configs/eval1a_defconfig
> 
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile 
> index dab2914fa293..5561881358ba 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -580,7 +580,9 @@ dtb-$(CONFIG_SOC_IMX6UL) += \
>  	imx6ull-14x14-evk.dtb \
>  	imx6ull-colibri-eval-v3.dtb \
>  	imx6ull-colibri-wifi-eval-v3.dtb \
> -	imx6ulz-14x14-evk.dtb
> +	imx6ulz-14x14-evk.dtb \
> +        imx6ull-dtb-eval1a.dtb

These files are listed in alphabetical order.  There is also a space/tab
problem.  The -dtb- also looks a bit odd. I can see it getting mixed up with
Device Tree Binary. Maybe -databyte- would be better?

> +	
>  dtb-$(CONFIG_SOC_IMX7D) += \
>  	imx7d-cl-som-imx7.dtb \
>  	imx7d-colibri-emmc-eval-v3.dtb \
> diff --git a/arch/arm/boot/dts/imx6ull-dtb-eval1a.dts
> b/arch/arm/boot/dts/imx6ull-dtb-eval1a.dts
> new file mode 100644
> index 000000000000..e549ef90816f
> --- /dev/null
> +++ b/arch/arm/boot/dts/imx6ull-dtb-eval1a.dts
> @@ -0,0 +1,168 @@
> +/*
> + *
> + * This program is free software; you can redistribute it and/or 
> +modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + */

Please add an SPDX line, and skip this text.

> +
> +/dts-v1/;
> +
> +#include "imx6ull.dtsi"
> +
> +/ {
> +	model = "Databyte imx6 Evalboard 1A";
> +	compatible = "databyte,eval1a", "fsl,imx6ull";

databyte needs adding to
Documentation/devicetree/bindings/vendor-prefixes.yaml 

> +&fec1 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_enet1>;
> +	phy-mode = "rmii";
> +	phy-handle = <&ethphy0>;
> +	status = "okay";
> +
> +	mdio {
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		ethphy0: ethernet-phy@2 {
> +			compatible = "ethernet-phy-ieee802.3-c22";

This compatible is not required.

> +			reg = <2>;
> +		};
> +	};
> +};
> +
> +
> +
> +&iomuxc {
> +	pinctrl-names = "default";
> +	//pinctrl-0 = <&pinctrl_hog_1>;

Please avoid commented out code.

> +	eval1a {
> +
> +		pinctrl_enet1: enet1grp {
> +			fsl,pins = <
> +				MX6UL_PAD_ENET1_RX_EN__ENET1_RX_EN
> 0x1b0b0
> +				MX6UL_PAD_ENET1_RX_ER__ENET1_RX_ER
> 0x1b0b0

It looks like your mailer has corrupted this patch. Try using 'git
send-email'

> diff --git a/arch/arm/configs/eval1a_defconfig
> b/arch/arm/configs/eval1a_defconfig

defconfig's have not been added for years.

	    Andrew


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel