From: Matthias Brugger <matthias.bgg@gmail.com>
To: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
Rob Herring <robh+dt@kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com
Cc: devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: bcm283x: Add cells encoding format to firmware bus
Date: Fri, 27 Mar 2020 17:15:53 +0100 [thread overview]
Message-ID: <015ad553-86a2-c6ac-e515-f14df83cec26@gmail.com> (raw)
In-Reply-To: <20200326134413.12298-1-nsaenzjulienne@suse.de>
On 26/03/2020 14:44, Nicolas Saenz Julienne wrote:
> With the introduction of 55c7c0621078 ("ARM: dts: bcm283x: Fix vc4's
> firmware bus DMA limitations") the firmware bus has to comply with
> /soc's DMA limitations. Ultimately linking both buses to a same
> dma-ranges property. The patch (and author) missed the fact that a bus'
> #address-cells and #size-cells properties are not inherited, but set to
> a fixed value which, in this case, doesn't match /soc's. This, although
> not breaking Linux's DMA mapping functionality, generates ugly dtc
> warnings.
>
> Fix the issue by adding the correct address and size cells properties
> under the firmware bus.
>
> Fixes: 55c7c0621078 ("ARM: dts: bcm283x: Fix vc4's firmware bus DMA limitations")
> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Reviewed-by: Matthias Brugger <mbrugger@suse.com>
> ---
> arch/arm/boot/dts/bcm2835-rpi.dtsi | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm/boot/dts/bcm2835-rpi.dtsi b/arch/arm/boot/dts/bcm2835-rpi.dtsi
> index fd2c766e0f71..f7ae5a4530b8 100644
> --- a/arch/arm/boot/dts/bcm2835-rpi.dtsi
> +++ b/arch/arm/boot/dts/bcm2835-rpi.dtsi
> @@ -14,6 +14,9 @@ act {
> soc {
> firmware: firmware {
> compatible = "raspberrypi,bcm2835-firmware", "simple-bus";
> + #address-cells = <1>;
> + #size-cells = <1>;
> +
> mboxes = <&mailbox>;
> dma-ranges;
> };
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-03-27 16:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 13:44 [PATCH] ARM: dts: bcm283x: Add cells encoding format to firmware bus Nicolas Saenz Julienne
2020-03-27 16:15 ` Matthias Brugger [this message]
2020-03-27 16:17 ` Florian Fainelli
2020-03-27 16:48 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=015ad553-86a2-c6ac-e515-f14df83cec26@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=nsaenzjulienne@suse.de \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).