From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD93EC433E0 for ; Thu, 28 Jan 2021 01:31:54 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7A67664DDA for ; Thu, 28 Jan 2021 01:31:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7A67664DDA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe :List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From:References:To:Subject: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fdq4FPuYkTS85V8H8gcn2rZUJQP1oIQ7Sov4r9F94jo=; b=Afkr4lnxKv+5EPC6qEMNghVyv5 852gMCwQFK1w7aLWISIL42Fg1IeEfS2rdMEhzjK73Rev/gPE+xoA8dnkT5yVEejBuzwT2RfQS4Jgz 0Y5UOGsMUuT75QcLe50ZNRma8KHnKVtUK2MiXiP5pU5d6rInD2YYBQjjYUMXuove0VRrCeWUda+zv xci1xvjLjP9ayxGgwglh6Q8ERO/TMfpCdNotwq+kSEln4snIz9tIVPoDB+DA5iNoMgSpC0qLqP1yS fpWEJlp0R4BxjZlApNNAAZo7r+Ug3WqN+niBRvmNLX4NyDBaVnv2lJLZex4qgufp9/PX9PAx+kKMP esmSIepA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l4w8y-0006d1-20; Thu, 28 Jan 2021 01:30:44 +0000 Received: from szxga05-in.huawei.com ([45.249.212.191]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l4w8u-0006by-Kh for linux-arm-kernel@lists.infradead.org; Thu, 28 Jan 2021 01:30:42 +0000 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4DR2tz28RSzjFLZ; Thu, 28 Jan 2021 09:29:15 +0800 (CST) Received: from [127.0.0.1] (10.174.176.220) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.498.0; Thu, 28 Jan 2021 09:30:18 +0800 Subject: Re: [PATCH v5 0/4] ARM: Add support for Hisilicon Kunpeng L3 cache controller To: Russell King , Greg Kroah-Hartman , Will Deacon , "Haojian Zhuang" , Arnd Bergmann , Rob Herring , Wei Xu , devicetree , linux-arm-kernel , linux-kernel References: <20210116032740.873-1-thunder.leizhen@huawei.com> From: "Leizhen (ThunderTown)" Message-ID: <036c026a-f6ec-e029-95b4-e715c93f2c21@huawei.com> Date: Thu, 28 Jan 2021 09:30:17 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20210116032740.873-1-thunder.leizhen@huawei.com> Content-Language: en-US X-Originating-IP: [10.174.176.220] X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210127_203041_206163_E1B79960 X-CRM114-Status: GOOD ( 19.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Russell and Arnd: Do you have time to review it? On 2021/1/16 11:27, Zhen Lei wrote: > v4 --> v5: > 1. Add SoC macro ARCH_KUNPENG50X, and the Kunpeng L3 cache controller only enabled > on that platform. > 2. Require the compatible string of the Kunpeng L3 cache controller must have a > relevant name on a specific SoC. For example: > compatible = "hisilicon,kunpeng509-l3cache", "hisilicon,kunpeng-l3cache"; > > v3 --> v4: > Rename the compatible string from "hisilicon,l3cache" to "hisilicon,kunpeng-l3cache". > Then adjust the file name, configuration option name, and description accordingly. > > v2 --> v3: > Add Hisilicon L3 cache controller driver and its document. That's: patch 2-3. > > v1 --> v2: > Discard the middle-tier functions and do silent narrowing cast in the outcache > hook functions. For example: > -static void l2c220_inv_range(unsigned long start, unsigned long end) > +static void l2c220_inv_range(phys_addr_t pa_start, phys_addr_t pa_end) > { > + unsigned long start = pa_start; > + unsigned long end = pa_end; > > > v1: > Do cast phys_addr_t to unsigned long by adding a middle-tier function. > For example: > -static void l2c220_inv_range(unsigned long start, unsigned long end) > +static void __l2c220_inv_range(unsigned long start, unsigned long end) > { > ... > } > +static void l2c220_inv_range(phys_addr_t start, phys_addr_t end) > +{ > + __l2c220_inv_range(start, end); > +} > > > Zhen Lei (4): > ARM: LPAE: Use phys_addr_t instead of unsigned long in outercache > hooks > ARM: hisi: add support for Kunpeng50x SoC > dt-bindings: arm: hisilicon: Add binding for Kunpeng L3 cache > controller > ARM: Add support for Hisilicon Kunpeng L3 cache controller > > .../arm/hisilicon/kunpeng-l3cache.yaml | 40 +++++ > arch/arm/include/asm/outercache.h | 6 +- > arch/arm/mach-hisi/Kconfig | 8 + > arch/arm/mm/Kconfig | 10 ++ > arch/arm/mm/Makefile | 1 + > arch/arm/mm/cache-feroceon-l2.c | 15 +- > arch/arm/mm/cache-kunpeng-l3.c | 153 ++++++++++++++++++ > arch/arm/mm/cache-kunpeng-l3.h | 30 ++++ > arch/arm/mm/cache-l2x0.c | 50 ++++-- > arch/arm/mm/cache-tauros2.c | 15 +- > arch/arm/mm/cache-uniphier.c | 6 +- > arch/arm/mm/cache-xsc3l2.c | 12 +- > 12 files changed, 317 insertions(+), 29 deletions(-) > create mode 100644 Documentation/devicetree/bindings/arm/hisilicon/kunpeng-l3cache.yaml > create mode 100644 arch/arm/mm/cache-kunpeng-l3.c > create mode 100644 arch/arm/mm/cache-kunpeng-l3.h > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel