From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B7281C433F5 for ; Fri, 28 Jan 2022 10:17:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Thbs5Gdx+eaInDXW/p/8cBLTqOdvw1QgWpZQJ7BK8Y4=; b=DQdKXwvc/jRaR5 GE8ayx+pYFvcyxsGVQvNlZXCXrSpP2sa6Y4HsumleNMXsqE7TuV9AZifjT11zvrRTyJsmiRpSqHCE s3UsUpc0WW9SC8bBweu3HL9f8zDQrc0zZCYYRs/o+EyCpkx5L4lsc1+XHIkex/b9SUMHmAyefPjqw 1WXtJgaLP07IoU+jP48AwSbAwyCGswKjsjV/w+V/B1HvZXwSvV+Wy2yF7aqCMOFB4dEpkpbXWnsRP O+Z/OvdOMNi17wMHJBieZjzHZtY8nOEpPpjDois4ADto0jgLJRtqcdP7g1GUInajdHvgrxsS5rKVX HpvvhO0uyi6ihIrPmtgg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nDOIG-001PtH-Uw; Fri, 28 Jan 2022 10:15:49 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nDOFm-001PCN-8d for linux-arm-kernel@lists.infradead.org; Fri, 28 Jan 2022 10:13:16 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3F46B61E32; Fri, 28 Jan 2022 10:13:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 358F4C340E0; Fri, 28 Jan 2022 10:13:10 +0000 (UTC) Message-ID: <040ba85c-6cdd-8053-30ed-194548d23a18@xs4all.nl> Date: Fri, 28 Jan 2022 11:13:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] media: s5p-mfc: set V4L2_BUF_FLAG_LAST flag on final buffer Content-Language: en-US To: Andriy Gelman Cc: Kyungmin Park , Kamil Debski , Jeongtae Park , Andrzej Hajda , Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200502194052.485-1-andriy.gelman@gmail.com> From: Hans Verkuil In-Reply-To: <20200502194052.485-1-andriy.gelman@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220128_021314_413774_A5247BF5 X-CRM114-Status: GOOD ( 17.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi all, I'm going through a bunch of (very) old patches in my patchwork TODO list that for one reason or another I never processed. This patch is one of them. I don't feel comfortable merging this, given the follow-ups that were posted. If someone wants to get this in anyway, then please make a new patch. I'm marking it as 'Changes Requested' in patchwork. Regards, Hans On 02/05/2020 21:40, Andriy Gelman wrote: > From: Andriy Gelman > > As per V4L2 api, the final buffer should set V4L2_BUF_FLAG_LAST flag. > > Signed-off-by: Andriy Gelman > --- > drivers/media/platform/s5p-mfc/s5p_mfc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c b/drivers/media/platform/s5p-mfc/s5p_mfc.c > index 5c2a23b953a4..b3d9b3a523fe 100644 > --- a/drivers/media/platform/s5p-mfc/s5p_mfc.c > +++ b/drivers/media/platform/s5p-mfc/s5p_mfc.c > @@ -614,6 +614,7 @@ static void s5p_mfc_handle_stream_complete(struct s5p_mfc_ctx *ctx) > list_del(&mb_entry->list); > ctx->dst_queue_cnt--; > vb2_set_plane_payload(&mb_entry->b->vb2_buf, 0, 0); > + mb_entry->b->flags |= V4L2_BUF_FLAG_LAST; > vb2_buffer_done(&mb_entry->b->vb2_buf, VB2_BUF_STATE_DONE); > } > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel