From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1212DC433DF for ; Wed, 1 Jul 2020 09:49:15 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C32792067D for ; Wed, 1 Jul 2020 09:49:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Hn6wkkBD"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="seC/1EKt"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=microchiptechnology.onmicrosoft.com header.i=@microchiptechnology.onmicrosoft.com header.b="RPNUvM1h" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C32792067D Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=crcBgWtDKqnDq0x0r228hVFRTo8I8b443BkHxyc3Pbg=; b=Hn6wkkBDpwAQ1ZBVXO+IEQSnB SbsCCct1hrAHaXzz9jiiH1xK8o9Ia9ohb/pq5vs9VN2rmmq6EK/w3RV+/3h66LirCAnTx9OC5xVMl oJXxtC27vUa80lQwV4ADPpztiTe7BO8vQKXM90AXkj4kMnw6AWh1y5Qf6AmTe1e+FS4Nof14MWG4F ix96XedV9VhCJDolYFpW7rgtGbbjl35naBrQsGwLZjugiX82CZXgGDJlVUrFkkvghwFFrnroeXckD V4eHtfAdBR0fcI+rfBBNL/TcXu5zg0hnU/FzU+kSpJQc5rWAL1yWtqAuf2QUOeRSyU96ouzjc4RTk pY8giqrsQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqZLN-0003ze-Ol; Wed, 01 Jul 2020 09:47:53 +0000 Received: from esa4.microchip.iphmx.com ([68.232.154.123]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqZLL-0003yC-BS for linux-arm-kernel@lists.infradead.org; Wed, 01 Jul 2020 09:47:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1593596871; x=1625132871; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=f8njmB0Cv8UwYGw7t2XG/4T60/CXMZmYFYSHtgLYA1A=; b=seC/1EKtpxTXdoOqpXQGLMi35Qz7TbKjLal1Td+4XFpp6uy8RMQxz+OQ /yFY1OCu34k/eVLiEB72KkUKotb2T4+j+IQ6ePddjM0SBIOXskbERUng7 hMyNhbpzOl0vyCIZTzhvYh8vWuhF9rUkAQWZxyLz0sHoxWl7ynX+L4OTs l6Xrm2gDaclRNkKob2ZD8LP77McXgHKqk5aO/Bv49gf8X735qsxzr9qjW sHqajsF5mUHEDXiskhuCQkJ/uzRmzZ0+D0a5gdLDaVGROCjzhebop+bNq oAyEwrveO/Pn18AxDRfv0qCK4FoMQvds2JrQSJhrkS7ewIE15Nj0Ns3/7 g==; IronPort-SDR: qZUo9P+c/SaQ9OixZbJmaMbv+1e7p45O1MWdB1fE13ERdxWURYC19aczUTodJOtplkk9G206Gv IB/PDgkD8btV69B3vrbfEzcC+QXwjC2Nz6D+6b8G9g4uQnvCjr3cMy2fTQsQLl5vRgZ3MiM8KQ m1APhop3FR1U4JIgqRJCt9HE63R7dvksuCRGDeLFjk+2azFNdmVMKe5DH00PbL5Osx0NuNEzNM IRe2BkSYShUnYHUZOoy2K04yJtKGfMFOURbzpggzZm+BcBselRC/gxldtGVXFU0JEksL4AE0XA WLg= X-IronPort-AV: E=Sophos;i="5.75,299,1589266800"; d="scan'208";a="78403906" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa4.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 01 Jul 2020 02:47:44 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3; Wed, 1 Jul 2020 02:47:25 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3 via Frontend Transport; Wed, 1 Jul 2020 02:47:43 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UVYzxOi9+hs5SJShDSBVZJs2qdDc/Klh3LYzyOZa3yHIU3bkebOKmYFm0HagSEqScn53CgTQAJLyAjS8LwY9B/38ks/sSJ3Pp7h7O1+ADw+XGTzWSwICBWyhTx0RX64ymysMWVOTzqSGHht7fCcib9CnQHteKWlL6+I4ND1GH5TpApLNXrzlAHalCFrRay6cAfpAU5KVdBzpQdzqHWRqu5hnw2JzI7RM1qWVBGl5Mj74i49T0AKc791Y4D2VgvVrIBxAcc6y0g8oXRjbkweQc7YVzS4QSkcTovTJMZUW6nB82hgaeoG+DQKYrHqfSvQBIlSq/V9DodiDQru7P19qrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f8njmB0Cv8UwYGw7t2XG/4T60/CXMZmYFYSHtgLYA1A=; b=X2KZlGjJEepnvFZ5wf/3cST38RFM8mKCQf2d+LgbU4azBsFoB1BpB9x/2QCf+6P5WNvpuWWdQgZM9U5WzKVdr2eXn3JZ4yuv7v8awEnuoTef6KNkrePW3DtMEKt5n8jsnlr5Xb4vOQFQ61zjadcnGL4C8uGKGr+qoVncGKkVsuu2hN5TovgCh8e2LURFTAeNA1Xr3fxFeml6Gnpmglm2ernRTB8KT+d41kAhNPRWqYK8MlEbBJI5txzLlUPp4JaH5phvkn4AxZPKm4bC5oySXOPbOYjoldWCdCPij2v7XOXtwS/M/83jb4OWwpi4zze/B5bjDDy3tLg+UQn8RBHdyg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector2-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f8njmB0Cv8UwYGw7t2XG/4T60/CXMZmYFYSHtgLYA1A=; b=RPNUvM1hnPu5Jc4nTTmUasPpOx1DhwbdY6agjDqxNu0RmmBK/+NVYVxXEDVq99KTYt2MSujNBnyeiL3Sjjl4LeQxaY2J18RFLyGkd324CtbpPg088EDUkZYOJS/w04rxWNZwfeqVAZVz8Vx62blZ027ywFTxOxKm+4nAFDFAJJY= Received: from DM6PR11MB3420.namprd11.prod.outlook.com (2603:10b6:5:69::31) by DM5PR11MB1786.namprd11.prod.outlook.com (2603:10b6:3:113::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.21; Wed, 1 Jul 2020 09:47:40 +0000 Received: from DM6PR11MB3420.namprd11.prod.outlook.com ([fe80::e8fd:29e5:1fa6:c01d]) by DM6PR11MB3420.namprd11.prod.outlook.com ([fe80::e8fd:29e5:1fa6:c01d%5]) with mapi id 15.20.3131.027; Wed, 1 Jul 2020 09:47:40 +0000 From: To: Subject: Re: [PATCH 2/2] clk: at91: main: do not continue if oscillators already prepared Thread-Topic: [PATCH 2/2] clk: at91: main: do not continue if oscillators already prepared Thread-Index: AQHWT4yoeo1FeyzI40WRQ/N11qPgjA== Date: Wed, 1 Jul 2020 09:47:40 +0000 Message-ID: <0558282c-1471-84fb-d0f2-00e998db5cab@microchip.com> References: <1593079768-9349-1-git-send-email-claudiu.beznea@microchip.com> <1593079768-9349-2-git-send-email-claudiu.beznea@microchip.com> <20200626210357.GX131826@piout.net> In-Reply-To: <20200626210357.GX131826@piout.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 authentication-results: bootlin.com; dkim=none (message not signed) header.d=none;bootlin.com; dmarc=none action=none header.from=microchip.com; x-originating-ip: [86.127.222.245] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: de25ecd9-47ba-4de2-b0b8-08d81da3cb74 x-ms-traffictypediagnostic: DM5PR11MB1786: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-bypassexternaltag: True x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 04519BA941 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: lq0csEfE5k40+ZSa1N6pTzX4iCSBrknEFDPnaNSOEnfR/rQLyKXw4+3cT3TTJwMIIonhaZcZTiPXaf19337VbDfO5wqXK/vRO1gTL+L0O1MgziqzfEXdNlLmuHKxtWt5Oq06iGHk6zGo71rBfF7DVO9V3HJtSXdlfstoeqh+X7pKp61tdSUiwvHvp6BtjZlqiXB6st5G12JrEgOsQoXeqTy7GttGX4/yDIG7CeRqRQtE/UFDFBz9nV8/Y2dyCHpXN3ZCkKQRR3rVxoAoDRCinJIDgoxzWlJ0UiIIOmjQe5mATpHrVvN9+DlKoJ1rho28erKwCu0ZFY27lqHxP0luKbyKWexJK0YSBjG3O/02TeA8U7/p7jbEYZ7meg47kYzjrz+Yx7MJXhfLt9J9fF44nX9AOqaXPQGU1QzY8eQEovV1vTonnPvY5+mTz9tnP5wKKR9B5pCGezXlFoVc/YPhdg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3420.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(366004)(396003)(39860400002)(136003)(376002)(346002)(6512007)(478600001)(2906002)(186003)(36756003)(316002)(54906003)(6486002)(2616005)(4326008)(83380400001)(6916009)(8676002)(31696002)(66946007)(91956017)(76116006)(6506007)(53546011)(8936002)(966005)(31686004)(5660300002)(26005)(86362001)(71200400001)(66446008)(64756008)(66556008)(66476007)(43740500002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: T55GNlJB5m4EKn8nz3NpIZ5aAyXeS4dF7v4MDk31sH3rW4O96/vVGNrumCYzezQ9yfPbpwsKawBg5yPDYqFU15qgdsxln3m4zG4AqCkqOTJHdGMuq05PSQRl9cSyXX3htJ+6409846pdvkdcVUkhUIM7pTHk291LO2wdoCO6qGUfu6o/abYXZL9IuMT3S0/IC/yk7JQRYLmojvVeYntJ/4LExR4CiqTApWkOqOn+cRNMTahr4Qy0xTsd4eHa9M/K9/JRMK9Kuf409fH9aEFC0iE+3Ii70x+JMnqyjsN1ICh5GX/cyX8ipzutea24gL1AcTN2w5alA9/R/RkakBNUhTeSACXyJ+ACNykYb2C3EYbuEHIaktKRy6nZBFH64OQSjayTYHjVnRuVvyJ4Qd2Y9b9PudVWZ6ohw65cwdKo7m8erAwOyQJ20OEghqT1JIYK/LRhFmB9IIawWNniw2LoMYeqMf15yUS9NPkFIuirJUre+KjItI6l0KK3/IrmXzr9 Content-ID: <37090B53A3E58D4ABDC11BD5047CCA5E@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3420.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: de25ecd9-47ba-4de2-b0b8-08d81da3cb74 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Jul 2020 09:47:40.2092 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: CBL/HwkVCleQd818Oqok1owHdvF/K4M1I50vXGATgpQjrqWcEbj73G9yi0zNOalH7Wp8xXhnyGh5pTryFPxQa7Y1Ur/CVR5R7m4z3oYVhww= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1786 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200701_054751_718047_E0D8A4AB X-CRM114-Status: GOOD ( 19.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mturquette@linaro.org, bbrezillon@kernel.org, sboyd@kernel.org, mturquette@baylibre.com, linux-kernel@vger.kernel.org, Ludovic.Desroches@microchip.com, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 27.06.2020 00:03, Alexandre Belloni wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On 25/06/2020 13:09:28+0300, Claudiu Beznea wrote: >> Return in clk_main_osc_prepare()/clk_main_rc_osc_prepare() if >> oscillators are already enabled. >> >> Fixes: 27cb1c2083373 ("clk: at91: rework main clk implementation") >> Fixes: 1bdf02326b71e ("clk: at91: make use of syscon/regmap internally") > > Is this really a fix? What is the observed issue? > >> Signed-off-by: Claudiu Beznea >> --- >> drivers/clk/at91/clk-main.c | 18 +++++++++--------- >> 1 file changed, 9 insertions(+), 9 deletions(-) >> >> diff --git a/drivers/clk/at91/clk-main.c b/drivers/clk/at91/clk-main.c >> index 37c22667e831..46b4d2131989 100644 >> --- a/drivers/clk/at91/clk-main.c >> +++ b/drivers/clk/at91/clk-main.c >> @@ -74,13 +74,11 @@ static int clk_main_osc_prepare(struct clk_hw *hw) >> regmap_read(regmap, AT91_CKGR_MOR, &tmp); >> tmp &= ~MOR_KEY_MASK; >> >> - if (tmp & AT91_PMC_OSCBYPASS) >> + if (tmp & (AT91_PMC_OSCBYPASS | AT91_PMC_MOSCEN)) >> return 0; > > While this seems like a good optimization, it is also not correct. > Having AT91_PMC_MOSCEN set doesn't mean that the clock is ready, you > need to at least check MOSCS once. I agree! This is may introduce issues. Thank you for reviewing it. > >> >> - if (!(tmp & AT91_PMC_MOSCEN)) { >> - tmp |= AT91_PMC_MOSCEN | AT91_PMC_KEY; >> - regmap_write(regmap, AT91_CKGR_MOR, tmp); >> - } >> + tmp |= AT91_PMC_MOSCEN | AT91_PMC_KEY; >> + regmap_write(regmap, AT91_CKGR_MOR, tmp); >> >> while (!clk_main_osc_ready(regmap)) >> cpu_relax(); >> @@ -186,10 +184,12 @@ static int clk_main_rc_osc_prepare(struct clk_hw *hw) >> >> regmap_read(regmap, AT91_CKGR_MOR, &mor); >> >> - if (!(mor & AT91_PMC_MOSCRCEN)) >> - regmap_update_bits(regmap, AT91_CKGR_MOR, >> - MOR_KEY_MASK | AT91_PMC_MOSCRCEN, >> - AT91_PMC_MOSCRCEN | AT91_PMC_KEY); >> + if (mor & AT91_PMC_MOSCRCEN) >> + return 0; >> + >> + regmap_update_bits(regmap, AT91_CKGR_MOR, >> + MOR_KEY_MASK | AT91_PMC_MOSCRCEN, >> + AT91_PMC_MOSCRCEN | AT91_PMC_KEY); >> >> while (!clk_main_rc_osc_ready(regmap)) >> cpu_relax(); >> -- >> 2.7.4 >> > > -- > Alexandre Belloni, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel