From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B75A3C04FF3 for ; Mon, 24 May 2021 21:05:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 73B1060233 for ; Mon, 24 May 2021 21:05:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 73B1060233 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=fggoHqCAwBCH+OL8UI3aKn/KSn61BujoWcOb9/1JnCw=; b=T+LQHqT5kP1kczSAyKqM/zdd/q CByc6vG8WOUhQVZr9bvM6/BC3m+4vbwDKgBrff2Ubwdx0LUCIdHM8AL50oN5KiJqzrrNUShuelIBJ wGIvtZLziAbAPgZk2pV/pUfbTp4GKI8YLjsK2DVY3fj/M31GH/a2ctENz9JeescgrOPBV3t0b+DS+ 4tNSMXZfU+9nI8XitVVveiTBZ7TUuHHsAmck1Brt2bQdTBNBQbo2KQTr0Voi1vCahhGYTAoUi2Nqa k1nlsedTO3puu0oEK2Hj3X+LIPkhvrOloAJ/EW5ediNkk6Zc58URL6NqephUTqWeeP8lvtyQZoKF6 j9lMmfEw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1llHgs-001sc2-BX; Mon, 24 May 2021 21:00:53 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ll8Cm-000qW9-DS for linux-arm-kernel@lists.infradead.org; Mon, 24 May 2021 10:53:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621853580; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HFtn2RHOEYss0CsLYkuce8tbA8oq7IWTJChBbEjpcfU=; b=ffD3PageWF4fXf7RSmBVF+Xim6gcG4G05zGv3xQDfx1YcUy+pgX5cpBhTU3iXg1jbW1ZMT KSD9I98xk4rrnwsEFllhY0LvzvZM1ssrM0lu2bcDPRQxsdSnCZjdxW/ujSb9WQ4iF5+Hsm TgKEiUEGaq8cKh/iJR/q+m9/7vAjnRg= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-86-nUQeuQ3xNMiALnObR8yLPA-1; Mon, 24 May 2021 06:52:53 -0400 X-MC-Unique: nUQeuQ3xNMiALnObR8yLPA-1 Received: by mail-wr1-f69.google.com with SMTP id 2-20020adf94020000b0290110481f75ddso12927461wrq.21 for ; Mon, 24 May 2021 03:52:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=HFtn2RHOEYss0CsLYkuce8tbA8oq7IWTJChBbEjpcfU=; b=DrwJZl1L8OllS83gzQCxInZ5Lbt8UfbUpy8Qvz0O0cNqMXHXPTfdI0aM+xZRUygp0X JdyNSJxbfDVkCoT9mA9OWLHPATf4Fqzn7s0FW1ss5hc9uJ+9HUeXjJ+nCX0oo5CSHFGg HP4Y8LjA+LpCiU5D5Gd2h5GFM3BOgd6DxuaZqWeyndmWFjcN7rVr7vTbtUuartVmwT5v StaSY6P5Bv0TYgEzNCjBlEeUIsgPPNTcK62UG2BLE+eXuNxsQRfJjE99V/Ll58YP+msQ RedT042bNQTbzf+M13ZpHMc0JlclcZHojo6vtsrhorWkh6mo979WlBHocBI0CyeR75U/ fUag== X-Gm-Message-State: AOAM53267i90meinztgQ+VZ0mu1kTaKzkr1F1V5H9xwDfaPoD8as6atN c7zeYlQK+eDqZN52Db6rNKQdXeBxan/P7Zbmfs3oQjLkWE//LMMdCp19B9QHb4puQLjyXBfXZRj ADQhpdxmRCURhmfAM3z0/9ECSWgvPlLgjWAI= X-Received: by 2002:adf:cd0b:: with SMTP id w11mr20622279wrm.178.1621853572523; Mon, 24 May 2021 03:52:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyBBAfkXTMs2YQFUS4bUXgvPMEgtCieGtjpbUoBA1QSYRX/jn26s0lewHHOil8Ex/lxYcBBJg== X-Received: by 2002:adf:cd0b:: with SMTP id w11mr20622252wrm.178.1621853572312; Mon, 24 May 2021 03:52:52 -0700 (PDT) Received: from [192.168.1.101] ([92.176.231.106]) by smtp.gmail.com with ESMTPSA id r11sm11966441wrp.46.2021.05.24.03.52.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 May 2021 03:52:51 -0700 (PDT) Subject: Re: [PATCH 0/2] allow the sysfb support to be used in non-x86 arches To: Ard Biesheuvel Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Daniel Vetter , Peter Robinson , Thomas Zimmermann , David Airlie , Hans de Goede , Albert Ou , Borislav Petkov , Catalin Marinas , "H. Peter Anvin" , Ingo Molnar , Palmer Dabbelt , Paul Walmsley , Russell King , Thomas Gleixner , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-efi@vger.kernel.org, linux-riscv@lists.infradead.org, x86@kernel.org References: <20210521192907.3040644-1-javierm@redhat.com> From: Javier Martinez Canillas Message-ID: <0613bc6b-31b4-93f6-b111-4692778f76c0@redhat.com> Date: Mon, 24 May 2021 12:52:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=javierm@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210524_035304_539521_10EDD73C X-CRM114-Status: GOOD ( 25.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Ard, On 5/24/21 12:24 PM, Ard Biesheuvel wrote: [snip] >> Since this touches both arch/{x86,arm,arm64,riscv} and drivers/firmware, I >> don't know how it should be merged. But I didn't find a way to split these. >> > > We could merge this via the EFI tree without too much risk of > conflicts, I think. > Great, thanks. > However, I'd like to see a better explanation of why this is an improvement. > The diffstat does not show a huge net win, and it does not enable > anything we didn't already have before, right? > > I mentioned a little in the cover letter but you are correct that wasn't that clear. My motivation was to use the simpledrm driver instead of efifb for the early console, so I could boot without using fbdev at all. The register_gop_device() in drivers/firmware/efi/efi-init.c only register an "efi-frambuffer" platform device, which means that it will only allow to use the efifb driver for the early framebuffer on EFI systems. The "simple-framebuffer" platform device is only registered by OF if there's a DT node with this compatible string, but it won't be registered for EFI. So the simplefb or newly added simpledrm driver won't be matched and probed with the current EFI support in aarch64 or riscv. In contrast, the x86 code does register a "simple-framebuffer" device that uses the GOP framebuffer. One option is to add the same logic in register_gop_device(), but that would require even more code duplication. Another option would be to make the simple drivers to match against "efi-framebuffer", but that would be an ugly solution. But even without taking the lack of "simple-framebuffer" into account, I wonder what would be the benefit of keeping two code paths that do basically the same. Best regards, -- Javier Martinez Canillas Software Engineer New Platform Technologies Enablement team RHEL Engineering _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel