From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA328C7618F for ; Fri, 26 Jul 2019 04:28:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7DE9521951 for ; Fri, 26 Jul 2019 04:28:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="umnYGDPP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7DE9521951 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:References:To:Subject:From:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Uik6J1ZKIfRuNxuUoxvUmUAIxQzOrtUMZhWsqD+c2qc=; b=umnYGDPPin2yBQ W+UktepcHbztkZOrtA4lt0UVnv7S2Q5orG/U+At9qAtlkSsrG7qcwJksqg+a23jZZ5BBS9wT1QFDj Zo/hwzYGYzU34MUrAqXsvV0H5vYFLu0to99/XndN1K9/cbTIN4iTamymXNf81nVXVxnjkKQxuvGh+ dIOANmGAk6owN1mo+Tg6uTkarzPY8/9OWH1EcbM8Ft7AIaduRJpfL7LxXzdPD1ZJWOllPGOoX5j+/ 9rq7R8ylEdX1EmWbBnq2H8dI2NbQ4v7OVQ6Sy8eazbToD4kcYoSuHluOvvL85GyO/wDoLH0ZZpHnh D1+ZxIkG9Xh0uTVxLMUw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hqrqI-0004vG-UG; Fri, 26 Jul 2019 04:28:30 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hqrqE-0004um-5r for linux-arm-kernel@lists.infradead.org; Fri, 26 Jul 2019 04:28:27 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D942A337; Thu, 25 Jul 2019 21:28:23 -0700 (PDT) Received: from [10.163.1.197] (unknown [10.163.1.197]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 387953F694; Thu, 25 Jul 2019 21:28:18 -0700 (PDT) From: Anshuman Khandual Subject: Re: [RFC] mm/pgtable/debug: Add test validating architecture page table helpers To: Catalin Marinas References: <1564037723-26676-1-git-send-email-anshuman.khandual@arm.com> <1564037723-26676-2-git-send-email-anshuman.khandual@arm.com> <20190725170720.GB11545@arrakis.emea.arm.com> Message-ID: <066e69dc-6ecc-6aba-0226-ba1d61ca0fa8@arm.com> Date: Fri, 26 Jul 2019 09:58:56 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190725170720.GB11545@arrakis.emea.arm.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190725_212826_264840_ED6DFD42 X-CRM114-Status: GOOD ( 11.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Kees Cook , Sri Krishna chowdary , Ard Biesheuvel , Tetsuo Handa , x86@kernel.org, Dave Hansen , linux-kernel@vger.kernel.org, Matthew Wilcox , Michal Hocko , linux-mm@kvack.org, Masahiro Yamada , Mark Brown , Andrew Morton , Steven Price , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 07/25/2019 10:37 PM, Catalin Marinas wrote: > On Thu, Jul 25, 2019 at 12:25:23PM +0530, Anshuman Khandual wrote: >> +#if !defined(__PAGETABLE_PMD_FOLDED) && !defined(__ARCH_HAS_4LEVEL_HACK) >> +static void pud_clear_tests(void) >> +{ >> + pud_t pud; >> + >> + pud_clear(&pud); >> + WARN_ON(!pud_none(pud)); >> +} > > For the clear tests, I think you should initialise the local variable to > something non-zero rather than rely on whatever was on the stack. In > case it fails, you have a more deterministic behaviour. Sure, it makes sense, will change. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel