From: "Jürgen Groß" <jgross@suse.com>
To: Julien Grall <julien@xen.org>, xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, Julien Grall <jgrall@amazon.com>,
linux-kernel@vger.kernel.org, Ian Jackson <iwj@xenproject.org>,
dwmw@amazon.co.uk, boris.ostrovsky@oracle.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm/xen: Don't probe xenbus as part of an early initcall
Date: Thu, 11 Feb 2021 07:55:42 +0100 [thread overview]
Message-ID: <06a4feb3-a29e-221d-cdb6-68b9c453b2a4@suse.com> (raw)
In-Reply-To: <20210210170654.5377-1-julien@xen.org>
[-- Attachment #1.1.1.1: Type: text/plain, Size: 941 bytes --]
On 10.02.21 18:06, Julien Grall wrote:
> From: Julien Grall <jgrall@amazon.com>
>
> After Commit 3499ba8198cad ("xen: Fix event channel callback via
> INTX/GSI"), xenbus_probe() will be called too early on Arm. This will
> recent to a guest hang during boot.
>
> If there hang wasn't there, we would have ended up to call
> xenbus_probe() twice (the second time is in xenbus_probe_initcall()).
>
> We don't need to initialize xenbus_probe() early for Arm guest.
> Therefore, the call in xen_guest_init() is now removed.
>
> After this change, there is no more external caller for xenbus_probe().
> So the function is turned to a static one. Interestingly there were two
> prototypes for it.
>
> Fixes: 3499ba8198cad ("xen: Fix event channel callback via INTX/GSI")
> Reported-by: Ian Jackson <iwj@xenproject.org>
> Signed-off-by: Julien Grall <jgrall@amazon.com>
Pushed to xen/tip.git for-linus-5.11
Juergen
[-- Attachment #1.1.1.2: OpenPGP_0xB0DE9DD628BF132F.asc --]
[-- Type: application/pgp-keys, Size: 3135 bytes --]
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-02-11 6:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 17:06 [PATCH] arm/xen: Don't probe xenbus as part of an early initcall Julien Grall
2021-02-10 17:49 ` Woodhouse, David
2021-02-10 21:36 ` Stefano Stabellini
2021-02-11 6:55 ` Jürgen Groß [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06a4feb3-a29e-221d-cdb6-68b9c453b2a4@suse.com \
--to=jgross@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=dwmw@amazon.co.uk \
--cc=iwj@xenproject.org \
--cc=jgrall@amazon.com \
--cc=julien@xen.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).