From: "Shenhar, Talel" <talel@amazon.com>
To: Borislav Petkov <bp@alien8.de>, <robh+dt@kernel.org>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
benh@kernel.crashing.org, talel@amazon.com, hhhawa@amazon.com,
gregkh@linuxfoundation.org, eitan@amazon.com, jonnyc@amazon.com,
hanochu@amazon.com, linux-kernel@vger.kernel.org,
james.morse@arm.com, dwmw@amazon.co.uk, catalin.marinas@arm.com,
ronenk@amazon.com, mchehab@kernel.org, will@kernel.org,
davem@davemloft.net, linux-arm-kernel@lists.infradead.org,
linux-edac@vger.kernel.org
Subject: Re: [PATCH v6 1/2] dt-bindings: edac: al-mc-edac: Amazon's Annapurna Labs Memory Controller EDAC
Date: Thu, 7 May 2020 17:44:09 +0300 [thread overview]
Message-ID: <07f3b407-fa91-f3b4-bc7c-9692a7b3c3c7@amazon.com> (raw)
In-Reply-To: <5e2c5119-52e9-2c3c-e205-e661ba218fcb@amazon.com>
On 5/5/2020 1:44 PM, Shenhar, Talel wrote:
>
> On 4/28/2020 2:06 PM, Borislav Petkov wrote:
>> On Mon, Feb 24, 2020 at 03:41:31PM +0200, Talel Shenhar wrote:
>>> Document Amazon's Annapurna Labs Memory Controller EDAC SoC binding.
>>>
>>> Signed-off-by: Talel Shenhar <talel@amazon.com>
>>> Reviewed-by: Rob Herring <robh@kernel.org>
>>> ---
>>> .../bindings/edac/amazon,al-mc-edac.yaml | 52
>>> +++++++++++++++++++
>>> 1 file changed, 52 insertions(+)
>>> create mode 100644
>>> Documentation/devicetree/bindings/edac/amazon,al-mc-edac.yaml
>>>
>>> diff --git
>>> a/Documentation/devicetree/bindings/edac/amazon,al-mc-edac.yaml
>>> b/Documentation/devicetree/bindings/edac/amazon,al-mc-edac.yaml
>>> new file mode 100644
>>> index 000000000000..20505f37c9f8
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/edac/amazon,al-mc-edac.yaml
>>> @@ -0,0 +1,52 @@
>>> +# SPDX-License-Identifier: GPL-2.0-only
>> WARNING: DT binding documents should be licensed (GPL-2.0-only OR
>> BSD-2-Clause)
>> #36: FILE:
>> Documentation/devicetree/bindings/edac/amazon,al-mc-edac.yaml:1:
>> +# SPDX-License-Identifier: GPL-2.0-only
>>
>> Hi Rob, should I listen to checkpatch or ignore it?
>
> Rob and other dt folks,
>
> In continue to disscussion with Boris below, Looking at the checkpatch
> check:
>
> if ($realfile =~ m@^Documentation/devicetree/bindings/@ &&
> not $spdx_license =~/GPL-2\.0.*BSD-2-Clause/) {
>
> It wants the whole string "GPL-2.0-only OR BSD-2-Clause" and my oatch
> has only "GPL-2.0-only".
>
> Now, looking at a bunch of .yaml DT files, there are all kinds of
> formatting:
>
> $ git grep -h SPDX *.yaml | sort | uniq -c
> 3 1:# SPDX-License-Identifier: (GPL-2.0)
> 313 1:# SPDX-License-Identifier: GPL-2.0
> 9 1:# SPDX-License-Identifier: GPL-2.0+
> 1 1:# SPDX-License-Identifier: (GPL-2.0-only)
> 43 1:# SPDX-License-Identifier: GPL-2.0-only
> 4 1:# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause)
> 1 1:# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause
> 148 1:# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> 25 1:# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> 104 1:# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> 3 1:# SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause
> 2 1:# SPDX-License-Identifier: (GPL-2.0+ OR BSD-2-Clause)
> 1 1:# SPDX-License-Identifier: (GPL-2.0-or-later)
> 5 1:# SPDX-License-Identifier: GPL-2.0-or-later
> 3 1:# SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause)
> 2 1:# SPDX-License-Identifier: GPL-2.0-or-later OR BSD-2-Clause
> 3 1:# SPDX-License-Identifier: (GPL-2.0 OR MIT)
> 3 1:# SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> 3 1:# SPDX-License-Identifier: (GPL-2.0+ OR X11)
>
> And the patch which did rule is:
>
> commit 50c92900214dd9a55bcecc3c53e90d072aff6560
> Author: Lubomir Rintel<lkundrak@v3.sk>
> Date: Mon Apr 6 20:11:13 2020 -0700
>
> checkpatch: check proper licensing of Devicetree bindings
>
> According to Devicetree maintainers (see Link: below), the Devicetree
> binding documents are preferrably licensed (GPL-2.0-only OR
> BSD-2-Clause).
>
> Let's check that. The actual check is a bit more relaxed, to
> allow more
> liberal but compatible licensing (e.g. GPL-2.0-or-later OR
> BSD-2-Clause).
>
>
> Will love your help.
> This patch already have your (Rob) Reviewed-by so Boris and myself are
> unsure what is the right thing to do now.
Borislav, after internal disscussion, we are good to go with the new
license.
This shall be part of v7.
>
> Thanks,
> Talel.
>
>>
>> --
>> Regards/Gruss,
>> Boris.
>>
>> https://people.kernel.org/tglx/notes-about-netiquette
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-05-07 14:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 13:41 [PATCH v6 0/2] Amazon's Annapurna Labs Memory Controller EDAC Talel Shenhar
2020-02-24 13:41 ` [PATCH v6 1/2] dt-bindings: edac: al-mc-edac: " Talel Shenhar
2020-04-28 11:06 ` Borislav Petkov
2020-05-03 14:21 ` Shenhar, Talel
2020-05-05 10:44 ` Shenhar, Talel
2020-05-07 14:44 ` Shenhar, Talel [this message]
2020-02-24 13:41 ` [PATCH v6 2/2] EDAC: al-mc-edac: Introduce " Talel Shenhar
2020-04-28 11:39 ` Borislav Petkov
[not found] ` <46ccdb47-f28d-63f7-e759-1ba34e98add8@amazon.com>
2020-05-04 18:37 ` Borislav Petkov
2020-05-05 10:55 ` Shenhar, Talel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07f3b407-fa91-f3b4-bc7c-9692a7b3c3c7@amazon.com \
--to=talel@amazon.com \
--cc=benh@kernel.crashing.org \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dwmw@amazon.co.uk \
--cc=eitan@amazon.com \
--cc=gregkh@linuxfoundation.org \
--cc=hanochu@amazon.com \
--cc=hhhawa@amazon.com \
--cc=james.morse@arm.com \
--cc=jonnyc@amazon.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=ronenk@amazon.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).