linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Neil Armstrong <narmstrong@baylibre.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: khilman@baylibre.com, jbrunet@baylibre.com,
	linux-amlogic@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] arm64: dts: meson-sm1: add Banana PI BPI-M5 board dts
Date: Fri, 14 May 2021 16:29:02 +0200	[thread overview]
Message-ID: <089dfcb8-e821-da98-d93f-f3aea3d45ad3@baylibre.com> (raw)
In-Reply-To: <CAFBinCBa=rHQ+Sho2Lq0cA0dYnhKX4ZJaQUqBcaiOxNzD+bFiA@mail.gmail.com>

On 05/05/2021 22:20, Martin Blumenstingl wrote:
> Hi Neil,
> 
> On Wed, May 5, 2021 at 9:32 AM Neil Armstrong <narmstrong@baylibre.com> wrote:
>>
>> Banana Pi BPI-M5 is a credit card format SBC with the following features:
>> - Amlogic S905X3 quad core Cortex-A55
>> - Mali-G31 GPU
>> - 4GB LPDDR4
>> - 16GB eMMC flash
>> - 4 USB 3.0
>> - 1 GbE ethernet
>> - HDMI output
>> - 2x LEDS
>> - SDCard
>> - 2.5mm Jack with Stereo Audio + CVBS
>> - Infrared Received
>> - ADC Button
>> - GPIO Button
>> - 40 pins header + 3pins debug header
>>
>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> one nit-pick below, but still this gets my:
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> 
> [...]
>> +       /*
>> +        * WARNING: The USB Hub on the BPI-M54 needs a reset signal
> s/BPI-M5/BPI-M54/
> I am hoping that Kevin can fix this while applying

I'll send a v3 since I forgot to CC DT maintainers for patch 2 anyway..

Neil

> 
> 
> Best regards,
> Martin
> 


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

      reply	other threads:[~2021-05-14 14:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-05  7:32 [PATCH v2 0/3] arm64: meson-sm1: add support for Banana PI BPI-M5 Neil Armstrong
2021-05-05  7:32 ` [PATCH v2 1/3] arm64: dts: meson-sm1: add toacodec node Neil Armstrong
2021-05-05  7:32 ` [PATCH v2 2/3] dt-bindings: arm: amlogic: add Banana PI M5 bindings Neil Armstrong
2021-05-05  7:32 ` [PATCH v2 3/3] arm64: dts: meson-sm1: add Banana PI BPI-M5 board dts Neil Armstrong
2021-05-05 20:20   ` Martin Blumenstingl
2021-05-14 14:29     ` Neil Armstrong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=089dfcb8-e821-da98-d93f-f3aea3d45ad3@baylibre.com \
    --to=narmstrong@baylibre.com \
    --cc=jbrunet@baylibre.com \
    --cc=khilman@baylibre.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.blumenstingl@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).