From: Amelie DELAUNAY <amelie.delaunay@st.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Alexandre TORGUE <alexandre.torgue@st.com>,
Randy Dunlap <rdunlap@infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"kbuild-all@01.org" <kbuild-all@01.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] pinctrl: stmfx: Fix compile issue when CONFIG_OF_GPIO is not defined
Date: Thu, 23 May 2019 14:11:11 +0000 [thread overview]
Message-ID: <08ea97544018430caf53af36677902b7@SFHDAG3NODE2.st.com> (raw)
In-Reply-To: <CACRpkdYmdpwEvCBrL6i1V+Zxd0OSpZmD8BJPSZu9jYNeJkoimQ@mail.gmail.com>
On 5/22/19 11:48 PM, Linus Walleij wrote:
> On Wed, May 22, 2019 at 11:21 AM Amelie DELAUNAY <amelie.delaunay@st.com> wrote:
>
>> ../drivers/pinctrl/pinctrl-stmfx.c:409:20: error:
>> ‘pinconf_generic_dt_node_to_map_pin’ undeclared here (not in a function)
>> .dt_node_to_map = pinconf_generic_dt_node_to_map_pin,
>>
>> OF_GPIO depends on OF.
>>
>> So either
>> depends on OF || (OF && COMPILE_TEST)
>> or
>> depends on OF || (OF_GPIO && COMPILE_TEST)
>>
>> and
>>
>> select OF_GPIO
>
> I would use just:
>
> depends on OF_GPIO
>
> Because OF_GPIO already depends on OF, and
> compile tests will not work without OF_GPIO which
> require OF so...
>
> Besides it is what most other GPIO drivers do.
>
> So just keep that one line and drop the rest.
>
> Yours,
> Linus Walleij
>
Ok so I can get rid of COMPILE_TEST ?
depends on I2C
depends on OF_GPIO
select GENERIC_PINCONF
select GPIOLIB_IRQCHIP
select MFD_STMFX
Because I've no arch to balance COMPILE_TEST. Or maybe something like
depends on OF_GPIO && (OF || COMPILE_TEST)
even if OF_GPIO && OF is redundant ?
Regards,
Amelie
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-05-23 14:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 7:52 [PATCH] pinctrl: stmfx: Fix compile issue when CONFIG_OF_GPIO is not defined Amelie Delaunay
2019-05-22 0:22 ` Randy Dunlap
2019-05-22 5:48 ` Lee Jones
2019-05-22 8:08 ` Amelie DELAUNAY
2019-05-22 8:41 ` Lee Jones
2019-05-22 9:20 ` Amelie DELAUNAY
2019-05-22 9:30 ` Lee Jones
2019-05-22 21:48 ` Linus Walleij
2019-05-23 14:11 ` Amelie DELAUNAY [this message]
2019-05-23 19:18 ` Linus Walleij
2019-05-24 7:27 ` Amelie DELAUNAY
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08ea97544018430caf53af36677902b7@SFHDAG3NODE2.st.com \
--to=amelie.delaunay@st.com \
--cc=alexandre.torgue@st.com \
--cc=kbuild-all@01.org \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).