From: vivek.gautam@codeaurora.org (vivek.gautam at codeaurora.org)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 21/22] phy: Add support for Qualcomm's USB HSIC phy
Date: Fri, 02 Sep 2016 16:58:12 +0530 [thread overview]
Message-ID: <0a3780a5073324772b873b8c474358c5@codeaurora.org> (raw)
In-Reply-To: <147276722271.30255.17486402880702436547@sboyd-linaro>
On 2016-09-02 03:30, Stephen Boyd wrote:
> (Please trim replies)
sorry, will take care from next time.
>
> Quoting Vivek Gautam (2016-08-31 23:17:55)
>> On Thu, Sep 1, 2016 at 6:10 AM, Stephen Boyd <stephen.boyd@linaro.org>
>> wrote:
>> > +
>> > + uphy->cal_sleep_clk = clk = devm_clk_get(&ulpi->dev, "cal_sleep");
>> > + if (IS_ERR(clk))
>> > + return PTR_ERR(clk);
>> > +
>> > + uphy->phy = devm_phy_create(&ulpi->dev, ulpi->dev.of_node,
>> > + &qcom_usb_hsic_phy_ops);
>>
>> There's a ulpi_phy library available in drivers/phy/. Do we want to
>> use that ?
>> That also creates a phy-lookup of this PHY so that the ulpi device's
>> parent
>> can request the PHY.
>
> I don't have any interest in using those two functions (does two
> functions constitute a library?).
Not really.
> There's no devm as you say,
I meant to say that you may need to change the existing APIs to the
devm_* APIs.
> and it seems to be specific to the ULPI hardware for dwc3 (the only
> user) where
> the phy is called "usb2-phy".
This was used with TI's USB 2.0 PHY, that has ULPI interface.
> This is a phy for the ChipIdea controller
> which only has one phy and it's called "usb-phy" in that case.
In a way this is also a USB 2.0 phy, isn't it ?
>
>>
>> You may want to modify the APIs available in ulpi_phy library to use
>> the
>> devm_* APIs.
>>
>
> The lookup isn't necessary because we use DT to find the lookup. I seem
> to recall the phy framework requiring a DT lookup too.
The lookup created in this ulpi_phy.h was used to help getting the PHY
in the
driver for parent device (a core wrapper) of the controller (platform
glue layer) that requests this PHY.
I am not certain at this point about how PHY has to be handled in case
of Chipidea.
Was just throwing in ideas. :-)
Thanks
Vivek
next prev parent reply other threads:[~2016-09-02 11:28 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-01 0:40 [PATCH v3 00/22] Support qcom's HSIC USB and rewrite USB2 HS phy support Stephen Boyd
2016-09-01 0:40 ` [PATCH v3 01/22] of: device: Support loading a module with OF based modalias Stephen Boyd
2016-09-01 0:40 ` [PATCH v3 02/22] of: device: Export of_device_{get_modalias, uvent_modalias} to modules Stephen Boyd
2016-09-01 0:40 ` [PATCH v3 03/22] usb: ulpi: Support device discovery via device properties Stephen Boyd
2016-09-02 14:09 ` Heikki Krogerus
2016-09-03 1:14 ` Stephen Boyd
2016-09-01 0:40 ` [PATCH v3 04/22] usb: chipidea: Only read/write OTGSC from one place Stephen Boyd
2016-09-02 2:43 ` Peter Chen
2016-09-01 0:40 ` [PATCH v3 05/22] usb: chipidea: Handle extcon events properly Stephen Boyd
2016-09-01 0:40 ` [PATCH v3 06/22] usb: chipidea: Add platform flag for wrapper phy management Stephen Boyd
2016-09-01 0:40 ` [PATCH v3 07/22] usb: chipidea: Notify events when switching host mode Stephen Boyd
2016-09-01 0:40 ` [PATCH v3 08/22] usb: chipidea: Remove locking in ci_udc_start() Stephen Boyd
2016-09-01 0:40 ` [PATCH v3 09/22] usb: chipidea: Add support for ULPI PHY bus Stephen Boyd
2016-09-02 2:47 ` Peter Chen
2016-09-01 0:40 ` [PATCH v3 10/22] usb: chipidea: Consolidate extcon notifiers Stephen Boyd
2016-09-02 3:17 ` Peter Chen
2016-09-03 1:03 ` Stephen Boyd
2016-09-05 2:39 ` Peter Chen
2016-09-06 17:48 ` Stephen Boyd
2016-09-01 0:40 ` [PATCH v3 11/22] usb: chipidea: msm: Mark device as runtime pm active Stephen Boyd
2016-09-01 0:40 ` [PATCH v3 12/22] usb: chipidea: msm: Rely on core to override AHBBURST Stephen Boyd
2016-09-01 0:40 ` [PATCH v3 13/22] usb: chipidea: msm: Use hw_write_id_reg() instead of writel Stephen Boyd
2016-09-01 0:40 ` [PATCH v3 14/22] usb: chipidea: msm: Add proper clk and reset support Stephen Boyd
2016-09-01 0:40 ` [PATCH v3 15/22] usb: chipidea: msm: Mux over secondary phy at the right time Stephen Boyd
2016-09-01 0:40 ` [PATCH v3 16/22] usb: chipidea: msm: Restore wrapper settings after reset Stephen Boyd
2016-09-01 0:40 ` [PATCH v3 17/22] usb: chipidea: msm: Make platform data driver local instead of global Stephen Boyd
2016-09-01 0:40 ` [PATCH v3 18/22] usb: chipidea: msm: Add reset controller for PHY POR bit Stephen Boyd
2016-09-02 3:33 ` Peter Chen
2016-09-01 0:40 ` [PATCH v3 19/22] usb: chipidea: msm: Handle phy power states Stephen Boyd
2016-09-01 0:40 ` [PATCH v3 20/22] usb: chipidea: msm: Be silent on probe defer errors Stephen Boyd
2016-09-01 0:40 ` [PATCH v3 21/22] phy: Add support for Qualcomm's USB HSIC phy Stephen Boyd
2016-09-01 6:17 ` Vivek Gautam
2016-09-01 22:00 ` Stephen Boyd
2016-09-02 11:28 ` vivek.gautam at codeaurora.org [this message]
2016-09-01 0:40 ` [PATCH v3 22/22] phy: Add support for Qualcomm's USB HS phy Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a3780a5073324772b873b8c474358c5@codeaurora.org \
--to=vivek.gautam@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).