From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A0C2C2D0B1 for ; Fri, 7 Feb 2020 06:41:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5A6252082E for ; Fri, 7 Feb 2020 06:41:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="q/tCbLje"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="OBd7LKqC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5A6252082E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=CVqqAsGb4TyVlRkg+ajwNMRbKB0+LCZsDtr5wfBy8B0=; b=q/tCbLjemrIndzJJM7XOdYQT6 ezzijpHTAg4DqC+xxGr1EQPEDk7boBsqb2QNikv621LWigzBImqVqU6U++PMj1S2Ia8g7wYiPQ27o uDH60n+r+LTIIxUjq7PLrPv2Uz/GcC4yxB+QmwmRGS+d+bZjxqx9ZP45Vie92H9azJ6SOuN+VAeFN D19yn9fs9Q3aX5tspHYAOpvLgX6av3evwI626eqjK3eohO31k3RufcPUq+cUD0QaHXoE+qNqNrIzG Y1UDJLXuuy2NPJcExHxVKkphjNP5kfUdlbgYltqdrVwBS6Ay83228lw2gd6Jl2Uj6ZKFmtcb5i1tA oXnkj9wNg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1izxKE-0007jd-IB; Fri, 07 Feb 2020 06:41:14 +0000 Received: from mail25.static.mailgun.info ([104.130.122.25]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1izxK9-0007ii-NF for linux-arm-kernel@lists.infradead.org; Fri, 07 Feb 2020 06:41:12 +0000 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1581057670; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=YcmWYUVZoZZ5xp+hXjD/DbuPvpwvOawaFCYTP2ks1V4=; b=OBd7LKqCUkoPudD7toUUbEXP+sieTkESdIPQ6xBViRXE0Q1G2Dp8XBNvceogRpRDQyZN7kx2 HuI3bFGD7x3sGcl6VKrzoXURUMpg6bWJ9smRDSZNNNvlGz77lHckLsQIxaYzHdqGr1KxAhjR k6s9ErI9mTiO+z+qyoxIEr6tJFM= X-Mailgun-Sending-Ip: 104.130.122.25 X-Mailgun-Sid: WyJiYzAxZiIsICJsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e3d0681.7fd98a9537d8-smtp-out-n01; Fri, 07 Feb 2020 06:41:05 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 4827FC433A2; Fri, 7 Feb 2020 06:41:04 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: sibis) by smtp.codeaurora.org (Postfix) with ESMTPSA id E2126C433CB; Fri, 7 Feb 2020 06:41:03 +0000 (UTC) MIME-Version: 1.0 Date: Fri, 07 Feb 2020 12:11:03 +0530 From: Sibi Sankar To: Rakesh Pillai Subject: Re: [PATCH v6] arm64: dts: qcom: sc7180: Add WCN3990 WLAN module device node In-Reply-To: <1580822300-4491-1-git-send-email-pillair@codeaurora.org> References: <1580822300-4491-1-git-send-email-pillair@codeaurora.org> Message-ID: <0ae6edd12623c35600d598a219322f44@codeaurora.org> X-Sender: sibis@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200206_224110_720391_5A62AB08 X-CRM114-Status: GOOD ( 16.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-arm-msm-owner@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hey Rakesh, On 2020-02-04 18:48, Rakesh Pillai wrote: > Add device node for the ath10k SNOC platform driver probe > and add resources required for WCN3990 on sc7180 soc. > > Signed-off-by: Rakesh Pillai > --- > arch/arm64/boot/dts/qcom/sc7180-idp.dts | 5 +++++ > arch/arm64/boot/dts/qcom/sc7180.dtsi | 27 > +++++++++++++++++++++++++++ > 2 files changed, 32 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts > b/arch/arm64/boot/dts/qcom/sc7180-idp.dts > index 388f50a..167f68ac 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts > +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts > @@ -287,6 +287,11 @@ > vdda-pll-supply = <&vreg_l4a_0p8>; > }; > > +&wifi { > + status = "okay"; I can see that wlan needs to add the SIDs 0xc2, 0xc3 as well. Without that I expect wlan will not come up. > + qcom,msa-fixed-perm; are you sure this is required when used in conjunction with coreboot? > +}; > + > /* PINCTRL - additions to nodes defined in sc7180.dtsi */ > > &qspi_clk { > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi > b/arch/arm64/boot/dts/qcom/sc7180.dtsi > index 8011c5f..e3e8610 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > @@ -75,6 +75,11 @@ > reg = <0x0 0x80900000 0x0 0x200000>; > no-map; > }; > + > + wlan_fw_mem: memory@93900000 { > + reg = <0 0x93900000 0 0x200000>; > + no-map; > + }; > }; > > cpus { > @@ -1490,6 +1495,28 @@ > > #freq-domain-cells = <1>; > }; > + > + wifi: wifi@18800000 { > + compatible = "qcom,wcn3990-wifi"; > + reg = <0 0x18800000 0 0x800000>; > + reg-names = "membase"; > + iommus = <&apps_smmu 0xc0 0x1>; > + interrupts = > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + ; > + memory-region = <&wlan_fw_mem>; > + status = "disabled"; > + }; > }; > > thermal-zones { -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel