From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88235C31E40 for ; Mon, 12 Aug 2019 14:08:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 578D9206A2 for ; Mon, 12 Aug 2019 14:08:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NenLJekM"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="k/90Q60f"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="k/90Q60f" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 578D9206A2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7W3GRtTOqCb4bj91Y32gfPLnhgPswxazddXirKLrxvE=; b=NenLJekMaKopZa8dDpm4YIyOK zqwCmaWhTm2sKMwvdXU1IHVBBPekq0nIxLHPuzBUAetHc63pViAAaSKXOUK/dzPkWJL69v0VWSfaw SiP020D9ISGP0uCzHaR3fGEYYvuiFgJ1VP4qMXsAZmhFV2B0ZGf+PPzHxDCjywmyglenLOvItrub5 KA76bcsgI0J3puSjS2qNcvdMQ1lk3CD3+LMh3TjPyYZAcvuyJ9Y8o5nhgFHnQ3+wEJeB/C+o2I7iw AYZ2+jKkJJ1ZcDOETu1qBDiMHi95qCiEJ4ru/WSCoOct67p6oHKr5qDi/F3GMqS3k607OHqSvTaFA eNCWk09wA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hxAzq-0004VR-EM; Mon, 12 Aug 2019 14:08:26 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hxAzT-0004J2-6e for linux-arm-kernel@lists.infradead.org; Mon, 12 Aug 2019 14:08:04 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id E74E560A24; Mon, 12 Aug 2019 14:07:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1565618879; bh=fw94u81eThzgsYjSU+Z+n8fIRd2urq/T8GikyE6yGe8=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=k/90Q60fihwdPr79qce5GK9eZ4A+kMWVrODU6BZhwMQdTH3BNr0PtGmQE6VOSM7n1 I8EZt7nHl6ARtj1UFUcqtsBiP9V1Z/r5yeFhzgmdBcpnoZuh4sMmNiH9T1mZJq34s2 XqWj6yRBEBm+AlqWEXYPC+d2CWMDmVzAo8o/LX8w= Received: from [10.226.58.28] (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: jhugo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 7BE5C60709; Mon, 12 Aug 2019 14:07:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1565618879; bh=fw94u81eThzgsYjSU+Z+n8fIRd2urq/T8GikyE6yGe8=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=k/90Q60fihwdPr79qce5GK9eZ4A+kMWVrODU6BZhwMQdTH3BNr0PtGmQE6VOSM7n1 I8EZt7nHl6ARtj1UFUcqtsBiP9V1Z/r5yeFhzgmdBcpnoZuh4sMmNiH9T1mZJq34s2 XqWj6yRBEBm+AlqWEXYPC+d2CWMDmVzAo8o/LX8w= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 7BE5C60709 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=jhugo@codeaurora.org Subject: Re: next/master boot: 265 boots: 17 failed, 184 passed with 64 offline (next-20190730) To: Linus Walleij , Timur Tabi References: <5d403574.1c69fb81.14163.65d3@mx.google.com> <20190730134115.GE4264@sirena.org.uk> <5d41b01a.1c69fb81.84578.a0bc@mx.google.com> From: Jeffrey Hugo Message-ID: <0afc2e55-5346-9925-8e4d-d4485f1d3898@codeaurora.org> Date: Mon, 12 Aug 2019 08:07:57 -0600 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190812_070803_416088_877DC21C X-CRM114-Status: GOOD ( 16.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kernel Build Reports Mailman List , Lina Iyer , Stephen Boyd , Mark Brown , Bjorn Andersson , Lee Jones , Linux ARM Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 8/3/2019 2:42 AM, Linus Walleij wrote: > On Fri, Aug 2, 2019 at 4:51 AM Timur Tabi wrote: >> On 7/31/19 12:58 PM, Jeffrey Hugo wrote: >>> >>> static int gpiochip_alloc_valid_mask(struct gpio_chip *gc) >>> { >>> if (IS_ENABLED(CONFIG_OF_GPIO)) >>> gc->need_valid_mask = of_gpio_need_valid_mask(gc); >>> if (!gc->need_valid_mask) >>> return 0; >> >> So this seems wrong on a system with OF and ACPI. It assumes that OF >> takes priority over ACPI if both are enabled, and that's not true in >> general. If anything, it's the other way around. >> >> IS_ENABLED(CONFIG_OF_GPIO) is not the correct test to see if OF should >> be used. I think this should be replaced with the OF equivalent of >> has_acpi_companion(), but even that might not be enough. Basically, >> of_gpio_need_valid_mask() should return three values, 0 = don't need it, >> 1 = does need it, -1 = gpio info is not in OF. > > You're absolutely right. > > Sboyd hacked up a patch to that effect and I applied it. > > I haven't heard if QDF2400 is working again but I'd love to know! > Sorry, was on vacation. Per kernelci[1], looks like things are working. [1] https://kernelci.org/boot/qcom-qdf2400/ -- Jeffrey Hugo Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel