From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54B14C4360F for ; Thu, 28 Feb 2019 15:51:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 244FA218AE for ; Thu, 28 Feb 2019 15:51:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NAImHrB8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 244FA218AE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=c18dWuciEDhPncb3zyWYvGEELsYHHlwSkI8/iZS891c=; b=NAImHrB8E6J5no iKeVd0LJW+od+Ll0N6N2aNg/vVSMO8DBOSbm0cCwbXlF1J7jhXVI1aQe74BHcKSibLuvRSKpgz8eH SUcZS3uJe3g3sv4/P9qxNPNyUaj/mLupEmexDhxZ16gjR7dlhKVWoOGjevmRlwa2mXCdeA40ev7oH bmWVY8lQTsQbSqNXgNH9MbJsU1WyoZdavaV5DeGRpD+hpELXGFw8TWIuID2QgvTbmOSs5GuUxadZh y4p49J0aEwnqhBOR/lyiSbuGI/uYPAkygY6yK+6OnY/w+ie0HIi3nwlXEQwmPAy5dcjlt73Zmk9cj wsG4vS4uzrK6U96o8sCg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gzNyU-0000gf-Uk; Thu, 28 Feb 2019 15:51:54 +0000 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70] helo=foss.arm.com) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gzNyR-0000fv-Sd for linux-arm-kernel@lists.infradead.org; Thu, 28 Feb 2019 15:51:53 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8D1CFA78; Thu, 28 Feb 2019 07:51:49 -0800 (PST) Received: from [10.1.196.72] (e119884-lin.cambridge.arm.com [10.1.196.72]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 31C143F720; Thu, 28 Feb 2019 07:51:47 -0800 (PST) Subject: Re: [PATCH v5 00/23] Unify vDSOs across more architectures To: Arnd Bergmann References: <20190222122430.21180-1-vincenzo.frascino@arm.com> From: Vincenzo Frascino Message-ID: <0b7d7219-cc7f-9ef1-7945-b609b2f36597@arm.com> Date: Thu, 28 Feb 2019 15:51:45 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190228_075151_927695_887F48E1 X-CRM114-Status: GOOD ( 22.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch , Shuah Khan , Rasmus Villemoes , Catalin Marinas , Daniel Lezcano , Will Deacon , Russell King , Ralf Baechle , Mark Salyzyn , Paul Burton , Dmitry Safonov <0x7f454c46@gmail.com>, Thomas Gleixner , Peter Collingbourne , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Arnd, On 28/02/2019 13:54, Arnd Bergmann wrote: > On Thu, Feb 28, 2019 at 1:42 PM Vincenzo Frascino > wrote: >> >> On 28/02/2019 12:38, Arnd Bergmann wrote: >>> On Thu, Feb 28, 2019 at 1:09 PM Vincenzo Frascino >>> wrote: >>>> >>>> thank you for testing my code. >>>> >>>> On 28/02/2019 11:40, Arnd Bergmann wrote: >>>>> On Fri, Feb 22, 2019 at 1:25 PM Vincenzo Frascino >>>>> wrote: >>>>> ^ >>>>> >>>>> I think this is all harmless, but we need to limit the set of header files >>>>> that can be included indirectly when compiling the vdso in arm32 mode. >>>>> >>>> >>>> I agree with you on the principle, but I am unable to replicate the warnings. >>>> Did you make any customization to the default defconfig? What is the top >>>> commit-id you have on your tree? >>> >>> I observed this on top of v5.0-rc7 earlier, and have since rebased to >>> today's linux-next, where it still happens with the regular 'make defconfig', >>> on all compiler versions I have (4.8 through 8.1). >>> >> >> Thanks, I will try to rebase my patches on linux-next and see if I can reproduce it. > > I just found a related issue: when CONFIG_CPU_BIG_ENDIAN is > set, everything breaks in the compat vdso because of the included > arm64 headers in arm32 code. That should be easier to reproduce. > For the moment, I'm using this patch: > > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -103,7 +103,7 @@ config ARM64 > select GENERIC_STRNLEN_USER > select GENERIC_TIME_VSYSCALL > select GENERIC_GETTIMEOFDAY > - select GENERIC_COMPAT_VDSO > + select GENERIC_COMPAT_VDSO if !CPU_BIG_ENDIAN > select HANDLE_DOMAIN_IRQ > select HARDIRQS_SW_RESEND > select HAVE_PCI > > Thanks for this, but I can't still reproduce the issue. I rebased my patches on: commit 42fd8df9d1d9c83046226e771a4f5f3d05a706ff (tag: next-20190228, linux-next/master) and enabled CONFIG_CPU_BIG_ENDIAN. > Arnd > -- Regards, Vincenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel