From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B72BEC43381 for ; Mon, 1 Apr 2019 21:43:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 88E3C2070B for ; Mon, 1 Apr 2019 21:43:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qLZB5uWJ"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="Kr2gi4Um" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 88E3C2070B Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VgH00S6yUPLsVWWBEy8dQHgPz4x6k/Y/1OguWYisLQQ=; b=qLZB5uWJsSBBCE /MmXyf2Ya7N4fNLIuP0UqegggeDuInFWgiTaffhojelB1u3PUotOYtQ5tA//2nsWbEni5W7VCdZwn AOY5HPIOq/vuNPfz8ljnd6hhuksPkgSv18Jh+cx50OL/bLRJgPpUbYCNJtu0PXok8JtGxf02GZ0Ya 2/v0hXT3zXLiXg2wLzdyJRrVgycap6tekXp53G30OZc5cNuvGCJFBIl5asd3E7Hvs0ptu7VWhyqAp JnUF5tEA5qr26f4gmQDj3qMsmv1U6DJ/v747HzmGHBxFXEbjqPBmeV9wLfBggUt4gFG0WvZ0Uq46R yQ9WcY1Djp4escmVKgTw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hB4iF-0004TA-AU; Mon, 01 Apr 2019 21:43:27 +0000 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hB4iB-0004SQ-Sw for linux-arm-kernel@lists.infradead.org; Mon, 01 Apr 2019 21:43:25 +0000 Received: by mail-pg1-x543.google.com with SMTP id b12so5440988pgk.0 for ; Mon, 01 Apr 2019 14:43:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=mmqtOMVvscb+HQxFUwrIPhKliYEQlR+drfZoUODE5cw=; b=Kr2gi4UmPseexza2lNrI5lAWb6eeHVzrzpiPdNzyxivyINGumWHm//CwtR9udn8zDV hckm1c38RnVwrch2jSpFJqQ4VLUcrY4aPi5M6bky5Lvw47MRuCcx3QyQ29uQUE3y7mn6 VojRcDbw3KuFEYLRix5qNM84Hg0WTrcaPBkyQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=mmqtOMVvscb+HQxFUwrIPhKliYEQlR+drfZoUODE5cw=; b=YHjFXNo6N2rO2JQoCtYafz3VfoudeR0Mga5SVBoBaZOLrxqTnCWjdbx7B/x/XedvW/ 7WZsPp9ix9nAEcyvxJkNaZsNYd/bx0OhUusTIRRWuYmN0No8f+59Q2070vawv91PeEip YijRhNG7sxVnjy8X/rjeCqvZh048CR2cFL4xVNrhRVOW/s/WgU4FkYoi6/V4Wlosdwwe 0d5Ph0byujJcgJEOPY8RZdX5pFjORNy1NoIMcFCnr1dYiPz0BKPBWM26cTwVN7KoR0mJ BgvS+NlwTEpUa2y0WCG3vD3cdv+uvjV4D2lgIXx5QuGFX73a3cwkk5zKKflxIOLL0UHf 52Vw== X-Gm-Message-State: APjAAAVNJpXQjgfzJV4L2EpOq03bd0iJBNwawkIGKEGYhEZt4w+Mbq3s xtcAq22uSiGe35Jw6aC0OyhCOA== X-Google-Smtp-Source: APXvYqxVksZDeqtoKHcY5c1W3H+yaf2/gWs21lQ6Y+aA10s7/9HUYc7h3/a8RF7sQ9REgBB8UX8xMQ== X-Received: by 2002:a65:6289:: with SMTP id f9mr50765840pgv.380.1554155002556; Mon, 01 Apr 2019 14:43:22 -0700 (PDT) Received: from [10.136.8.252] ([192.19.228.250]) by smtp.gmail.com with ESMTPSA id q81sm19895229pfi.102.2019.04.01.14.43.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 01 Apr 2019 14:43:21 -0700 (PDT) Subject: Re: [PATCH v5 6/8] dt-bindings: i2c: iproc: add "brcm, iproc-nic-i2c" compatible string To: Wolfram Sang References: <20190214175725.60462-1-ray.jui@broadcom.com> <20190214175725.60462-7-ray.jui@broadcom.com> <20190327222439.GC15396@kunai> From: Ray Jui Message-ID: <0b97cacd-9bf4-135a-b2ee-1d51ab380b1c@broadcom.com> Date: Mon, 1 Apr 2019 14:43:17 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.0 MIME-Version: 1.0 In-Reply-To: <20190327222439.GC15396@kunai> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190401_144323_940921_EAE8ECEF X-CRM114-Status: GOOD ( 16.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Rayagonda Kokatanur , linux-kernel@vger.kernel.org, Rob Herring , bcm-kernel-feedback-list@broadcom.com, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Wolfram, On 3/27/2019 3:24 PM, Wolfram Sang wrote: > >> Update iProc I2C binding document to add new compatible string >> "brcm,iproc-nic-i2c". Optional property "brcm,ape-hsls-addr-mask" is >> also added that allows configuration of the host view into the APE's >> address for "brcm,iproc-nic-i2c" > > I don't know the platform, but wouldn't it be more DT-like to describe > the APE in DT and derive the mask from that information? Custom bindings > with values which are directly poked into a register usually raise my > eyebrow. > Note APE is a co-processor that is not visible from the Linux running from the host processor. "brcm,iproc-nic-i2c" here is introduced to allow the I2C port from APE to be completely owned by the host CPU, to meet the requirement of certain use cases. At the same time, the control of the I2C port from APE will be disabled. The "brcm,ape-hsls-addr-mask" defines the address translation and be programmed into some configuration registers to allow the host to directly access the I2C registers of APE. Note those configuration registers are owned by the host, and that address is not APE's address space nor the host is intending to take over the control of APE. Therefore, I think it makes way more sense to use an address mask type of DT property here. Thanks, Ray _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel