From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5F9EC433B4 for ; Tue, 20 Apr 2021 14:13:15 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 195B6613B4 for ; Tue, 20 Apr 2021 14:13:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 195B6613B4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=walle.cc Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+VCJiEke0KncVQNBG7oHVwWSDbHytUmox3DB9BmhGo4=; b=gVDAnzg4QNqWd4gxXbc0msxyd BZtowy2rChVGOP0zYwcZZd5jIzypbuDxNwcUKQ8Kir2ix7zuf//e6FmKdUa3Q7b2BgoqPK8o/g+sN q9ZKpFx2c3Ih3UxJMkI8mRQA10SSAK+8iQM2qqKwDQiv/dUuUNhWArGOTfWZUCivcgoOuANFElHbk cg9CrAO0arvvpMgkGpLHVdmeFhmOfF5iOJ0Nx/uWmGuaXfXdwWCXtRIMTAG2fqwaj1ZLjlmx7CaKf 3MNeNKa57z1TuRNrJSHHIr2egPrjWMIKHioggLMa/JXPlU4F7IBnuqPYuh/SkVE9tWiSD/7krUV/S 0RIwSEvKQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lYr5N-00CIxz-0F; Tue, 20 Apr 2021 14:10:41 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lYr5L-00CIxr-0R for linux-arm-kernel@desiato.infradead.org; Tue, 20 Apr 2021 14:10:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Message-ID:References:In-Reply-To: Subject:Cc:To:From:Date:Content-Transfer-Encoding:Content-Type:MIME-Version: Sender:Reply-To:Content-ID:Content-Description; bh=gZzdrVgE6rVEqETqHd8rICoxokCvYVI1LWiUV3nczwY=; b=VEgbOfTVTxysYhEcjx4XdPIoV4 PIHESKeMGHFPFr63FcDsQcl2wPvnbL9X+svHpBholhVrXIny/uysoQpXN7S9UdTbr+8mZLpc+pL0Q MbvqvQdDbxlNp887wRqCC1KAoa1Wgfzh3Xl/MuHUFXdBfKAEJGjT5314EKb+5op3jirq2BUypvhKS hg8blAXgca0jSvPXZL2g9JznfEDEs2LtO8eVWTCtUcZrUmRAp4znw69P0ucho9E9Ur4t+ez7blxCV 0u9i/Yo0pHnyxv7LIHTBpwr6Zk5Yp23lE3BhQHnAr2mTS7d7dU37GVVLOHaJ+MCgHQIc9Uk/l30mr k7/bxFUA==; Received: from ssl.serverraum.org ([176.9.125.105]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lYr5I-00CBHr-7l for linux-arm-kernel@lists.infradead.org; Tue, 20 Apr 2021 14:10:37 +0000 Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id 0AC6E22249; Tue, 20 Apr 2021 16:10:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1618927834; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gZzdrVgE6rVEqETqHd8rICoxokCvYVI1LWiUV3nczwY=; b=cBJj9IsnVoI7b/0muDZcpHZqc3LniZ3iMVIeIikjGvHDpK7tINA/9wf5YXiBKC5wIPvUKh M9aKOmcv2URowTX4Aix2zhYd4BtWcv3VvOMJkHoPl9tdTj3La9JvMlblmLKJy9OB3ArGBh BdVn4VeZ8hENRNVkvb0Vtlq9iurmfMo= MIME-Version: 1.0 Date: Tue, 20 Apr 2021 16:10:34 +0200 From: Michael Walle To: Vladimir Oltean Cc: Jakub Kicinski , "David S. Miller" , netdev@vger.kernel.org, Po Liu , Claudiu Manoil , Alex Marginean , Rob Herring , Shawn Guo , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Russell King - ARM Linux admin , Andrew Lunn , Vladimir Oltean Subject: Re: [PATCH net-next 0/5] Flow control for NXP ENETC In-Reply-To: <20210420140433.hajuvfiz4humhhkt@skbuf> References: <20210416234225.3715819-1-olteanv@gmail.com> <20210420140433.hajuvfiz4humhhkt@skbuf> User-Agent: Roundcube Webmail/1.4.11 Message-ID: <0bf4aa61dea7be0723fda2d8597644ad@walle.cc> X-Sender: michael@walle.cc X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210420_071036_466737_71596446 X-CRM114-Status: GOOD ( 23.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Vladimir, Am 2021-04-20 16:04, schrieb Vladimir Oltean: > On Tue, Apr 20, 2021 at 03:27:24PM +0200, Michael Walle wrote: >> Hi Vladimir, >> >> Am 2021-04-17 01:42, schrieb Vladimir Oltean: >> > From: Vladimir Oltean >> > >> > This patch series contains logic for enabling the lossless mode on the >> > RX rings of the ENETC, and the PAUSE thresholds on the internal FIFO >> > memory. >> > >> > During testing it was found that, with the default FIFO configuration, >> > a sender which isn't persuaded by our PAUSE frames and keeps sending >> > will cause some MAC RX frame errors. To mitigate this, we need to ensure >> > that the FIFO never runs completely full, so we need to fix up a setting >> > that was supposed to be configured well out of reset. Unfortunately this >> > requires the addition of a new mini-driver. >> >> What happens if the mini driver is not enabled? Then the fixes aren't >> applied and bad things happen (now with the addition of flow control), >> right? >> >> I'm asking because, if you have the arm64 defconfig its not enabled. >> >> shouldn't it be something like: >> >> diff --git a/drivers/net/ethernet/freescale/enetc/Kconfig >> b/drivers/net/ethernet/freescale/enetc/Kconfig >> index d88f60c2bb82..cdc0ff89388a 100644 >> --- a/drivers/net/ethernet/freescale/enetc/Kconfig >> +++ b/drivers/net/ethernet/freescale/enetc/Kconfig >> @@ -2,7 +2,7 @@ >> config FSL_ENETC >> tristate "ENETC PF driver" >> depends on PCI && PCI_MSI >> - depends on FSL_ENETC_IERB || FSL_ENETC_IERB=n >> + select FSL_ENETC_IERB >> select FSL_ENETC_MDIO >> select PHYLINK >> select PCS_LYNX > > Yes, ideally the IERB driver and the ENETC PF driver should be built in > the same way, or the IERB driver can be built-in and the PF driver can > be module. I don't know how to express this using Kconfig, sorry. With the small patch above it is: FSL_ENETC=m -> FSL_ENETC_IERB = m or y FSL_ENETC=y -> FSL_ENETC_IERB = y FSL_ENETC=n -> FSL_ENETC_IERB = m,y or n Will you fix it? Should I prepare a patch? -michael _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel