From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 75EFBC636CD for ; Mon, 30 Jan 2023 21:45:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=P/AMthjo5mz8tcAspYrKFJoodLDKLmzkMZXgAflIm7I=; b=j4zQyIMFxlVeeD fIC86iU7q0gAuWur3Gs+jtViGrVBmhQmXtQnmBKBFrxmputALUHm/dWjLTiKc1IgryeiEGNMLQHva oOnAI3lBPjk7jO9XJonctfSpO63dD48VkZi5DTdc9LFF4ifIEouPf2IePlR+OZ5xKL9R+sbY94V3q BM99cnjbW0USIHWei3SujcsOQqhevJOIu2mMA4VM9lyAAk0BS/0XYrUzvfL3wVBCXVsXjJyzM/0pK LE11XjGkpxboncqIMyFmCzGt/zQudgPciV71IuPWnwcobNN3mXW/iubSHiOjfN4kJ/5+HrFVyuvkn TEtElRfnuADHxtKqMKjQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pMbwG-005WkW-0y; Mon, 30 Jan 2023 21:43:44 +0000 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pMbwD-005Wjj-8E for linux-arm-kernel@lists.infradead.org; Mon, 30 Jan 2023 21:43:42 +0000 Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 30ULPRQ7019525; Mon, 30 Jan 2023 21:43:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=J9CFGVL6rsoTrkTF9qPIzObggqcrRWiKnHc9DU+7ZE4=; b=WEIK9zmNlP1nvCtp3g6RtjTwBY9V0/TW7zeRSTFjp0AifK/SyoqC9DAbSW+TEaqW/6Zl W50hSGosGNnm9Z0ch+QTRjxlvkUABksuVUZx36wEo03tYRUXmPVdstwVTDu7yAEMeHBn JAHfNdjsd68gtgO/IMQ/dmnXMMSO1FfVHyAawC5L02+47M6wSPX62qwgRf+huHf3x4Zs nB6xGlI6kZTA7pTVurW0Ma20XgYYulybdsY4zy36TTiiG3KgLGpIBt11+eUzXC62imBw +CUPakto6nBQRJ+OS+ulV81AAJxzzU4wseg+VPDv4sfiAybRgaS7V/nlLCmx3xGz/Qa6 tw== Received: from nasanppmta03.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3ncw0g4kra-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 30 Jan 2023 21:43:30 +0000 Received: from nasanex01b.na.qualcomm.com (nasanex01b.na.qualcomm.com [10.46.141.250]) by NASANPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 30ULhT6E012092 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 30 Jan 2023 21:43:29 GMT Received: from [10.134.67.48] (10.80.80.8) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Mon, 30 Jan 2023 13:43:29 -0800 Message-ID: <0d201cd9-320a-173e-1f90-5d6b3fc373a9@quicinc.com> Date: Mon, 30 Jan 2023 13:43:28 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v9 10/27] gunyah: rsc_mgr: Add VM lifecycle RPC Content-Language: en-US To: Srivatsa Vaddagiri CC: Bjorn Andersson , Alex Elder , Murali Nalajala , Trilok Soni , Carl van Schaik , Prakruthi Deepak Heragu , Dmitry Baryshkov , Arnd Bergmann , "Greg Kroah-Hartman" , Rob Herring , Krzysztof Kozlowski , Jonathan Corbet , Bagas Sanjaya , Catalin Marinas , Will Deacon , Marc Zyngier , Jassi Brar , Sudeep Holla , , , , , References: <20230120224627.4053418-1-quic_eberman@quicinc.com> <20230120224627.4053418-11-quic_eberman@quicinc.com> <20230125060929.GA3779774@quicinc.com> From: Elliot Berman In-Reply-To: <20230125060929.GA3779774@quicinc.com> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01b.na.qualcomm.com (10.46.141.250) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: zBERMXMths14wZs_iBcJVS40yuelQe__ X-Proofpoint-ORIG-GUID: zBERMXMths14wZs_iBcJVS40yuelQe__ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-01-30_17,2023-01-30_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 mlxscore=0 bulkscore=0 clxscore=1015 impostorscore=0 mlxlogscore=789 priorityscore=1501 spamscore=0 adultscore=0 lowpriorityscore=0 phishscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301300201 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230130_134341_330527_618B71A2 X-CRM114-Status: GOOD ( 13.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 1/24/2023 10:12 PM, Srivatsa Vaddagiri wrote: > * Elliot Berman [2023-01-20 14:46:09]: > >> +int gh_rm_vm_stop(struct gh_rm *rm, u16 vmid) >> +{ >> + struct gh_vm_stop_req req_payload = { >> + .vmid = cpu_to_le16(vmid), >> + }; >> + void *resp; >> + size_t resp_size; >> + int ret; >> + >> + ret = gh_rm_call(rm, GH_RM_RPC_VM_STOP, &req_payload, sizeof(req_payload), >> + &resp, &resp_size); > > Why not use gh_rm_common_vmid_call() here as well? > > return gh_rm_common_vmid_call(rm, GH_RM_RPC_VM_STOP, vmid); > > gh_vm_stop_req isn't the same as the common payload. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel