From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_ADSP_ALL, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0C9FC4740C for ; Mon, 9 Sep 2019 13:59:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7407921924 for ; Mon, 9 Sep 2019 13:59:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ayPzXZUY"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=amazon.com header.i=@amazon.com header.b="DWlYYA1/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7407921924 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=amazon.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/+5X5HMj7FaO3dPmtavCMfPcmvmxJ02JYePMlb94tWM=; b=ayPzXZUYO2Vv84SMSiqqqMLM1 PjOkzG3Pf4khqupEAEgkgKnSKHhEHWTODkB8brenrv57FqD/jRFx8wMA1M6UhDQ5Va1BYl4shorp3 YjYx63xNUub2CuXUW8D1y8kx69UfaxcpXumHkU3CU0uRcbYJ0UO0GG3I6Wu3+23VJ+/navgcMuR0m 2WzdHI9VoZWMH9IwDlDFdbMJYguMq6LO9or17HIhfVey/r+TpjGcjw61js5i16qTQ9tgFa+oZtJ6Z TwQ7CBjezp7ozSP3vno70kutvwpk5AiIBi0q/a7WS6pmxBBa5dUrg/FUcmNzR0LGrCjv4xWy4JDQT GeLok3Ohw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i7KCp-0001tg-NL; Mon, 09 Sep 2019 13:59:47 +0000 Received: from smtp-fw-33001.amazon.com ([207.171.190.10]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i7KCm-0001qx-0L for linux-arm-kernel@lists.infradead.org; Mon, 09 Sep 2019 13:59:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1568037583; x=1599573583; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=K42g/AFNMDx/RgjzKJBTKWAce5pXZj/ROym93HlBV/I=; b=DWlYYA1/6vPpZZkpJ74FLnfQgKJhMDFjSiytC4XYA9b66a4cOiEqdyY9 25DvBhdupkWhn35nvIiBQoyX7bU+KDNtpM+ZGuUZ208K7zLWaR3FX1pJ7 kX/mfXhitYOHc89MYeXynAGkY8zkl6fkbOUzVIKG/VBpN9lJ3KtGPU1MH A=; X-IronPort-AV: E=Sophos;i="5.64,484,1559520000"; d="scan'208";a="829304744" Received: from sea3-co-svc-lb6-vlan2.sea.amazon.com (HELO email-inbound-relay-2a-90c42d1d.us-west-2.amazon.com) ([10.47.22.34]) by smtp-border-fw-out-33001.sea14.amazon.com with ESMTP; 09 Sep 2019 13:59:14 +0000 Received: from EX13MTAUEA001.ant.amazon.com (pdx4-ws-svc-p6-lb7-vlan3.pdx.amazon.com [10.170.41.166]) by email-inbound-relay-2a-90c42d1d.us-west-2.amazon.com (Postfix) with ESMTPS id 0CCB1A1E19; Mon, 9 Sep 2019 13:59:12 +0000 (UTC) Received: from EX13D01EUB001.ant.amazon.com (10.43.166.194) by EX13MTAUEA001.ant.amazon.com (10.43.61.243) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 9 Sep 2019 13:59:12 +0000 Received: from [10.125.238.52] (10.43.160.27) by EX13D01EUB001.ant.amazon.com (10.43.166.194) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 9 Sep 2019 13:59:01 +0000 Subject: Re: [PATCH 3/3] arm64: alpine: select AL_POS To: Arnd Bergmann References: <1568020220-7758-1-git-send-email-talel@amazon.com> <1568020220-7758-4-git-send-email-talel@amazon.com> From: "Shenhar, Talel" Message-ID: <0d36f94d-596f-0ec7-6951-b097b5ee0d2d@amazon.com> Date: Mon, 9 Sep 2019 16:58:56 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Originating-IP: [10.43.160.27] X-ClientProxiedBy: EX13D23UWA002.ant.amazon.com (10.43.160.40) To EX13D01EUB001.ant.amazon.com (10.43.166.194) Precedence: Bulk X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190909_065944_098955_DEFB63EB X-CRM114-Status: GOOD ( 14.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , mjourdan@baylibre.com, Catalin Marinas , Linus Walleij , "linux-kernel@vger.kernel.org" , jonnyc@amazon.com, Mauro Carvalho Chehab , ronenk@amazon.com, Will Deacon , Benjamin Herrenschmidt , DTML , Maxime Ripard , Rob Herring , Santosh Shilimkar , Thomas Gleixner , hanochu@amazon.com, Linux ARM , barakw@amazon.com, hhhawa@amazon.com, gregkh , paul.kocialkowski@bootlin.com, Patrick Venture , Olof Johansson , David Miller , David Woodhouse Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/9/2019 4:45 PM, Arnd Bergmann wrote: > On Mon, Sep 9, 2019 at 12:17 PM Shenhar, Talel wrote: >> On 9/9/2019 12:40 PM, Arnd Bergmann wrote: >>> On Mon, Sep 9, 2019 at 11:14 AM Talel Shenhar wrote: >>>> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms >>>> index 4778c77..bd86b15 100644 >>>> --- a/arch/arm64/Kconfig.platforms >>>> +++ b/arch/arm64/Kconfig.platforms >>>> @@ -25,6 +25,7 @@ config ARCH_SUNXI >>>> config ARCH_ALPINE >>>> bool "Annapurna Labs Alpine platform" >>>> select ALPINE_MSI if PCI >>>> + select AL_POS >>>> help >>>> This enables support for the Annapurna Labs Alpine >>>> Soc family. >>> Generally I think this kind of thing should go into the defconfig >>> rather than being hard-selected. There might be users that >>> want to not enable the driver. >> The reason for selecting it is because this is a driver that we will >> always want for ARCH_ALPINE. > Can you put the exact requirement (other than "we want this") > in the changelog text then? It's still not clear to me what breaks > without this driver. > > Arnd Its not that something will get broken. its error event detector for POS events which allows seeing bad accesses to registers. What is the general rule of which configs to put under select and which under defconfig? I was thinking that "general" SoC support is good under select - those things that we always want. And specific features, e.g. RAID support or features that supported only on specific HW shall go under defconfig. Similar, I see ARCH_LAYERSCAPE selecting EDAC_SUPPORT. Will love to hear the general rule for select vs defconfig. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel