From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69E86C48BE5 for ; Thu, 17 Jun 2021 08:24:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3CCC861400 for ; Thu, 17 Jun 2021 08:24:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3CCC861400 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:CC:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uQ6TLxxtPWTl5ta6xarE4NjyR3jGPE8iQWlkE6O99b0=; b=vmMRT3FGBLjf0HwIHJbKB/N4vD 1zGQVIrIy+fvd7oKX8R52vTG+ZcX3fX/yU8jHwlKTJ4RhfXEB0dZmCYbWhM9z8h27MhAme6wFIss3 CoslU0qSl+DSSK0LWfZHPsyptSVOE9yv37NpaCWoXtBi0axOzn/jF+LgcNo4gkiiEWE93CGhO9IOn luYrjOp4fuqOTTQ+Z25bceZTbz6cenKEA9KUjuPFsz+TluK1wwuNS10rVr23YTbQS8Flu0g1c7x6J yn4gmjoAnNGk7EnN3JrFxuwGu5YQ+wP1qP8RwK5K2JPcMfhUZT6YnFi4dWE5SMe1P7IBazpqBW0WZ WYeHXIMw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltnIn-009TJq-9v; Thu, 17 Jun 2021 08:23:05 +0000 Received: from szxga08-in.huawei.com ([45.249.212.255]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltnIi-009TIw-IF for linux-arm-kernel@lists.infradead.org; Thu, 17 Jun 2021 08:23:02 +0000 Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.55]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4G5FKp5jXQz1BGTR; Thu, 17 Jun 2021 16:17:50 +0800 (CST) Received: from dggpemm500023.china.huawei.com (7.185.36.83) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 17 Jun 2021 16:22:53 +0800 Received: from [10.174.187.128] (10.174.187.128) by dggpemm500023.china.huawei.com (7.185.36.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Thu, 17 Jun 2021 16:22:52 +0800 Subject: Re: [PATCH v6 1/4] KVM: arm64: Introduce cache maintenance callbacks for guest stage-2 To: Marc Zyngier CC: Will Deacon , Quentin Perret , Alexandru Elisei , , , , , Catalin Marinas , James Morse , Julien Thierry , Suzuki K Poulose , Gavin Shan , , , References: <20210616095200.38008-1-wangyanan55@huawei.com> <20210616095200.38008-2-wangyanan55@huawei.com> <87eed2lzcc.wl-maz@kernel.org> <8340be12-cc80-8c2a-3597-ecba05eaf35a@huawei.com> <87o8c4dikn.wl-maz@kernel.org> From: "wangyanan (Y)" Message-ID: <0dced974-b507-ce48-b89d-344d41a02418@huawei.com> Date: Thu, 17 Jun 2021 16:22:51 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <87o8c4dikn.wl-maz@kernel.org> Content-Language: en-US X-Originating-IP: [10.174.187.128] X-ClientProxiedBy: dggeme707-chm.china.huawei.com (10.1.199.103) To dggpemm500023.china.huawei.com (7.185.36.83) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210617_012301_028986_E710F913 X-CRM114-Status: GOOD ( 21.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2021/6/17 16:03, Marc Zyngier wrote: > On Thu, 17 Jun 2021 07:48:29 +0100, > "wangyanan (Y)" wrote: >> Hi Marc, >> >> On 2021/6/16 21:21, Marc Zyngier wrote: >>> Hi Yanan, >>> >>> On Wed, 16 Jun 2021 10:51:57 +0100, >>> Yanan Wang wrote: >>>> To prepare for performing guest CMOs in the fault handlers in pgtable.c, >>>> introduce two cache maintenance callbacks in struct kvm_pgtable_mm_ops. >>>> >>>> The new callbacks are specific for guest stage-2, so they will only be >>>> initialized in 'struct kvm_pgtable_mm_ops kvm_s2_mm_ops'. >>>> >>>> Signed-off-by: Yanan Wang >>>> --- >>>> arch/arm64/include/asm/kvm_pgtable.h | 7 +++++++ >>>> 1 file changed, 7 insertions(+) >>>> >>>> diff --git a/arch/arm64/include/asm/kvm_pgtable.h b/arch/arm64/include/asm/kvm_pgtable.h >>>> index c3674c47d48c..302eca32e0af 100644 >>>> --- a/arch/arm64/include/asm/kvm_pgtable.h >>>> +++ b/arch/arm64/include/asm/kvm_pgtable.h >>>> @@ -44,6 +44,11 @@ typedef u64 kvm_pte_t; >>>> * in the current context. >>>> * @virt_to_phys: Convert a virtual address mapped in the current context >>>> * into a physical address. >>>> + * @flush_dcache: Clean data cache for a guest page address range before >>>> + * creating the corresponding stage-2 mapping. >>> Please don't reintroduce the word 'flush'. We are really trying to >>> move away from it as it doesn't describe what we want to do. >> I agree with this. I intended to make the names short and laconic, but this >> missed the information about the callback's actual behaviors. >>> Here this >>> should be 'clean_invalidate_dcache' which, despite being a mouthful, >>> describe accurately what we expect it to do. >> Sure, I will change the name as you suggested. >>> The comment is also missing the invalidate part, and we shouldn't >>> assume that this is only used for S2 mapping. >> Ok, will refine the comment. I think something like"Clean and invalidate the >> date cache for the specified memory address range" may be generic enough. >>>> + * @flush_icache: Invalidate instruction cache for a guest page address >>>> + * range before creating or updating the corresponding >>>> + * stage-2 mapping. >>> Same thing here; this should be 'invalidate_icache', and the comment >>> cleaned up. >> Thanks, I will also correct this part. >> >> Besides the callback names and comments, is there anything else that still >> needs some adjustment in the other three patches? :) > It looks pretty good so far, much nicer than the previous versions. > > I have a small nit on the last patch, which should be dead easy to > address. I'm currently running a bunch of tests, hopefully nothing bad > will come out of it. > > If you respin it shortly, that nothing fails, and unless someone > shouts, I'll queue it for -next. It would be nice, thanks! I will address the nit and respin the series soon. Thanks, Yanan . > Thanks, > > M. > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel