From: Chanwoo Choi <cwchoi00@gmail.com>
To: Arnd Bergmann <arnd@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Tomasz Figa <tomasz.figa@gmail.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>
Cc: linux-kernel@vger.kernel.org, Ben Dooks <ben-linux@fluff.org>,
Simtec Linux Team <linux@simtec.co.uk>,
Arnd Bergmann <arnd@arndb.de>,
Alim Akhtar <alim.akhtar@samsung.com>,
linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH 11/21] clk: remove s3c24xx driver
Date: Sat, 22 Oct 2022 20:50:46 +0900 [thread overview]
Message-ID: <0e0eff12-d8ea-72e9-d135-4259dda9a750@gmail.com> (raw)
In-Reply-To: <20221021203329.4143397-11-arnd@kernel.org>
Hi Arnd,
On 22. 10. 22. 05:27, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The s3c24xx platform is gone, so the clk driver can be removed as
> well.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> MAINTAINERS | 1 -
> drivers/clk/samsung/Kconfig | 32 --
> drivers/clk/samsung/Makefile | 4 -
> drivers/clk/samsung/clk-s3c2410-dclk.c | 440 ---------------------
> drivers/clk/samsung/clk-s3c2410.c | 446 ----------------------
> drivers/clk/samsung/clk-s3c2412.c | 254 ------------
> drivers/clk/samsung/clk-s3c2443.c | 438 ---------------------
> include/linux/platform_data/clk-s3c2410.h | 19 -
> 8 files changed, 1634 deletions(-)
> delete mode 100644 drivers/clk/samsung/clk-s3c2410-dclk.c
> delete mode 100644 drivers/clk/samsung/clk-s3c2410.c
> delete mode 100644 drivers/clk/samsung/clk-s3c2412.c
> delete mode 100644 drivers/clk/samsung/clk-s3c2443.c
> delete mode 100644 include/linux/platform_data/clk-s3c2410.h
(snip)
I think that it should remove the pll code related to s3c24xx as following:
diff --git a/drivers/clk/samsung/clk-pll.c b/drivers/clk/samsung/clk-pll.c
index fe383471c5f0..0daea2aadce4 100644
--- a/drivers/clk/samsung/clk-pll.c
+++ b/drivers/clk/samsung/clk-pll.c
@@ -1061,48 +1061,6 @@ static void samsung_s3c2410_upll_disable(struct clk_hw *hw)
samsung_s3c2410_pll_enable(hw, 7, false);
}
-static const struct clk_ops samsung_s3c2410_mpll_clk_min_ops = {
- .recalc_rate = samsung_s3c2410_pll_recalc_rate,
- .enable = samsung_s3c2410_mpll_enable,
- .disable = samsung_s3c2410_mpll_disable,
-};
-
-static const struct clk_ops samsung_s3c2410_upll_clk_min_ops = {
- .recalc_rate = samsung_s3c2410_pll_recalc_rate,
- .enable = samsung_s3c2410_upll_enable,
- .disable = samsung_s3c2410_upll_disable,
-};
-
-static const struct clk_ops samsung_s3c2440_mpll_clk_min_ops = {
- .recalc_rate = samsung_s3c2440_mpll_recalc_rate,
- .enable = samsung_s3c2410_mpll_enable,
- .disable = samsung_s3c2410_mpll_disable,
-};
-
-static const struct clk_ops samsung_s3c2410_mpll_clk_ops = {
- .recalc_rate = samsung_s3c2410_pll_recalc_rate,
- .enable = samsung_s3c2410_mpll_enable,
- .disable = samsung_s3c2410_mpll_disable,
- .round_rate = samsung_pll_round_rate,
- .set_rate = samsung_s3c2410_pll_set_rate,
-};
-
-static const struct clk_ops samsung_s3c2410_upll_clk_ops = {
- .recalc_rate = samsung_s3c2410_pll_recalc_rate,
- .enable = samsung_s3c2410_upll_enable,
- .disable = samsung_s3c2410_upll_disable,
- .round_rate = samsung_pll_round_rate,
- .set_rate = samsung_s3c2410_pll_set_rate,
-};
-
-static const struct clk_ops samsung_s3c2440_mpll_clk_ops = {
- .recalc_rate = samsung_s3c2440_mpll_recalc_rate,
- .enable = samsung_s3c2410_mpll_enable,
- .disable = samsung_s3c2410_mpll_disable,
- .round_rate = samsung_pll_round_rate,
- .set_rate = samsung_s3c2410_pll_set_rate,
-};
-
/*
* PLL2550x Clock Type
*/
@@ -1530,24 +1488,6 @@ static void __init _samsung_clk_register_pll(struct samsung_clk_provider *ctx,
else
init.ops = &samsung_pll46xx_clk_ops;
break;
- case pll_s3c2410_mpll:
- if (!pll->rate_table)
- init.ops = &samsung_s3c2410_mpll_clk_min_ops;
- else
- init.ops = &samsung_s3c2410_mpll_clk_ops;
- break;
- case pll_s3c2410_upll:
- if (!pll->rate_table)
- init.ops = &samsung_s3c2410_upll_clk_min_ops;
- else
- init.ops = &samsung_s3c2410_upll_clk_ops;
- break;
- case pll_s3c2440_mpll:
- if (!pll->rate_table)
- init.ops = &samsung_s3c2440_mpll_clk_min_ops;
- else
- init.ops = &samsung_s3c2440_mpll_clk_ops;
- break;
case pll_2550x:
init.ops = &samsung_pll2550x_clk_ops;
break;
diff --git a/drivers/clk/samsung/clk-pll.h b/drivers/clk/samsung/clk-pll.h
index a9892c2d1f57..5d5a58d40e7e 100644
--- a/drivers/clk/samsung/clk-pll.h
+++ b/drivers/clk/samsung/clk-pll.h
@@ -25,9 +25,6 @@ enum samsung_pll_type {
pll_6552,
pll_6552_s3c2416,
pll_6553,
- pll_s3c2410_mpll,
- pll_s3c2410_upll,
- pll_s3c2440_mpll,
pll_2550x,
pll_2550xx,
pll_2650x,
@@ -56,24 +53,6 @@ enum samsung_pll_type {
.sdiv = (_s), \
}
-#define PLL_S3C2410_MPLL_RATE(_fin, _rate, _m, _p, _s) \
- { \
- .rate = PLL_VALID_RATE(_fin, _rate, \
- _m + 8, _p + 2, _s, 0, 16), \
- .mdiv = (_m), \
- .pdiv = (_p), \
- .sdiv = (_s), \
- }
-
-#define PLL_S3C2440_MPLL_RATE(_fin, _rate, _m, _p, _s) \
- { \
- .rate = PLL_VALID_RATE(_fin, _rate, \
- 2 * (_m + 8), _p + 2, _s, 0, 16), \
- .mdiv = (_m), \
- .pdiv = (_p), \
- .sdiv = (_s), \
- }
-
#define PLL_36XX_RATE(_fin, _rate, _m, _p, _s, _k) \
{ \
.rate = PLL_VALID_RATE(_fin, _rate, \
--
Best Regards,
Samsung Electronics
Chanwoo Choi
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-10-22 11:52 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-21 20:22 [PATCH 00/21] ARM: s3c: clean out obsolete platforms Arnd Bergmann
2022-10-21 20:27 ` [PATCH 01/21] ARM: s3c: remove all s3c24xx support Arnd Bergmann
2022-10-22 20:56 ` Heiko Stübner
2022-10-24 14:27 ` Arnd Bergmann
2022-10-24 15:45 ` Heiko Stübner
2022-10-24 12:25 ` Krzysztof Kozlowski
2022-10-27 23:10 ` Stephen Boyd
2022-10-21 20:27 ` [PATCH 02/21] ARM: s3c: remove s3c24xx specific hacks Arnd Bergmann
2022-10-21 22:33 ` Wolfram Sang
2022-10-22 11:24 ` Greg Kroah-Hartman
2022-10-22 14:02 ` Linus Walleij
2022-10-23 11:00 ` Jonathan Cameron
2022-10-23 18:08 ` Daniel Lezcano
2022-10-24 7:55 ` Miquel Raynal
2022-10-24 12:26 ` Krzysztof Kozlowski
2022-10-24 16:53 ` Ulf Hansson
2022-10-27 23:10 ` Stephen Boyd
2022-10-21 20:27 ` [PATCH 03/21] ARM: s3c: remove most s3c64xx board support Arnd Bergmann
2022-10-24 12:26 ` Krzysztof Kozlowski
2022-10-21 20:27 ` [PATCH 04/21] ARM: s3c: remove adc.c Arnd Bergmann
2022-10-24 11:37 ` Mark Brown
2022-10-24 12:27 ` Krzysztof Kozlowski
2022-10-21 20:27 ` [PATCH 05/21] ARM: s3c: simplify platform code Arnd Bergmann
2022-10-24 11:41 ` Mark Brown
2022-10-24 12:29 ` Krzysztof Kozlowski
2022-10-24 13:32 ` Arnd Bergmann
2022-10-24 14:13 ` Krzysztof Kozlowski
2022-10-21 20:27 ` [PATCH 06/21] ARM: s3c: remove s3c6400 support Arnd Bergmann
2022-10-24 12:30 ` Krzysztof Kozlowski
2022-10-21 20:27 ` [PATCH 07/21] power: remove s3c adc battery driver Arnd Bergmann
2022-10-24 7:28 ` Lee Jones
2022-10-24 7:42 ` Arnd Bergmann
2022-10-24 7:57 ` Lee Jones
2022-10-24 12:31 ` Krzysztof Kozlowski
2022-10-28 14:18 ` Sebastian Reichel
2022-10-21 20:27 ` [PATCH 08/21] hwmon: remove s3c driver Arnd Bergmann
2022-10-22 4:02 ` Guenter Roeck
2022-10-22 8:36 ` Arnd Bergmann
2022-10-24 12:31 ` Krzysztof Kozlowski
2022-10-21 20:27 ` [PATCH 09/21] pata: remove samsung_cf driver Arnd Bergmann
2022-10-23 14:35 ` Sergey Shtylyov
2022-10-23 22:41 ` Damien Le Moal
2022-10-23 22:43 ` Damien Le Moal
2022-10-24 14:24 ` Arnd Bergmann
2022-10-24 12:34 ` Krzysztof Kozlowski
2022-10-21 20:27 ` [PATCH 10/21] mmc: remove s3cmci driver Arnd Bergmann
2022-10-24 12:35 ` Krzysztof Kozlowski
2022-10-24 16:52 ` Ulf Hansson
2022-10-21 20:27 ` [PATCH 11/21] clk: remove s3c24xx driver Arnd Bergmann
2022-10-22 11:50 ` Chanwoo Choi [this message]
2022-10-24 12:37 ` Krzysztof Kozlowski
2022-10-27 23:11 ` Stephen Boyd
2022-10-21 20:27 ` [PATCH 12/21] leds: " Arnd Bergmann
2022-10-22 10:04 ` Pavel Machek
2022-10-24 12:37 ` Krzysztof Kozlowski
2022-10-21 20:27 ` [PATCH 13/21] usb: gadget: remove s3c24xx drivers Arnd Bergmann
2022-10-24 12:39 ` Krzysztof Kozlowski
2022-10-21 20:27 ` [PATCH 14/21] dmaengine: remove s3c24xx driver Arnd Bergmann
2022-10-24 12:40 ` Krzysztof Kozlowski
2022-11-04 14:14 ` Vinod Koul
2022-10-21 20:27 ` [PATCH 15/21] cpufreq: remove s3c24xx drivers Arnd Bergmann
2022-10-24 12:40 ` Krzysztof Kozlowski
2022-10-25 5:19 ` Viresh Kumar
2022-10-21 20:27 ` [PATCH 16/21] fbdev: remove s3c2410 framebuffer Arnd Bergmann
2022-10-24 12:49 ` Krzysztof Kozlowski
2022-10-21 20:27 ` [PATCH 17/21] input: remove s3c24xx touchscreen driver Arnd Bergmann
2022-10-24 11:57 ` Dmitry Torokhov
2022-10-24 12:50 ` Krzysztof Kozlowski
2022-10-24 13:02 ` Arnd Bergmann
2022-10-21 20:27 ` [PATCH 18/21] pinctrl: remove s3c24xx driver Arnd Bergmann
2022-10-21 21:25 ` Linus Walleij
2022-10-24 12:51 ` Krzysztof Kozlowski
2022-10-21 20:27 ` [PATCH 19/21] spi: " Arnd Bergmann
2022-10-24 12:52 ` Krzysztof Kozlowski
2022-10-21 20:27 ` [PATCH 20/21] soc: s3c: remove pm-debug hack Arnd Bergmann
2022-10-24 12:52 ` Krzysztof Kozlowski
2022-10-21 20:27 ` [PATCH 21/21] ASoC: samsung: remove unused drivers Arnd Bergmann
2022-10-24 12:53 ` Krzysztof Kozlowski
2022-10-22 15:18 ` [PATCH 00/21] ARM: s3c: clean out obsolete platforms Krzysztof Kozlowski
2022-10-22 19:48 ` Arnd Bergmann
2022-10-24 13:00 ` Rob Herring
2022-10-24 13:18 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e0eff12-d8ea-72e9-d135-4259dda9a750@gmail.com \
--to=cwchoi00@gmail.com \
--cc=alim.akhtar@samsung.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=ben-linux@fluff.org \
--cc=cw00.choi@samsung.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@simtec.co.uk \
--cc=mturquette@baylibre.com \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@kernel.org \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).