From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 161A8C3A589 for ; Tue, 20 Aug 2019 19:03:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DF6CC206DD for ; Tue, 20 Aug 2019 19:03:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fsuQsDDE"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ti.com header.i=@ti.com header.b="KMgH7OG/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DF6CC206DD Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0WkmEDSAVAfQOC+n5sr6il+anbGOnswx32RNjgIqWi4=; b=fsuQsDDE7W4e0h CH1eWKTdzN/nOgJI4ptFR/WtgOS+O+nCmG/nRwk50M226NKSxJV/XG/AyqZgOZ5u8hVjvTT5bVG5i 25qjG+l0byEEWltK48Haddzo/xIc5680WRUn88PNrWHojeUxc74wLRBcKNeccbx3ehKMJAd4AtkiF 5pkxX65SXCwBrNQ7Zqb5aoi11651ewGor6egt1VvHSZnPTT3O8Occo61R75vqUPnq0OrufSZNa4S0 fxXK1Jf/TOaLFvnih3azc/RhH9sXjQAeICw/F6ixMmp1Fyr69WBU5KF4LojJcyTguJAwttti1SlMg NOOLBergXt56+mzPZ5+A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i09Ps-00034v-D9; Tue, 20 Aug 2019 19:03:36 +0000 Received: from lelv0142.ext.ti.com ([198.47.23.249]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i09Pn-00034R-AQ for linux-arm-kernel@lists.infradead.org; Tue, 20 Aug 2019 19:03:35 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id x7KJ3R69025664; Tue, 20 Aug 2019 14:03:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1566327807; bh=JVdBCN/DIJHEMsnoQbdPcuQnClNVcVk4OR+5D8nrX5o=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=KMgH7OG/7QEgNOpa53Fms+D92jjygywIpWEyLF5GgdoXl+DfHn0/+ms6P6CMR36C5 hmXd/dcbZwKJmgXywZY6vZHNqunp934PARzkXGkWF14u8hnv0RP2sT2LTBcAtXWDcW q7avMbnimnKzivkQB3P2owYVMARojMt38zLm2dEU= Received: from DLEE105.ent.ti.com (dlee105.ent.ti.com [157.170.170.35]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x7KJ3RAi126608 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 20 Aug 2019 14:03:27 -0500 Received: from DLEE104.ent.ti.com (157.170.170.34) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Tue, 20 Aug 2019 14:03:27 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE104.ent.ti.com (157.170.170.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Tue, 20 Aug 2019 14:03:26 -0500 Received: from [128.247.58.153] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id x7KJ3QaX001436; Tue, 20 Aug 2019 14:03:26 -0500 Subject: Re: [PATCH 7/8] soc: ti: omap-prm: add dra7 PRM data To: Tero Kristo , , , , References: <1565164139-21886-1-git-send-email-t-kristo@ti.com> <1565164139-21886-8-git-send-email-t-kristo@ti.com> From: Suman Anna Message-ID: <0e8aa351-4c58-ab6c-890f-094118b812ac@ti.com> Date: Tue, 20 Aug 2019 14:03:26 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <1565164139-21886-8-git-send-email-t-kristo@ti.com> Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190820_120333_678141_CE3873B4 X-CRM114-Status: GOOD ( 15.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tony@atomide.com, devicetree@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Tero, On 8/7/19 2:48 AM, Tero Kristo wrote: > Add PRM data for dra7 family of SoCs. > > Signed-off-by: Tero Kristo > --- > drivers/soc/ti/omap_prm.c | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/drivers/soc/ti/omap_prm.c b/drivers/soc/ti/omap_prm.c > index fadfc7f..05b7749 100644 > --- a/drivers/soc/ti/omap_prm.c > +++ b/drivers/soc/ti/omap_prm.c > @@ -73,6 +73,31 @@ struct omap_prm_data omap4_prm_data[] = { > { }, > }; > > +static struct omap_prm_data dra7_prm_data[] = { > + { .name = "mpu", .base = 0x4ae06300, .pwstst = 0x4 }, > + { .name = "dsp1", .base = 0x4ae06400, .pwstst = 0x4, .rstctl = 0x10, .rstst = 0x14 }, > + { .name = "ipu", .base = 0x4ae06500, .pwstst = 0x4, .rstctl = 0x10, .rstst = 0x14, .clkdm_name = "ipu1" }, > + { .name = "coreaon", .base = 0x4ae06628, .pwstst = 0x4 }, Public TRM marks this region Reserved. Do you need it for anything? > + { .name = "core", .base = 0x4ae06700, .pwstst = 0x4, .rstctl = 0x210, .rstst = 0x214, .clkdm_name = "ipu2" }, > + { .name = "iva", .base = 0x4ae06f00, .pwstst = 0x4 }, Missing rstctrl and rstst offsets. > + { .name = "cam", .base = 0x4ae07000, .pwstst = 0x4 }, > + { .name = "dss", .base = 0x4ae07100, .pwstst = 0x4 }, > + { .name = "gpu", .base = 0x4ae07200, .pwstst = 0x4 }, > + { .name = "l3init", .base = 0x4ae07300, .pwstst = 0x4, .rstctl = 0x10, .rstst = 0x14 }, > + { .name = "l4per", .base = 0x4ae07400, .pwstst = 0x4 }, > + { .name = "custefuse", .base = 0x4ae07600, .pwstst = 0x4 }, > + { .name = "wkupaon", .base = 0x4ae07724, .pwstst = 0x4 }, No pwstctrl and pwstst bits documented in TRM or are marked reserved. > + { .name = "emu", .base = 0x4ae07900, .pwstst = 0x4 }, > + { .name = "dsp2", .base = 0x4ae07b00, .pwstst = 0x4, .rstctl = 0x10, .rstst = 0x14 }, > + { .name = "eve1", .base = 0x4ae07b40, .pwstst = 0x4 }, > + { .name = "eve2", .base = 0x4ae07b80, .pwstst = 0x4 }, > + { .name = "eve3", .base = 0x4ae07bc0, .pwstst = 0x4 }, > + { .name = "eve4", .base = 0x4ae07c00, .pwstst = 0x4 }, All EVEs are missing rstctrl and rstst fields. > + { .name = "rtc", .base = 0x4ae07c60, .pwstst = 0x4 }, Undocumented pwstctrl and pwstst registers. > + { .name = "vpe", .base = 0x4ae07c80, .pwstst = 0x4 }, Missing "device" and "instr" PRM. The latter doesn't have any pwrstctl and pwrstst though. regards Suman > + { }, > +}; > + > struct omap_rst_map am3_wkup_rst_map[] = { > { .rst = 3, .st = 5 }, > { .rst = -1 }, > @@ -91,6 +116,7 @@ struct omap_prm_data am3_prm_data[] = { > > static const struct of_device_id omap_prm_id_table[] = { > { .compatible = "ti,omap4-prm-inst", .data = omap4_prm_data }, > + { .compatible = "ti,dra7-prm-inst", .data = dra7_prm_data }, > { .compatible = "ti,am3-prm-inst", .data = am3_prm_data }, > { }, > }; > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel