From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A357FC433F5 for ; Mon, 10 Oct 2022 14:25:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GgIYcqaD9ZIBnqi6iItQ52mY1XAoZjXyPlkiwSV6XKk=; b=J6/hK1GNY8FafLrzj8lPSmvZcy GjvvjNOicOrlA78IRSHE5Oh87zhtwEm3v2IEAPlDO5Ocl9RM099x1jeJ61fJRIS6znGQA12BMFONh N6hiOlJd1Edb4Q6D8iGsAQ7TYRLyKZFFZDhoib/ao+K3L0kLMzUcmE4nWXSL7XaEwlkzRjYQk/1Yo OONkd6/tqJb1jGv1PZo2eLJnPrs42jZTlNWpuwa1f9EjFzqILvnNVQPZrJoCllQnk2mzYb8XCc42n vtnVBcLje3a2Esxe7z+9mhm2O1sZDhuAwmReHQg1bgaCYyKlpg1RGOQ6lj2s40fHE7EEXayKzljAN X7FpRbdg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ohthX-001CiV-JW; Mon, 10 Oct 2022 14:24:15 +0000 Received: from relay01.th.seeweb.it ([5.144.164.162]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ohthT-001CfS-GL for linux-arm-kernel@lists.infradead.org; Mon, 10 Oct 2022 14:24:13 +0000 Received: from cp.tophost.it (vm1054.cs12.seeweb.it [217.64.195.253]) by m-r1.th.seeweb.it (Postfix) with ESMTPA id A809A1F660; Mon, 10 Oct 2022 16:23:59 +0200 (CEST) MIME-Version: 1.0 Date: Mon, 10 Oct 2022 16:10:42 +0200 From: konrad.dybcio@somainline.org To: Rob Herring Cc: Konrad Dybcio , ~postmarketos/upstreaming@lists.sr.ht, asahi@lists.linux.dev, Hector Martin , Sven Peter , Alyssa Rosenzweig , martin.botka@somainline.org, angelogioacchino.delregno@somainline.org, marijn.suijten@somainline.org, jamipkettunen@somainline.org, Thomas Gleixner , Marc Zyngier , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v4 1/2] dt-bindings: apple,aic: Document A7-A11 compatibles In-Reply-To: <20221010122727.GA432201-robh@kernel.org> References: <20221007200022.22844-1-konrad.dybcio@somainline.org> <20221007200022.22844-2-konrad.dybcio@somainline.org> <20221010122727.GA432201-robh@kernel.org> User-Agent: Roundcube Webmail/1.4.6 Message-ID: <0ff2cede3ac644141ba66f54244eb069@pop.somainline.org> X-Sender: konrad.dybcio@somainline.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221010_072411_729752_608653C1 X-CRM114-Status: GOOD ( 16.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2022-10-10 14:27, Rob Herring wrote: > On Fri, Oct 07, 2022 at 10:00:21PM +0200, Konrad Dybcio wrote: >> Document the compatibles for Apple A7-A11 SoCs. >> >> Signed-off-by: Konrad Dybcio >> --- >> Changes since v3: >> - Bindings: A7-A10+M1 only get SoC compat and generic fallback, >> A11 gets M1 fallback and generic fallback (removed A11 compatible) > > I have no idea if that makes sense or not. Do I have to go read the > rationale in the prior version? > > The question to ask on fallbacks, is would s/w that only understands > the > fallback compatible work as-is? Yep, A7-A10 share the same feature level ("apple,aic"), but I think having a separate, per-SoC compatible in the DT from the get-go makes a lot of sense, since we're not sure what's gonna happen when we, for example, add SMP support for these older chipsets, maybe they'll need some special handling. Similar story with A11 and M1. They can both work with "apple,aic", but they also support things that are enabled with the "apple,t8103-aic" compat string. I do not plan on adding specific compatibles for A7-A11 SoCs in the driver, unless we uncover some bugs / deviations. Konrad > >> - Drop Rob's A-b as this is essentially yet another rewrite.. >> >> .../bindings/interrupt-controller/apple,aic.yaml | 16 >> +++++++++++++--- >> 1 file changed, 13 insertions(+), 3 deletions(-) >> >> diff --git >> a/Documentation/devicetree/bindings/interrupt-controller/apple,aic.yaml >> b/Documentation/devicetree/bindings/interrupt-controller/apple,aic.yaml >> index e18107eafe7c..1427ea9b04a2 100644 >> --- >> a/Documentation/devicetree/bindings/interrupt-controller/apple,aic.yaml >> +++ >> b/Documentation/devicetree/bindings/interrupt-controller/apple,aic.yaml >> @@ -36,9 +36,19 @@ allOf: >> >> properties: >> compatible: >> - items: >> - - const: apple,t8103-aic >> - - const: apple,aic >> + oneOf: >> + - items: >> + - enum: >> + - apple,s5l8960x-aic >> + - apple,s8000-aic >> + - apple,t7000-aic >> + - apple,t8010-aic >> + - apple,t8103-aic >> + - const: apple,aic >> + - items: >> + - const: apple,t8015-aic >> + - const: apple,t8103-aic >> + - const: apple,aic >> >> interrupt-controller: true >> >> -- >> 2.37.3 >> >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel