From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 8/8] tty/serial: add asm9260-serial driver
Date: Wed, 24 Sep 2014 12:20:26 +0200 [thread overview]
Message-ID: <102161224.Tj33eeeN8f@wuerfel> (raw)
In-Reply-To: <54228DD5.1090606@rempel-privat.de>
On Wednesday 24 September 2014 11:24:37 Oleksij Rempel wrote:
> m 22.09.2014 um 17:26 schrieb Arnd Bergmann:
> > On Sunday 21 September 2014 20:45:51 Oleksij Rempel wrote:
> >> Signed-off-by: Oleksij Rempel <linux@rempel-privat.de>
> >> ---
> >> drivers/tty/serial/Kconfig | 17 +
> >> drivers/tty/serial/Makefile | 1 +
> >> drivers/tty/serial/asm9260_serial.c | 1485 +++++++++++++++++++++++++++++++++++
> >> include/uapi/linux/serial_core.h | 2 +
> >> 4 files changed, 1505 insertions(+)
> >> create mode 100644 drivers/tty/serial/asm9260_serial.c
> >>
> >
> > Similar to the irqchip driver, this one in turns seems to be a duplicate
> > of drivers/tty/serial/mxs-auart.c. Please see if you can make that one
> > work instead of adding a new copy.
>
> Hmmm.... they are identical in some parts, but have some different
> offsets, and in some cases different bitmask.
It really depends on how much is different.
> I think it will look
> messy. Asm9260 has some more extras: RS485, CTRL3, ISO7816.
None of these are used in your driver though. It's possible that
mxs has the same registers but the driver author did not document
them.
> Should it be moved to one file? Or may be better to create some
> common-dma.c and common-pio.c libs?
I'd suggest trying to do it in one file first, only splitting things
out if it gets too messy.
You will probably have to replace the .driver_data in mxs_auart_devtype
with a structure that has all the differences, either using function
pointers for accessing the registers that are not identical, or using
some data that can be used to look up the the actual registers.
Arnd
next prev parent reply other threads:[~2014-09-24 10:20 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-21 18:41 [PATCH v2 0/8] initial suport for Alpscale ASM9260 Oleksij Rempel
2014-09-21 18:41 ` [PATCH v2 1/8] ARM: add mach-asm9260 Oleksij Rempel
2014-09-22 15:08 ` Arnd Bergmann
2014-09-23 9:00 ` Oleksij Rempel
2014-09-23 10:19 ` Arnd Bergmann
2014-09-24 8:00 ` Oleksij Rempel
2014-09-24 9:43 ` Russell King - ARM Linux
2014-09-24 9:56 ` Oleksij Rempel
2014-09-24 10:25 ` Russell King - ARM Linux
2014-09-24 10:33 ` Arnd Bergmann
2014-09-24 11:30 ` Oleksij Rempel
2014-09-21 18:41 ` [PATCH v2 2/8] add include/debug/asm9260.S Oleksij Rempel
2014-09-21 18:45 ` Oleksij Rempel
2014-09-21 18:45 ` [PATCH v2 3/8] add alphascale,asm9260.h binding Oleksij Rempel
2014-09-24 10:15 ` Mark Rutland
2014-09-21 18:45 ` [PATCH v2 4/8] ARM: dts: add DT for Alphascale ASM9260 SoC Oleksij Rempel
2014-09-22 15:14 ` Arnd Bergmann
2014-09-24 10:11 ` Mark Rutland
2014-09-21 18:45 ` [PATCH v2 5/8] clk: add clk-asm9260 driver Oleksij Rempel
2014-09-21 18:45 ` [PATCH v2 6/8] clocksource: add asm9260_timer driver Oleksij Rempel
2014-09-21 18:45 ` [PATCH v2 7/8] irqchip: add irq-asm9260 driver Oleksij Rempel
2014-09-22 15:22 ` Arnd Bergmann
2014-09-21 18:45 ` [PATCH v2 8/8] tty/serial: add asm9260-serial driver Oleksij Rempel
2014-09-22 15:26 ` Arnd Bergmann
2014-09-22 16:04 ` Oleksij Rempel
2014-09-24 9:24 ` Oleksij Rempel
2014-09-24 10:20 ` Arnd Bergmann [this message]
2014-09-23 11:32 ` [PATCH v2 0/8] initial suport for Alpscale ASM9260 Arnd Bergmann
2014-09-24 10:13 ` Mark Rutland
2014-10-07 8:55 ` [PATCH v3 0/9] initial suport for Alphascale ASM9260 Oleksij Rempel
2014-10-07 8:55 ` [PATCH v3 1/9] ARM: add mach-asm9260 Oleksij Rempel
2014-10-07 8:55 ` [PATCH v3 2/9] arm: add lolevel debug support for asm9260 Oleksij Rempel
2014-10-07 8:55 ` [PATCH v3 3/9] ARM: dts: add DT for Alphascale ASM9260 SoC Oleksij Rempel
2014-10-07 8:55 ` [PATCH v3 4/9] ARM: add alphascale,acc.txt bindings documentation Oleksij Rempel
2014-10-07 8:55 ` [PATCH v3 5/9] ARM: clk: add clk-asm9260 driver Oleksij Rempel
2014-10-07 8:55 ` [PATCH v3 6/9] clocksource: add asm9260_timer driver Oleksij Rempel
2014-10-07 8:55 ` [PATCH v3 7/9] irqchip/irq-mxs.c: add asm9260 support Oleksij Rempel
2014-10-08 7:45 ` Thomas Gleixner
2014-10-08 12:11 ` [PATCH v4 1/2] irqchip: mxs: prepare driver for HW with different offsets Oleksij Rempel
2014-10-08 12:11 ` [PATCH v4 2/2] irqchip: mxs: add Alpascale ASM9260 support Oleksij Rempel
2014-10-07 8:55 ` [PATCH v3 8/9] tty/serial/mxs-auart.c: add initial Alphascale " Oleksij Rempel
2014-10-07 8:55 ` [PATCH v3 9/9] add Alphascale to vendor-prefixes.txt Oleksij Rempel
2014-10-10 5:38 ` [PATCH v3 0/9] initial suport for Alphascale ASM9260 Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=102161224.Tj33eeeN8f@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).