From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78F58C54FCF for ; Wed, 25 Mar 2020 02:11:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 495582073C for ; Wed, 25 Mar 2020 02:11:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="HY7S5Xau" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 495582073C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HKgINja70kK1NCcQWN5+eCJYQLWy1Ga9FNrCBjDNyEw=; b=HY7S5Xaufz3Hy+ CytpPSAQ8xyVqtYZAJNuz/teE892cCKczBdN64fcZB8sm6cG7L8bKVvErnCuxAxffBsDRDd+3txY4 91Mt58+9wtHCfkKXGOAf6nAWG/4mbip2lbwXbMK4qRYyjgljFk9vIN6bWn6S2B/4oK9P++FY269Jf 7m4S8gxguDzDrGP/wAzQyWfEQG7x5hlU8Tz56g+gDyJrm+agdDt3Riymp4QUktMcKCyP5r/QVYh5A 6YX1nRCP6gu7tHdlFAkKaVcB/nAe+hG8O4XBt7uVrUyXZkurRGhyTanXBP3Q4qK549hbifasq9qe8 VPWDr1T3wGD3nsp5k4rw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jGvVZ-0004c5-Ss; Wed, 25 Mar 2020 02:11:05 +0000 Received: from szxga03-in.huawei.com ([45.249.212.189] helo=huawei.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jGvVV-0004b4-Ay for linux-arm-kernel@lists.infradead.org; Wed, 25 Mar 2020 02:11:04 +0000 Received: from dggeml405-hub.china.huawei.com (unknown [172.30.72.56]) by Forcepoint Email with ESMTP id F278CAC235422688F1C5; Wed, 25 Mar 2020 10:10:47 +0800 (CST) Received: from DGGEML421-HUB.china.huawei.com (10.1.199.38) by dggeml405-hub.china.huawei.com (10.3.17.49) with Microsoft SMTP Server (TLS) id 14.3.487.0; Wed, 25 Mar 2020 10:10:47 +0800 Received: from DGGEML533-MBS.china.huawei.com ([169.254.10.196]) by dggeml421-hub.china.huawei.com ([10.1.199.38]) with mapi id 14.03.0487.000; Wed, 25 Mar 2020 10:10:40 +0800 From: "yezhenyu (A)" To: Steven Rostedt Subject: RE: [RFC PATCH v4 4/6] mm: Add page table level flags to vm_flags Thread-Topic: [RFC PATCH v4 4/6] mm: Add page table level flags to vm_flags Thread-Index: AQHWAeKVXiq19lnJ+0q/54z19KSbo6hXjqYAgAD+HPA= Date: Wed, 25 Mar 2020 02:10:40 +0000 Message-ID: <10338CF38D9A684EA38E1CF7D8D3411B045BA207@dggeml533-mbs.china.huawei.com> References: <20200324134534.1570-1-yezhenyu2@huawei.com> <20200324134534.1570-5-yezhenyu2@huawei.com> <20200324144436.043659c2@gandalf.local.home> In-Reply-To: <20200324144436.043659c2@gandalf.local.home> Accept-Language: en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.173.220.25] MIME-Version: 1.0 X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200324_191101_539118_8F65FBEC X-CRM114-Status: GOOD ( 12.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "mark.rutland@arm.com" , "peterz@infradead.org" , "catalin.marinas@arm.com" , "linux-mm@kvack.org" , "Guohanjun \(Hanjun Guo\)" , "will@kernel.org" , "linux-arch@vger.kernel.org" , "yuzhao@google.com" , "maz@kernel.org" , "steven.price@arm.com" , "arm@kernel.org" , "Dave.Martin@arm.com" , "arnd@arndb.de" , "suzuki.poulose@arm.com" , "npiggin@gmail.com" , Zhangshaokun , "broonie@kernel.org" , Xiexiangyou , "Zengtao \(B\)" , "tglx@linutronix.de" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "aneesh.kumar@linux.ibm.com" , "akpm@linux-foundation.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Steve, On Wed, 25 Mar 2020 2:45, Steve wrote: > On Tue, 24 Mar 2020 21:45:32 +0800 > Zhenyu Ye wrote: > > > --- a/include/trace/events/mmflags.h > > +++ b/include/trace/events/mmflags.h > > @@ -130,6 +130,16 @@ IF_HAVE_PG_IDLE(PG_idle, "idle" ) > > #define IF_HAVE_VM_SOFTDIRTY(flag,name) > > #endif > > > > +#ifdef CONFIG_64BIT > > +#define IF_HAVE_VM_LEVEL_PUD(flag,name) {flag, name} > > +#define IF_HAVE_VM_LEVEL_PMD(flag,name) {flag, name} > > +#define IF_HAVE_VM_LEVEL_PTE(flag,name) {flag, name} > > +#else > > +#define IF_HAVE_VM_LEVEL_PUD(flag,name) > > +#define IF_HAVE_VM_LEVEL_PMD(flag,name) > > +#define IF_HAVE_VM_LEVEL_PTE(flag,name) > > +#endif > > + > > #define __def_vmaflag_names \ > > {VM_READ, "read" }, \ > > {VM_WRITE, "write" }, \ > > @@ -161,7 +171,10 @@ IF_HAVE_VM_SOFTDIRTY(VM_SOFTDIRTY, > "softdirty" ) \ > > {VM_MIXEDMAP, "mixedmap" }, \ > > {VM_HUGEPAGE, "hugepage" }, \ > > {VM_NOHUGEPAGE, "nohugepage" }, \ > > - {VM_MERGEABLE, "mergeable" } \ > > + {VM_MERGEABLE, "mergeable" }, \ > > +IF_HAVE_VM_LEVEL_PUD(VM_LEVEL_PUD, "pud-level" ), \ > > +IF_HAVE_VM_LEVEL_PMD(VM_LEVEL_PMD, "pmd-level" ), \ > > +IF_HAVE_VM_LEVEL_PTE(VM_LEVEL_PTE, "pte-level" ) \ > > > > Have you tested this on 32bit? It looks like you'll get empty commas there. > Perhaps the defines need to be: > > #ifdef CONFIG_64BIT > #define IF_HAVE_VM_LEVEL_PUD(flag,name) {flag, name}, > #define IF_HAVE_VM_LEVEL_PMD(flag,name) {flag, name}, > #define IF_HAVE_VM_LEVEL_PTE(flag,name) {flag, name} > #else > #define IF_HAVE_VM_LEVEL_PUD(flag,name) > #define IF_HAVE_VM_LEVEL_PMD(flag,name) > #define IF_HAVE_VM_LEVEL_PTE(flag,name) > #endif > > And leave out the commas in the list. > > -- Steve Thanks for your review. I will fix this in next version, if I could still use vm_flags at that time :). Zhenyu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel