From: Michal Simek <michal.simek@xilinx.com>
To: Punit Agrawal <punit1.agrawal@toshiba.co.jp>, <sboyd@kernel.org>,
<michal.simek@xilinx.com>
Cc: <linux-clk@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] clk: zynqmp: Enable the driver if ZYNQMP_FIRMWARE is selected
Date: Wed, 17 Mar 2021 16:12:43 +0100 [thread overview]
Message-ID: <10d60612-2ee4-2fac-888e-6a2262f39469@xilinx.com> (raw)
In-Reply-To: <20210316090540.973014-1-punit1.agrawal@toshiba.co.jp>
On 3/16/21 10:05 AM, Punit Agrawal wrote:
> When booting the kernel on zynqmp based platforms such as Ultra96v2,
> peripheral drivers such as that for the sdcard depend on the presense
> of clocks.
>
> Enable the clock driver if it's dependencies are compiled to avoid
> building an unbootable kernel.
>
> Signed-off-by: Punit Agrawal <punit1.agrawal@toshiba.co.jp>
> ---
> drivers/clk/zynqmp/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/zynqmp/Kconfig b/drivers/clk/zynqmp/Kconfig
> index 17086059be8b..14e4f5c55525 100644
> --- a/drivers/clk/zynqmp/Kconfig
> +++ b/drivers/clk/zynqmp/Kconfig
> @@ -4,6 +4,7 @@ config COMMON_CLK_ZYNQMP
> bool "Support for Xilinx ZynqMP Ultrascale+ clock controllers"
> depends on ARCH_ZYNQMP || COMPILE_TEST
> depends on ZYNQMP_FIRMWARE
> + default ZYNQMP_FIRMWARE
> help
> Support for the Zynqmp Ultrascale clock controller.
> It has a dependency on the PMU firmware.
>
I am fine with it but I think we should fix also that depends on
ARCH_ZYNQMP. ZYNQMP_FIRMWARE already depends on ARCH_ZYNQMP that's why
it is redundant here.
Thanks,
Michal
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-03-17 15:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-16 9:05 [PATCH] clk: zynqmp: Enable the driver if ZYNQMP_FIRMWARE is selected Punit Agrawal
2021-03-17 15:12 ` Michal Simek [this message]
2021-03-22 4:42 ` Punit Agrawal
2021-03-22 5:00 ` Punit Agrawal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10d60612-2ee4-2fac-888e-6a2262f39469@xilinx.com \
--to=michal.simek@xilinx.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=punit1.agrawal@toshiba.co.jp \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).