From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 47084C54EBE for ; Tue, 10 Jan 2023 09:50:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oK6VoQkGvGcCXUg6vd5qnZfXYG087M5YeEnRaFGY8EY=; b=Psc9maekyuDVDp owJem6s5qDJJ4QdXBO3XcY4G8ZXm7ZXOfN989Ep5VP3BGF+QDHRw7WHhIzb1/hKjs5LMiPE5Q0vTs 0bBfX4RerfPpKm4Yif5Osjr8aq783ZWacGwk+0dIWsLhVEDphD8cCr1xTXvdmQB0hN02ItrUWsBX3 pXCbM6SxpIzsKE/qM7Liym200yT4CtC8DHwAPTeZOwnIbgj/j4Rb4ZHdIFCNOg7/RTQSxybaGs0L7 +om+Yi9JnOmgkY88Y1bdOTiJHxgGt56/wJ5ou38Mas7ndXriOY9wky5okzMWbWCRFxxcc/9jewt6q J7mEsXt1nkTKSuHm4NEg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFBGJ-006DOx-1H; Tue, 10 Jan 2023 09:49:43 +0000 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFBGF-006DOG-Sd for linux-arm-kernel@lists.infradead.org; Tue, 10 Jan 2023 09:49:41 +0000 Received: by mail-wm1-x32f.google.com with SMTP id z8-20020a05600c220800b003d33b0bda11so699745wml.0 for ; Tue, 10 Jan 2023 01:49:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3yg0yWxaO3D77Rc0YvK78QrEddXCLnXNXF1NfjRw2ik=; b=p0+wGr50kzPrjqKDE6iMoVByKnfBTswHllyJ0hbTRrcv6KmotSkY9fXD0ucOZHCXg7 UrGyLCQD2cNuR2Pv/UCVKtIgWL7SJ3J9ldLEJ1mLC0dca5dNETHiYiY5EUmHtI+64fKM 8kmCedm+aUmlSpmmnL8EkQLGWIQt5UMElxFD7swiH0Y6C8NUM0vkia35z0HZdZJEL3wk CAnSjbq4HBkHcU/OEQyvyILwKqGfuoUZSK4AIXXqL9QQjlNJu7XZlYP2OJvRqyxf12JX oGsp5QGCtnbKbBcZuvo1qPOjYJAIDxft+NYlwey/Z5SpnUN/Ww3JTVSCYXykUWnPTAZK acAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3yg0yWxaO3D77Rc0YvK78QrEddXCLnXNXF1NfjRw2ik=; b=YEolao6NiNByhr2YlMUTydzAaOboq/k0/shrimcZj1AH6CPbK4HNXti4BZb3N2gjUr jFe9rjcQDccA7VGVaFSIAEyvmiDGZ6YD7GfAT2gnaVd8vPWF35GXRfBJup8iOiyxhNTP 6sgIOFKKhnSn82qGIwy/A66dSMa468SlzVOd5ii46C8sw7yl6hqnBAFS3zTp/iXYbomt csCq5TpPcKVkKINdLNloE2Mk9CpG8f0z5y82Cqt+plJAf/IUJYqI4JNu+PYz+JdE9+xP zkK7819G3XwbQSPQso2OY/qSMrP+gxZBoG3/10BNJWdeS9kcAtI+Li+8AnyEihSLqqr9 l9CA== X-Gm-Message-State: AFqh2kozfDF3adSXmTegZ/0sM5KeQZc5BWyqoGbrorcOM9XqGtjNuyqY UyfdkeZXsEjxykAl/ngx6UGtcw== X-Google-Smtp-Source: AMrXdXuASSZzKeUfOw9NJX7VERkz88BE+g/9yYKsDXnLCZOI/iHYipX/l8kBD+iUSPDp91rG1gf3AA== X-Received: by 2002:a05:600c:2142:b0:3d5:365b:773e with SMTP id v2-20020a05600c214200b003d5365b773emr58864982wml.39.1673344178638; Tue, 10 Jan 2023 01:49:38 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id c18-20020a05600c0ad200b003d9c97d82f2sm14117592wmr.8.2023.01.10.01.49.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Jan 2023 01:49:38 -0800 (PST) Message-ID: <110af65f-9c18-524d-a073-ef7be60d1f5a@linaro.org> Date: Tue, 10 Jan 2023 10:49:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 2/5] dt-bindings: soc: hpe: hpe,gxp-srom.yaml Content-Language: en-US To: clayc@hpe.com, linux-kernel@vger.kernel.org, soc@kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, verdun@hpe.com, nick.hawkins@hpe.com, arnd@arndb.de, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux@armlinux.org.uk, olof@lixom.net References: <20230110042533.12894-1-clayc@hpe.com> <20230110042533.12894-3-clayc@hpe.com> From: Krzysztof Kozlowski In-Reply-To: <20230110042533.12894-3-clayc@hpe.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230110_014939_954323_CC9A2065 X-CRM114-Status: GOOD ( 19.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/01/2023 05:25, clayc@hpe.com wrote: > From: Clay Chang > > Document binding to support SROM driver in GXP. > > Signed-off-by: Clay Chang > --- > .../bindings/soc/hpe/hpe,gxp-srom.yaml | 36 +++++++++++++++++++ > 1 file changed, 36 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/hpe/hpe,gxp-srom.yaml > > diff --git a/Documentation/devicetree/bindings/soc/hpe/hpe,gxp-srom.yaml b/Documentation/devicetree/bindings/soc/hpe/hpe,gxp-srom.yaml > new file mode 100644 > index 000000000000..14ad97d595c8 > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/hpe/hpe,gxp-srom.yaml Don't drop stuff to soc. Put it in respective directories. This also applies to your driver. SROM controllers go to memory-controllers. What is this, I have no clue. "SROM Control Register" is not helping me. > @@ -0,0 +1,36 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/soc/hpe/hpe,gxp-srom.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: HPE GXP SoC SROM Control Register > + > +maintainers: > + - Clay Chang > + > +description: |+ > + The SROM control register can be used to configure LPC related legacy > + I/O registers. And why this is a hardware? No, you now add fake devices to be able to write some stuff from user-space... Otherwise this needs proper hardware description. > + > +properties: > + compatible: > + items: Drop items, you have only one item. > + - const: hpe,gxp-srom > + > + reg: > + items: > + - description: SROM LPC Configuration Registers Drop items and description. Just maxItems: 1 > + > +required: > + - compatible > + - reg > + > +unevaluatedProperties: false > + > +examples: > + - | > + srom: srom@80fc0000 { > + compatible = "hpe,gxp-srom"; > + reg = <0x80fc0000 0x100>; > + }; Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel