linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [GIT PULL] Renesas ARM Based SoC Init Delay Updates For v3.18
Date: Tue, 09 Sep 2014 10:50:46 +0200	[thread overview]
Message-ID: <11409170.rfMyQrIgd0@wuerfel> (raw)
In-Reply-To: <20140909020218.GA23233@verge.net.au>

On Tuesday 09 September 2014 11:02:18 Simon Horman wrote:
> On Fri, Sep 05, 2014 at 05:27:18PM +0200, Arnd Bergmann wrote:
> > On Monday 25 August 2014, Simon Horman wrote:
> > > Hi Olof, Hi Kevin, Hi Arnd,
> > > 
> > > Please consider these Renesas ARM based SoC init delay updates for v3.18.
> > > 
> > 
> > While looking at your branches, I noticed that you go to great lengths
> > to compute the correct lpj value and avoid the calibration.
> > 
> > However, I believe the "modern" way to do this is to call
> > register_current_timer_delay() in order to base the delay loop
> > on the hardware timer instead of looping in the CPU. This is
> > more accurate and more robust against CPU frequency scaling.
> 
> I may be wrong but my understanding is that Renesas SoCs may be
> booted without a timer.

Do you mean some of them only have a clockevent driver but no clocksource,
and use the jiffies clocksource instead?

I've looked at the three drivers/clocksource/{sh,em}_*.c files, and it seems
sh_mtu2.c indeed has no clocksource support, although the binding description
mentions that it has multiple counters that could be used for this
purpose. This timer is only used on R7S72100, so if you add
'register_current_timer_delay' calls to the other drivers, you can
decide to either keep computing the lpj value for R7S72100 but not the
others, or try to add a clocksource implementation to mtu2 as well.

Note that the read_current_timer() function for the delay implementation
doesn't have to be based on the same timer as the clocksource, but in
practice it often is.

	Arnd

  reply	other threads:[~2014-09-09  8:50 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-25  1:10 [GIT PULL] Renesas ARM Based SoC Init Delay Updates For v3.18 Simon Horman
2014-08-25  1:10 ` [PATCH 01/10] ARM: shmobile: sh7372: Update DTS to include CPU frequency Simon Horman
2014-08-25  1:10 ` [PATCH 02/10] ARM: shmobile: sh73a0: " Simon Horman
2014-08-25  1:10 ` [PATCH 03/10] ARM: shmobile: r8a7778: " Simon Horman
2014-08-25  1:10 ` [PATCH 04/10] ARM: shmobile: sh7372: Use shmobile_init_delay() Simon Horman
2014-08-25  1:10 ` [PATCH 05/10] ARM: shmobile: r8a73a4: " Simon Horman
2014-08-25  1:10 ` [PATCH 06/10] ARM: shmobile: Remove shmobile_setup_delay() Simon Horman
2014-08-25  1:10 ` [PATCH 07/10] ARM: shmobile: sh73a0: Use shmobile_init_delay() Simon Horman
2014-08-25  1:10 ` [PATCH 08/10] ARM: shmobile: r8a7778: " Simon Horman
2014-08-25  1:10 ` [PATCH 09/10] ARM: shmobile: bockw: " Simon Horman
2014-08-25  1:10 ` [PATCH 10/10] ARM: shmobile: kzm9g: " Simon Horman
2014-09-05 15:27 ` [GIT PULL] Renesas ARM Based SoC Init Delay Updates For v3.18 Arnd Bergmann
2014-09-09  2:02   ` Simon Horman
2014-09-09  8:50     ` Arnd Bergmann [this message]
2014-09-05 16:13 ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11409170.rfMyQrIgd0@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).