From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 02FC2C433F5 for ; Mon, 10 Oct 2022 09:10:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7Hp9yC1AzO+Ic7peNuN/ZDerVl9YlNq/3Kip+9vvNHQ=; b=JpCIts5rpuqxWs CWMBz376HGNsv9TJRbkPsDNYYCqnUXZ9Q9wCRIKvQpK8LPKSSzs+Cr8R18tFGZjVtGah/f2oPd7vA 6zAbnZggvUDAVIvO+qQtYdSnnJ3Orc7RapCwGSgi4fCn39qRE0Dxwq1N1LmE0ZzcKzvq1TzRH9qND nQkhHDAd2aac3JSbmFMs+Bo8w1Ql6+kZRN8/NlpXScuLivIXNMhsIHwV3KfpzflKSNbQfi4GiqX/R 1MyUzvFIXfhj2h063pN9v5k0NOv5UF9Eh4eO1oIwf2kuOxnKN/ctkQEQjtQyv1YyACdhREbW/hpFU R1shyMOcU9HxHAQ9IIUQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ohomd-0008vw-3u; Mon, 10 Oct 2022 09:09:11 +0000 Received: from esa.microchip.iphmx.com ([68.232.153.233]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ohomZ-0008uE-7X for linux-arm-kernel@lists.infradead.org; Mon, 10 Oct 2022 09:09:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1665392946; x=1696928946; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=KiaXUf4gF15Ux8A6qcf1bYa4KmiVRrNsO45czAps/+g=; b=xJV0ItSiPpm8fx51utXqnthXxPlxMoGyQK/k6NNcPC530Ja9O6KD5FD+ UxNZSkCD8uJdt0az9YFLaEFM2SGt1ot8r0hZQnUhODP0mLlrrAT9LnJ++ QRoE9om0y2TI7u5yybZJtP7ODk5rcTW86a0aEm5vXnA0d1iJlt1In+nSN OY59h956cUzEU3WrnjLO5c2mI7ZWfcwhIDZcknsGgwIIW1zlhe6F97oIE VXhA5D+fFyYpY1E7JciEgjcudRvuavAMGQdoKClPnUdQHryQivK+RcZZx 4r+lOM3GIUHA4Mth7IEn+WHvHq2YlifcozyVlZHy4RrighqNBR5l+8Q8v g==; X-IronPort-AV: E=Sophos;i="5.95,173,1661842800"; d="scan'208";a="194657043" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa1.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 10 Oct 2022 02:08:58 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Mon, 10 Oct 2022 02:08:41 -0700 Received: from [10.12.72.60] (10.10.115.15) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server id 15.1.2507.12 via Frontend Transport; Mon, 10 Oct 2022 02:08:40 -0700 Message-ID: <11901f5c-a1c8-1470-8bf5-82f73c1ace01@microchip.com> Date: Mon, 10 Oct 2022 11:08:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 2/2] pinctrl: at91-pio4: Add persist state case in config Content-Language: en-US To: , , , , CC: , , References: <20221007151647.98222-1-Ryan.Wanner@microchip.com> <20221007151647.98222-3-Ryan.Wanner@microchip.com> From: Nicolas Ferre Organization: microchip In-Reply-To: <20221007151647.98222-3-Ryan.Wanner@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221010_020907_376082_C697D2F1 X-CRM114-Status: GOOD ( 15.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 07/10/2022 at 17:16, Ryan.Wanner@microchip.com wrote: > From: Ryan Wanner > > Adding persist state case to atmel_conf_pin_config_group_set() function. > After adding configuration support for userspace gpiod api, there was an > extra flag PIN_CONFIG_PERSIST_STATE that was not passed in before. > > Based on other drivers like TI drivers, added a switch case and return > ENOTSUPP in that case. > > Signed-off-by: Ryan Wanner Acked-by: Nicolas Ferre Thanks, best regards, Nicolas > --- > drivers/pinctrl/pinctrl-at91-pio4.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/pinctrl/pinctrl-at91-pio4.c b/drivers/pinctrl/pinctrl-at91-pio4.c > index 13b77f1eb6e2..40f1b9397767 100644 > --- a/drivers/pinctrl/pinctrl-at91-pio4.c > +++ b/drivers/pinctrl/pinctrl-at91-pio4.c > @@ -780,6 +780,8 @@ static int atmel_conf_pin_config_group_get(struct pinctrl_dev *pctldev, > return -EINVAL; > arg = (res & ATMEL_PIO_DRVSTR_MASK) >> ATMEL_PIO_DRVSTR_OFFSET; > break; > + case PIN_CONFIG_PERSIST_STATE: > + return -ENOTSUPP; > default: > return -ENOTSUPP; > } > @@ -888,6 +890,8 @@ static int atmel_conf_pin_config_group_set(struct pinctrl_dev *pctldev, > dev_warn(pctldev->dev, "drive strength not updated (incorrect value)\n"); > } > break; > + case PIN_CONFIG_PERSIST_STATE: > + return -ENOTSUPP; > default: > dev_warn(pctldev->dev, > "unsupported configuration parameter: %u\n", -- Nicolas Ferre _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel