From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04BBCC433EF for ; Fri, 15 Oct 2021 07:56:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C65F160BD3 for ; Fri, 15 Oct 2021 07:56:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C65F160BD3 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:CC:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=i3+VPKUHyh2qiulLvJyIaHV3aucCIpGZhhjTkYW80xQ=; b=Mk/TuMgO4yNAIIufYKmAkya8zy 6LjGdYqSpVg2hj272Idf+Nw5i/AkADopq13oDrLv9u2kd1y5/SQiJHM/q3ZVUasD306zs+xPS25v9 rCT7QJLLufj6NRFHBNGxO6B1cN6WfVGlyWexlR5b+rO7JMaJqpCtDcpkD7dN1YCUbBs17Cs2q82Bv znOZproBDg5DjzNgzDgfWEnM44Jah63xSTNnlPJNkB4r6D/xWWjYmfdRbcZBR0SI3wpQtMgFXo09/ B8H4QMIbrFDL8f4bmt6IeTFbUr3iaJex00wvCK0aGvdM/3cJc7KVtlU+c9jJo2PXWMYDumVihc2ms koLldCtw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mbI2o-005mQu-Oq; Fri, 15 Oct 2021 07:54:23 +0000 Received: from esa.microchip.iphmx.com ([68.232.154.123]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mbI25-005mAX-1a for linux-arm-kernel@lists.infradead.org; Fri, 15 Oct 2021 07:53:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1634284417; x=1665820417; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=qOZVawR/4Z3U1gtxeNah2+OwiB4/ctcc6Tz3DAb3yiw=; b=YcqbBID5WRey0JUBfebLbJe7UzebpLg1rIyu2LPy9ftGC6AiRIB4NmWy f3QrKR6bu0fDFGm3t0HT+nNT0lcww3YPyNAD0tDzK1zzj3jwMUtjMn0Ho f/Xj2AztBMO5dGMyFPE9ccbYPWjuegNN1glwqUTtQIhFUQ/eBbZvl8yIJ mdB1xnBJ9RnNtM+ANp2RuEd6RKhAf1fWXM/Yxc0vFAcdxyP2TGvR9XkTu u3infhK56NJGeG2da7/gY4m30CVH0d92efzcq+bAAMIHKod+bXL96y6QM kT49DbRWw10+X8jlwkHnp5ID7xdZ/3kfaBo5gka/XIvPzxpRVDy4yD+UM A==; IronPort-SDR: vESsJ3HFiBUeqLP+75uyNqmu3Un1qo+N7oNFbTosKHTkyvo0IshQuR3F8TLxX0IRVp9OkMPwI3 XoeKE2xyVg+PhpkPhaXAyvLiqaN7PH+k0JBsbmqgEAmizWM/wBu4aVkJZ3S0BpkiSbjOQJuNiz Je/fRpKw0KiK+jNXQfybhcR43CsaXXcSgoARBbwFacbzN6jDK1fc24VcI/2wfZGpeR3XW0EcXJ Gmo6S4DPXnDAHkSUpC74ui+vCm3/8MHc7YQk3+PfkaUQJ+cDKv/uobE6q0nFxb22qnjEmPrdl5 bmXonB11zFFNEcIgtoP5Q7Id X-IronPort-AV: E=Sophos;i="5.85,375,1624345200"; d="scan'208";a="135629748" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa2.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 15 Oct 2021 00:53:35 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.85.144) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Fri, 15 Oct 2021 00:53:34 -0700 Received: from [10.12.67.94] (10.10.115.15) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Fri, 15 Oct 2021 00:53:32 -0700 Subject: Re: [PATCH v5 05/15] clk: at91: clk-master: improve readability by using local variables To: Claudiu Beznea , , , , CC: , , References: <20211011112719.3951784-1-claudiu.beznea@microchip.com> <20211011112719.3951784-6-claudiu.beznea@microchip.com> From: Nicolas Ferre Organization: microchip Message-ID: <11e656f6-85f6-f733-36b8-8871a8600cf2@microchip.com> Date: Fri, 15 Oct 2021 09:53:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20211011112719.3951784-6-claudiu.beznea@microchip.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211015_005337_254915_5A5F08C9 X-CRM114-Status: GOOD ( 14.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11/10/2021 at 13:27, Claudiu Beznea wrote: > Improve readability in clk_sama7g5_master_set() by using local > variables. > > Suggested-by: Nicolas Ferre > Signed-off-by: Claudiu Beznea So, obviously ;-) : Acked-by: Nicolas Ferre Thanks Claudiu! > --- > drivers/clk/at91/clk-master.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/clk/at91/clk-master.c b/drivers/clk/at91/clk-master.c > index 88f7af1bfff6..9a2c8e64cacf 100644 > --- a/drivers/clk/at91/clk-master.c > +++ b/drivers/clk/at91/clk-master.c > @@ -680,6 +680,8 @@ static void clk_sama7g5_master_set(struct clk_master *master, > unsigned long flags; > unsigned int val, cparent; > unsigned int enable = status ? AT91_PMC_MCR_V2_EN : 0; > + unsigned int parent = master->parent << PMC_MCR_CSS_SHIFT; > + unsigned int div = master->div << MASTER_DIV_SHIFT; > > spin_lock_irqsave(master->lock, flags); > > @@ -689,9 +691,7 @@ static void clk_sama7g5_master_set(struct clk_master *master, > regmap_update_bits(master->regmap, AT91_PMC_MCR_V2, > enable | AT91_PMC_MCR_V2_CSS | AT91_PMC_MCR_V2_DIV | > AT91_PMC_MCR_V2_CMD | AT91_PMC_MCR_V2_ID_MSK, > - enable | (master->parent << PMC_MCR_CSS_SHIFT) | > - (master->div << MASTER_DIV_SHIFT) | > - AT91_PMC_MCR_V2_CMD | > + enable | parent | div | AT91_PMC_MCR_V2_CMD | > AT91_PMC_MCR_V2_ID(master->id)); > > cparent = (val & AT91_PMC_MCR_V2_CSS) >> PMC_MCR_CSS_SHIFT; > -- Nicolas Ferre _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel