From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE80DC7618B for ; Fri, 26 Jul 2019 14:51:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A3A3621852 for ; Fri, 26 Jul 2019 14:51:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MYXI0BOK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A3A3621852 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uLkBIRldOwGUBYHukFYpEf8hlsdwEoiPQFFvpFWzRVc=; b=MYXI0BOKlSSgEb rUMeQPiWkMUOCAdyy0j5YJ1r9m5Q0lz2XQevfy2GwG7qof064xIogvf0sMqTnB9Mjl82lsie1Vwxo s7XSJFTPjotVoJl4AiokBEGFwWUqPsyB+SWvjsCRs04LI3i23e7cpJsG7Svc8s5ztwL0M/wUvym1k mW588LVjN7R8pbfc1ixA8TEtss8OyWbKXZrAVmIoTIMZPXm+OzhzCPnP6YDrvVdzOIx4qzJ0LwTaD UMYf0SbqTMI01RI62ZzcrEa05mTGvKkWNcBKhqHKstADM8paBXdUzwqaaOEnz7Dx1X7U6V6PD0KR5 U9CnChdLIkU1ZzOCQo3Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hr1Z4-000862-PC; Fri, 26 Jul 2019 14:51:22 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hr1Z0-00085M-Vf for linux-arm-kernel@lists.infradead.org; Fri, 26 Jul 2019 14:51:21 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6476D337; Fri, 26 Jul 2019 07:51:18 -0700 (PDT) Received: from [10.1.196.105] (eglon.cambridge.arm.com [10.1.196.105]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E782E3F71F; Fri, 26 Jul 2019 07:51:16 -0700 (PDT) Subject: Re: [PATCH v9 8/8] EDAC: armada_xp: Add support for more SoCs To: Chris Packham References: <20190712034904.5747-1-chris.packham@alliedtelesis.co.nz> <20190712034904.5747-9-chris.packham@alliedtelesis.co.nz> From: James Morse Message-ID: <128016c1-380f-70c4-3a89-2d3b0edf9f88@arm.com> Date: Fri, 26 Jul 2019 15:51:15 +0100 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20190712034904.5747-9-chris.packham@alliedtelesis.co.nz> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190726_075120_319733_F62220F1 X-CRM114-Status: GOOD ( 14.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, jlu@pengutronix.de, linux-edac@vger.kernel.org, linux@armlinux.org.uk, linux-kernel@vger.kernel.org, robh+dt@kernel.org, bp@alien8.de, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, patches@armlinux.org.uk Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Chris, On 12/07/2019 04:49, Chris Packham wrote: > The Armada 38x and other integrated SoCs use a reduced pin count so the > width of the SDRAM interface is smaller than the Armada XP SoCs. This > means that the definition of "full" and "half" width is reduced from > 64/32 to 32/16. > diff --git a/drivers/edac/armada_xp_edac.c b/drivers/edac/armada_xp_edac.c > index 3759a4fbbdee..7f227bdcbc84 100644 > --- a/drivers/edac/armada_xp_edac.c > +++ b/drivers/edac/armada_xp_edac.c > @@ -332,6 +332,11 @@ static int axp_mc_probe(struct platform_device *pdev) > > axp_mc_read_config(mci); > > + /* These SoCs have a reduced width bus */ > + if (of_machine_is_compatible("marvell,armada380") || > + of_machine_is_compatible("marvell,armadaxp-98dx3236")) > + drvdata->width /= 2; So the hardware's SDRAM_CONFIG_BUS_WIDTH value is wrong? Yuck. Is it too late for the DTs on these two systems to provide a DT version of the 'bus_width' to override the hardware's mis-advertised value? This way you don't need to grow this list. Acked-by: James Morse Thanks, James _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel