From: James.Bottomley@suse.de (James Bottomley)
To: linux-arm-kernel@lists.infradead.org
Subject: [Security] [PATCH 00/20] world-writable files in sysfs and debugfs
Date: Tue, 15 Mar 2011 10:25:51 -0400 [thread overview]
Message-ID: <1300199151.7744.12.camel@mulgrave.site> (raw)
In-Reply-To: <20110315141859.GA19442@kroah.com>
On Tue, 2011-03-15 at 07:18 -0700, Greg KH wrote:
> On Tue, Mar 15, 2011 at 07:50:28AM -0400, James Bottomley wrote:
> > On Mon, 2011-03-14 at 20:09 -0700, Greg KH wrote:
> > > There are no capability checks on sysfs files right now, so these all
> > > need to be fixed.
> >
> > That statement is true but irrelevant, isn't it? There can't be
> > capabilities within sysfs files because the system that does them has no
> > idea what the capabilities would be. If there were capabilities checks,
> > they'd have to be in the implementing routines.
>
> Ah, you are correct, sorry for the misunderstanding.
>
> > I think the questions are twofold:
> >
> > 1. Did anyone actually check for capabilities before assuming world
> > writeable files were wrong?
>
> I do not think so as the majority (i.e. all the ones that I looked at)
> did no such checks.
OK, as long as someone checked, I'm happy.
> > 2. Even if there aren't any capabilities checks in the implementing
> > routines, should there be (are we going the separated
> > capabilities route vs the monolithic root route)?
>
> I think the general consensus is that we go the monolithic root route
> for sysfs files in that we do not allow them to be world writable.
>
> Do you have any exceptions that you know of that do these checks?
Heh, I didn't call our security vacillations a dizzying ride for
nothing. I know the goal once was to try to run a distro without root
daemons (which is what required the capabilities stuff). I'm actually
trying to avoid the issue ... I just want to make sure that people who
care aren't all moving in different directions.
James
next prev parent reply other threads:[~2011-03-15 14:25 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-04 12:22 [PATCH 00/20] world-writable files in sysfs and debugfs Vasiliy Kulikov
2011-02-04 12:23 ` [PATCH 01/20] mach-omap2: mux: world-writable debugfs files Vasiliy Kulikov
2011-02-04 20:09 ` Tony Lindgren
2011-02-04 12:23 ` [PATCH 02/20] mach-omap2: pm: world-writable debugfs timer files Vasiliy Kulikov
2011-02-04 20:10 ` Tony Lindgren
2011-02-04 22:53 ` Kevin Hilman
2011-02-04 12:23 ` [PATCH 03/20] mach-omap2: smartreflex: world-writable debugfs voltage files Vasiliy Kulikov
2011-02-04 20:10 ` Tony Lindgren
2011-02-04 22:54 ` Kevin Hilman
2011-02-07 5:33 ` Menon, Nishanth
2011-02-04 12:23 ` [PATCH 04/20] mach-ux500: mbox-db5500: world-writable sysfs fifo file Vasiliy Kulikov
2011-02-04 12:23 ` [PATCH 08/20] mfd: ab3100: world-writable debugfs *_priv files Vasiliy Kulikov
2011-02-04 12:23 ` [PATCH 09/20] mfd: ab3500: world-writable debugfs register-* files Vasiliy Kulikov
2011-02-04 12:23 ` [PATCH 10/20] mfd: ab8500: " Vasiliy Kulikov
2011-02-04 13:11 ` [rtc-linux] [PATCH 00/20] world-writable files in sysfs and debugfs Linus Walleij
2011-03-12 20:23 ` Vasiliy Kulikov
2011-03-14 22:18 ` [Security] " Andrew Morton
2011-03-15 2:26 ` James Bottomley
2011-03-15 3:09 ` [Security] " Greg KH
2011-03-15 11:50 ` James Bottomley
2011-03-15 14:18 ` Greg KH
2011-03-15 14:25 ` James Bottomley [this message]
2011-03-15 16:08 ` Vasiliy Kulikov
2011-03-15 16:32 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300199151.7744.12.camel@mulgrave.site \
--to=james.bottomley@suse.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).