From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9D2B2C6FD1D for ; Mon, 20 Mar 2023 16:20:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dGI1CO4Fmx5AVZ1xltSw9iB43X1D4ws8CYNSF/AkZx0=; b=JrCDkrlJcELql5 kjbeGLONNwL9uCn1MmySYW2CQ2E6KK/lJjMaeU9e1wkLWT666Yuo3QLxe1AsdBxp04IOfF+RbOt9/ uWEUQnDLdTKB0Ypxg3pOTTdSxAKWEecKHO76VmQibeBahP9gJ/ZM1xpliE/VDAno7uEt5hRnUhuO0 xpISK+VVb/HrrK85lp7DpYbLn6gAc4bXuA8sVH4wTKce91TmmI/o5fVW2uHPAqQvGY6DdP52UyVRp ZyiUkZqxCjAGjZsMuv5tNkLuws+gZyUjgL0mArusZbvb6yiyZXV+DlIuQdcNEDEsqAnioU2mgei7A /smsuAsvz31bsF5daZeg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1peIDz-009kG1-38; Mon, 20 Mar 2023 16:19:07 +0000 Received: from lelv0143.ext.ti.com ([198.47.23.248]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1peIDw-009kEp-1G for linux-arm-kernel@lists.infradead.org; Mon, 20 Mar 2023 16:19:06 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 32KGItjd048864; Mon, 20 Mar 2023 11:18:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1679329135; bh=TV5xrOJHNTkQRHNTWPevo+vvjls9WVfFGAOlRBzE0tA=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=appZFvfZvdK9Lpywew3m+eSgxUjq3O8zAxcxcWk32c3neqCGuBqy+0p6YdjRPeVh0 XuzcJ9RXRCe4ispupbAKvtXx7eJx93pSVvJ8RCfo7rcCTV1jZQ4PeT7Y/YUsW6VwfE zPKPz7v0xe+pbf4FWBjdeRMPRTx6+MEn1Onh0two= Received: from DFLE107.ent.ti.com (dfle107.ent.ti.com [10.64.6.28]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 32KGItSb077637 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 20 Mar 2023 11:18:55 -0500 Received: from DFLE110.ent.ti.com (10.64.6.31) by DFLE107.ent.ti.com (10.64.6.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Mon, 20 Mar 2023 11:18:55 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE110.ent.ti.com (10.64.6.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Mon, 20 Mar 2023 11:18:55 -0500 Received: from [10.250.33.229] (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 32KGIsx0025182; Mon, 20 Mar 2023 11:18:54 -0500 Message-ID: <13048b01-641a-1d92-178c-02b87c5fa1b9@ti.com> Date: Mon, 20 Mar 2023 11:18:54 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [EXTERNAL] Re: [PATCH v4 2/5] soc: ti: pruss: Add pruss_{request,release}_mem_region() API Content-Language: en-US To: Md Danish Anwar , Roger Quadros , MD Danish Anwar , Suman Anna , Vignesh Raghavendra , Mathieu Poirier , Bjorn Andersson , Santosh Shilimkar , Nishanth Menon CC: , , , , , , References: <20230313111127.1229187-1-danishanwar@ti.com> <20230313111127.1229187-3-danishanwar@ti.com> <3f26b194-287c-074d-8e78-572875f9a734@kernel.org> <52aeb13f-1fe4-825f-9d28-ba64860ae76d@ti.com> From: Andrew Davis In-Reply-To: <52aeb13f-1fe4-825f-9d28-ba64860ae76d@ti.com> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230320_091904_536925_BE8F0917 X-CRM114-Status: GOOD ( 27.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/20/23 12:11 AM, Md Danish Anwar wrote: > Hi Roger, > > On 17/03/23 14:26, Roger Quadros wrote: >> Hi Andrew & Danish, >> >> >> On 13/03/2023 13:11, MD Danish Anwar wrote: >>> From: "Andrew F. Davis" >>> >>> Add two new API - pruss_request_mem_region() & pruss_release_mem_region(), >>> to the PRUSS platform driver to allow client drivers to acquire and release >>> the common memory resources present within a PRU-ICSS subsystem. This >>> allows the client drivers to directly manipulate the respective memories, >>> as per their design contract with the associated firmware. >>> >>> Co-developed-by: Suman Anna >>> Signed-off-by: Suman Anna >>> Signed-off-by: Andrew F. Davis >>> Co-developed-by: Grzegorz Jaszczyk >>> Signed-off-by: Grzegorz Jaszczyk >>> Signed-off-by: MD Danish Anwar >>> Reviewed-by: Roger Quadros >>> --- >>> drivers/soc/ti/pruss.c | 77 ++++++++++++++++++++++++++++++++ >>> include/linux/pruss_driver.h | 27 +++-------- >>> include/linux/remoteproc/pruss.h | 39 ++++++++++++++++ >> >> >> We have these 2 header files and I think anything that deals with >> 'struct pruss' should go in include/linux/pruss_driver.h >> >> Anything that deals with pru_rproc (i.e. struct rproc) should go in >> include/linux/remoteproc/pruss.h >> >> Do you agree? >> > > I agree with you Roger but Andrew is the right person to comment here as he is > the author of this and several other patches. > > Hi Andrew, Can you please comment on this? > Original idea was a consumer driver (like "ICSSG Ethernet Driver" in your other series) could just #include and get everything they need, and nothing they do not. pruss_driver.h (which could be renamed pruss_internal.h) exists to allow comunication between the pruss core and the pru rproc driver which live in different subsystems. Andrew >>> 3 files changed, 121 insertions(+), 22 deletions(-) >>> >>> diff --git a/drivers/soc/ti/pruss.c b/drivers/soc/ti/pruss.c >>> index a169aa1ed044..c8053c0d735f 100644 >>> --- a/drivers/soc/ti/pruss.c >>> +++ b/drivers/soc/ti/pruss.c >>> @@ -88,6 +88,82 @@ void pruss_put(struct pruss *pruss) >>> } >>> EXPORT_SYMBOL_GPL(pruss_put); >>> >>> +/** >>> + * pruss_request_mem_region() - request a memory resource >>> + * @pruss: the pruss instance >>> + * @mem_id: the memory resource id >>> + * @region: pointer to memory region structure to be filled in >>> + * >>> + * This function allows a client driver to request a memory resource, >>> + * and if successful, will let the client driver own the particular >>> + * memory region until released using the pruss_release_mem_region() >>> + * API. >>> + * >>> + * Return: 0 if requested memory region is available (in such case pointer to >>> + * memory region is returned via @region), an error otherwise >>> + */ >>> +int pruss_request_mem_region(struct pruss *pruss, enum pruss_mem mem_id, >>> + struct pruss_mem_region *region) >>> +{ >>> + if (!pruss || !region || mem_id >= PRUSS_MEM_MAX) >>> + return -EINVAL; >>> + >>> + mutex_lock(&pruss->lock); >>> + >>> + if (pruss->mem_in_use[mem_id]) { >>> + mutex_unlock(&pruss->lock); >>> + return -EBUSY; >>> + } >>> + >>> + *region = pruss->mem_regions[mem_id]; >>> + pruss->mem_in_use[mem_id] = region; >>> + >>> + mutex_unlock(&pruss->lock); >>> + >>> + return 0; >>> +} >>> +EXPORT_SYMBOL_GPL(pruss_request_mem_region); >>> + >>> +/** >>> + * pruss_release_mem_region() - release a memory resource >>> + * @pruss: the pruss instance >>> + * @region: the memory region to release >>> + * >>> + * This function is the complimentary function to >>> + * pruss_request_mem_region(), and allows the client drivers to >>> + * release back a memory resource. >>> + * >>> + * Return: 0 on success, an error code otherwise >>> + */ >>> +int pruss_release_mem_region(struct pruss *pruss, >>> + struct pruss_mem_region *region) >>> +{ >>> + int id; >>> + >>> + if (!pruss || !region) >>> + return -EINVAL; >>> + >>> + mutex_lock(&pruss->lock); >>> + >>> + /* find out the memory region being released */ >>> + for (id = 0; id < PRUSS_MEM_MAX; id++) { >>> + if (pruss->mem_in_use[id] == region) >>> + break; >>> + } >>> + >>> + if (id == PRUSS_MEM_MAX) { >>> + mutex_unlock(&pruss->lock); >>> + return -EINVAL; >>> + } >>> + >>> + pruss->mem_in_use[id] = NULL; >>> + >>> + mutex_unlock(&pruss->lock); >>> + >>> + return 0; >>> +} >>> +EXPORT_SYMBOL_GPL(pruss_release_mem_region); >>> + >>> static void pruss_of_free_clk_provider(void *data) >>> { >>> struct device_node *clk_mux_np = data; >>> @@ -290,6 +366,7 @@ static int pruss_probe(struct platform_device *pdev) >>> return -ENOMEM; >>> >>> pruss->dev = dev; >>> + mutex_init(&pruss->lock); >>> >>> child = of_get_child_by_name(np, "memories"); >>> if (!child) { >>> diff --git a/include/linux/pruss_driver.h b/include/linux/pruss_driver.h >>> index 86242fb5a64a..22b4b37d2536 100644 >>> --- a/include/linux/pruss_driver.h >>> +++ b/include/linux/pruss_driver.h >>> @@ -9,37 +9,18 @@ >>> #ifndef _PRUSS_DRIVER_H_ >>> #define _PRUSS_DRIVER_H_ >>> >>> +#include >>> #include >>> #include >>> >>> -/* >>> - * enum pruss_mem - PRUSS memory range identifiers >>> - */ >>> -enum pruss_mem { >>> - PRUSS_MEM_DRAM0 = 0, >>> - PRUSS_MEM_DRAM1, >>> - PRUSS_MEM_SHRD_RAM2, >>> - PRUSS_MEM_MAX, >>> -}; >>> - >>> -/** >>> - * struct pruss_mem_region - PRUSS memory region structure >>> - * @va: kernel virtual address of the PRUSS memory region >>> - * @pa: physical (bus) address of the PRUSS memory region >>> - * @size: size of the PRUSS memory region >>> - */ >>> -struct pruss_mem_region { >>> - void __iomem *va; >>> - phys_addr_t pa; >>> - size_t size; >>> -}; >>> - >>> /** >>> * struct pruss - PRUSS parent structure >>> * @dev: pruss device pointer >>> * @cfg_base: base iomap for CFG region >>> * @cfg_regmap: regmap for config region >>> * @mem_regions: data for each of the PRUSS memory regions >>> + * @mem_in_use: to indicate if memory resource is in use >>> + * @lock: mutex to serialize access to resources >>> * @core_clk_mux: clk handle for PRUSS CORE_CLK_MUX >>> * @iep_clk_mux: clk handle for PRUSS IEP_CLK_MUX >>> */ >>> @@ -48,6 +29,8 @@ struct pruss { >>> void __iomem *cfg_base; >>> struct regmap *cfg_regmap; >>> struct pruss_mem_region mem_regions[PRUSS_MEM_MAX]; >>> + struct pruss_mem_region *mem_in_use[PRUSS_MEM_MAX]; >>> + struct mutex lock; /* PRU resource lock */ >>> struct clk *core_clk_mux; >>> struct clk *iep_clk_mux; >>> }; >>> diff --git a/include/linux/remoteproc/pruss.h b/include/linux/remoteproc/pruss.h >>> index 93a98cac7829..33f930e0a0ce 100644 >>> --- a/include/linux/remoteproc/pruss.h >>> +++ b/include/linux/remoteproc/pruss.h >>> @@ -44,6 +44,28 @@ enum pru_ctable_idx { >>> PRU_C31, >>> }; >>> >>> +/* >>> + * enum pruss_mem - PRUSS memory range identifiers >>> + */ >>> +enum pruss_mem { >>> + PRUSS_MEM_DRAM0 = 0, >>> + PRUSS_MEM_DRAM1, >>> + PRUSS_MEM_SHRD_RAM2, >>> + PRUSS_MEM_MAX, >>> +}; >>> + >>> +/** >>> + * struct pruss_mem_region - PRUSS memory region structure >>> + * @va: kernel virtual address of the PRUSS memory region >>> + * @pa: physical (bus) address of the PRUSS memory region >>> + * @size: size of the PRUSS memory region >>> + */ >>> +struct pruss_mem_region { >>> + void __iomem *va; >>> + phys_addr_t pa; >>> + size_t size; >>> +}; >>> + >>> struct device_node; >>> struct rproc; >>> struct pruss; >>> @@ -52,6 +74,10 @@ struct pruss; >>> >>> struct pruss *pruss_get(struct rproc *rproc); >>> void pruss_put(struct pruss *pruss); >>> +int pruss_request_mem_region(struct pruss *pruss, enum pruss_mem mem_id, >>> + struct pruss_mem_region *region); >>> +int pruss_release_mem_region(struct pruss *pruss, >>> + struct pruss_mem_region *region); >>> >>> #else >>> >>> @@ -62,6 +88,19 @@ static inline struct pruss *pruss_get(struct rproc *rproc) >>> >>> static inline void pruss_put(struct pruss *pruss) { } >>> >>> +static inline int pruss_request_mem_region(struct pruss *pruss, >>> + enum pruss_mem mem_id, >>> + struct pruss_mem_region *region) >>> +{ >>> + return -EOPNOTSUPP; >>> +} >>> + >>> +static inline int pruss_release_mem_region(struct pruss *pruss, >>> + struct pruss_mem_region *region) >>> +{ >>> + return -EOPNOTSUPP; >>> +} >>> + >>> #endif /* CONFIG_TI_PRUSS */ >>> >>> #if IS_ENABLED(CONFIG_PRU_REMOTEPROC) >> >> cheers, >> -roger > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel