linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v5 00/15] add ecspi ERR009165 for i.mx6/7 soc family
@ 2019-06-10  8:17 yibin.gong
  2019-06-10  8:17 ` [PATCH v5 01/15] Revert "ARM: dts: imx6q: Use correct SDMA script for SPI5 core" yibin.gong
                   ` (15 more replies)
  0 siblings, 16 replies; 38+ messages in thread
From: yibin.gong @ 2019-06-10  8:17 UTC (permalink / raw)
  To: robh+dt, mark.rutland, shawnguo, s.hauer, kernel, broonie,
	festevam, vkoul, dan.j.williams, u.kleine-koenig,
	catalin.marinas, l.stach, will.deacon
  Cc: devicetree, linux-kernel, linux-spi, linux-imx, dmaengine,
	linux-arm-kernel

From: Robin Gong <yibin.gong@nxp.com>

  There is ecspi ERR009165 on i.mx6/7 soc family, which cause FIFO
transfer to be send twice in DMA mode. Please get more information from:
https://www.nxp.com/docs/en/errata/IMX6DQCE.pdf. The workaround is adding
new sdma ram script which works in XCH  mode as PIO inside sdma instead
of SMC mode, meanwhile, 'TX_THRESHOLD' should be 0. The issue should be
exist on all legacy i.mx6/7 soc family before i.mx6ul.
  NXP fix this design issue from i.mx6ul, so newer chips including i.mx6ul/
6ull/6sll do not need this workaroud anymore. All other i.mx6/7/8 chips
still need this workaroud. This patch set add new 'fsl,imx6ul-ecspi'
for ecspi driver and 'ecspi_fixed' in sdma driver to choose if need errata
or not.
  The first two reverted patches should be the same issue, though, it
seems 'fixed' by changing to other shp script. Hope Sean or Sascha could
have the chance to test this patch set if could fix their issues.
  Besides, enable sdma support for i.mx8mm/8mq and fix ecspi1 not work
on i.mx8mm because the event id is zero.

PS:
   Please get sdma firmware from below linux-firmware and copy it to your
local rootfs /lib/firmware/imx/sdma.
https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/imx/sdma

v2:
  1.Add commit log for reverted patches.
  2.Add comment for 'ecspi_fixed' in sdma driver.
  3.Add 'fsl,imx6sll-ecspi' compatible instead of 'fsl,imx6ul-ecspi'
    rather than remove.
v3:
  1.Confirm with design team make sure ERR009165 fixed on i.mx6ul/i.mx6ull
    /i.mx6sll, not fixed on i.mx8m/8mm and other i.mx6/7 legacy chips.
    Correct dts related dts patch in v2.
  2.Clean eratta information in binding doc and new 'tx_glitch_fixed' flag
    in spi-imx driver to state ERR009165 fixed or not.
  3.Enlarge burst size to fifo size for tx since tx_wml set to 0 in the
    errata workaroud, thus improve performance as possible.
v4:
  1.add Ack tag from Mark and Vinod
  2. remove checking 'event_id1' zero as 'event_id0'.
v5:
  1.Add another patch for compatible with the current uart driver which
    using rom script, so both uart ram script and rom script supported
    in latest firmware, by default uart rom script used. UART driver
    will be broken without this patch. Latest sdma firmware has been
    already updated in linux-firmware. 

Robin Gong (15):
  Revert "ARM: dts: imx6q: Use correct SDMA script for SPI5 core"
  Revert "ARM: dts: imx6: Use correct SDMA script for SPI cores"
  Revert "dmaengine: imx-sdma: refine to load context only once"
  dmaengine: imx-sdma: remove dupilicated sdma_load_context
  dmaengine: imx-sdma: add mcu_2_ecspi script
  spi: imx: fix ERR009165
  spi: imx: remove ERR009165 workaround on i.mx6ul
  spi: imx: add new i.mx6ul compatible name in binding doc
  dmaengine: imx-sdma: remove ERR009165 on i.mx6ul
  dma: imx-sdma: add i.mx6ul/6sx compatible name
  dmaengine: imx-sdma: fix ecspi1 rx dma not work on i.mx8mm
  ARM: dts: imx6ul: add dma support on ecspi
  ARM: dts: imx6sll: correct sdma compatible
  arm64: defconfig: Enable SDMA on i.mx8mq/8mm
  dmaengine: imx-sdma: add uart rom script

 .../devicetree/bindings/dma/fsl-imx-sdma.txt       |  2 +
 .../devicetree/bindings/spi/fsl-imx-cspi.txt       |  1 +
 arch/arm/boot/dts/imx6q.dtsi                       |  2 +-
 arch/arm/boot/dts/imx6qdl.dtsi                     |  8 +-
 arch/arm/boot/dts/imx6sll.dtsi                     |  2 +-
 arch/arm/boot/dts/imx6ul.dtsi                      |  8 ++
 arch/arm64/configs/defconfig                       |  3 +
 drivers/dma/imx-sdma.c                             | 88 ++++++++++++++++------
 drivers/spi/spi-imx.c                              | 61 ++++++++++++---
 include/linux/platform_data/dma-imx-sdma.h         | 11 ++-
 10 files changed, 145 insertions(+), 41 deletions(-)

-- 
2.7.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 38+ messages in thread

end of thread, other threads:[~2020-02-10 12:28 UTC | newest]

Thread overview: 38+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-10  8:17 [PATCH v5 00/15] add ecspi ERR009165 for i.mx6/7 soc family yibin.gong
2019-06-10  8:17 ` [PATCH v5 01/15] Revert "ARM: dts: imx6q: Use correct SDMA script for SPI5 core" yibin.gong
2019-06-10  8:17 ` [PATCH v5 02/15] Revert "ARM: dts: imx6: Use correct SDMA script for SPI cores" yibin.gong
2019-06-10  8:17 ` [PATCH v5 03/15] Revert "dmaengine: imx-sdma: refine to load context only once" yibin.gong
2019-06-10  8:17 ` [PATCH v5 04/15] dmaengine: imx-sdma: remove dupilicated sdma_load_context yibin.gong
2019-06-10  8:17 ` [PATCH v5 05/15] dmaengine: imx-sdma: add mcu_2_ecspi script yibin.gong
2019-06-10  8:17 ` [PATCH v5 06/15] spi: imx: fix ERR009165 yibin.gong
2019-06-10  8:17 ` [PATCH v5 07/15] spi: imx: remove ERR009165 workaround on i.mx6ul yibin.gong
2019-06-10  8:17 ` [PATCH v5 08/15] spi: imx: add new i.mx6ul compatible name in binding doc yibin.gong
2019-07-09  2:17   ` Rob Herring
2019-06-10  8:17 ` [PATCH v5 09/15] dmaengine: imx-sdma: remove ERR009165 on i.mx6ul yibin.gong
2019-06-10  8:17 ` [PATCH v5 10/15] dma: imx-sdma: add i.mx6ul/6sx compatible name yibin.gong
2019-06-11 22:35   ` Rob Herring
2019-06-12  2:32     ` Robin Gong
2019-06-10  8:17 ` [PATCH v5 11/15] dmaengine: imx-sdma: fix ecspi1 rx dma not work on i.mx8mm yibin.gong
2019-09-24 13:27   ` Schrempf Frieder
2019-09-25 11:26     ` Robin Gong
2019-09-25 14:53       ` Schrempf Frieder
2019-09-27  1:55         ` Robin Gong
2020-02-06 10:17           ` Schrempf Frieder
2020-02-10 12:28             ` Robin Gong
2019-06-10  8:17 ` [PATCH v5 12/15] ARM: dts: imx6ul: add dma support on ecspi yibin.gong
2019-07-17  6:42   ` Shawn Guo
2019-07-23  9:39     ` Robin Gong
2019-07-24  0:48       ` Shawn Guo
2019-07-24  1:53         ` Robin Gong
2019-09-24  9:53           ` Robin Gong
2019-06-10  8:17 ` [PATCH v5 13/15] ARM: dts: imx6sll: correct sdma compatible yibin.gong
2019-07-17  6:42   ` Shawn Guo
2019-06-10  8:17 ` [PATCH v5 14/15] arm64: defconfig: Enable SDMA on i.mx8mq/8mm yibin.gong
2019-07-17  6:48   ` Shawn Guo
2019-06-10  8:17 ` [PATCH v5 15/15] dmaengine: imx-sdma: add uart rom script yibin.gong
2019-06-10 12:55   ` Vinod Koul
2019-06-11  3:04     ` Robin Gong
2019-06-11  4:37       ` Vinod Koul
2019-06-21  8:42 ` [PATCH v5 00/15] add ecspi ERR009165 for i.mx6/7 soc family Robin Gong
2019-06-24  0:16   ` Shawn Guo
2019-06-25  8:05     ` Robin Gong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).