From mboxrd@z Thu Jan 1 00:00:00 1970 From: vinod.koul@intel.com (Koul, Vinod) Date: Thu, 04 Aug 2011 09:55:18 +0530 Subject: [PATCH 09/18] dmaengine/amba-pl08x: Schedule tasklet in case of error interrupt In-Reply-To: References: <9c81beb9cd84f84b58abbd24ebfae85dfe8d8ee1.1311936524.git.viresh.kumar@st.com> <1311941799.1536.532.camel@vkoul-udesk3> Message-ID: <1312431918.1536.559.camel@vkoul-udesk3> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, 2011-07-29 at 08:30 -0700, viresh kumar wrote: > On 7/29/11, Koul, Vinod wrote: > > On Fri, 2011-07-29 at 16:19 +0530, Viresh Kumar wrote: > >> + dev_err(&pl08x->adev->dev, "%s error interrupt, register value" > >> + "0x%08x\n", __func__, err); > > again this looks convoluted, and the stuff is quotes can be in single > > line :) > > Will take care of this in all patches. > > > but in tasklet you will call the client callback, so how does the client > > know if this was success or error? Did I miss anything? > > No you didn't. I couldn't find a way in framework to report back to > client success or failure. > Is there any way? For now i have only kept error prints. Sorry for not responding earlier. Yes that's the whole point, today callback mechanism doesn't tell the _status_ of the transfer (which if we need change can be discussed as well), but to counter argue I have never been able to generate the error interrupt, are you able to do on your controller? One more point wrt this patch, what do we gain here from calling tasklet, are you cleaning up your queue for the error descriptor or something, I think not. so just calling to print doesn't make sense to me, comments? -- ~Vinod